Hi,
today I’ve played again with the style editor after the last fixes. No hard crashes, much better experience, nice.
Compared to the CSS editor still available on 2.9.x there are still a few significant regressions though, making
the usage less productive than it used to be:
- The CSS editor on submit converted the style to SLD, thus generating visible user errors/feedback about the process. The current editor instead does not that, and the preview occasionally is just a broken image, forcing the editor to go hunt in the GeoServer logs for the actual error. I warmly recommend to get the previous behavior back, it can be easily done without any knowledge of the actual style type by calling “parse” on the StyleHandler. This would also improve SLD own editing, as sometimes one uses a filter function that does not exist, and formally, the style still validates fine. I’d add this behavior at last to “apply”, I’m not sure about “submit”, since in the past the editor allowed to save invalid styles, it may be that someone wants to just save a invalid work in progress for whatever reason (e.g., meeting, lunch break, general need to get away from the computer)
- When hitting “apply” the entire page is reloaded and so is the preview… this is highly disruptive when editing a multi-scale style, as the preview is reset back to showing the entire layer. The CSS editor submit button applies “in place” instead, keeping the map where it is, just showing the new style (without requiring the editor to interact with it, e.g., no moving or zooming required)
- As noted before, the screen space is not used in an optimal way, often forcing to scroll up and down while editing and previewing
I’ve seen by mail that Torben agreed to open tickets for whatever residual issue was left out to be addressed… but I don’t see them yet in Jira.
Should I start opening some?
Cheers
Andrea
···
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.