Last week I invested into a patch for moving from acegi security to spring security 2.0.6
See:
http://jira.codehaus.org/browse/GEOS-4215
The patch touches a lot of files, a quick check today shows me that I have to merge some files since they have changed in the repository since last week.
I want to ask what I should do:
1) Create an updated patch file
or
2) merge the changes and commit.
Cheers
Christian
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
Looked over the patch and it looks ok to me. But security is not a subsystem i am very familiar with.
I applied the and it is a bit out of date with the changes to legacy… but no big deal, just skipped that part.
Tried to build with tests… ran into some failures but not sure they are related.
Anyways, no objection from me as long as the build is happy 
One thing to do out of courtesy is test the build with the “allExtensions” and “communityRelease” profiles active to ensure there are no breakages there either.
2c.
-Justin
On Thu, Nov 18, 2010 at 4:44 AM, <christian.mueller@anonymised.com> wrote:
Last week I invested into a patch for moving from acegi security to
spring security 2.0.6
See:
http://jira.codehaus.org/browse/GEOS-4215
The patch touches a lot of files, a quick check today shows me that I
have to merge some files since they have changed in the repository
since last week.
I want to ask what I should do:
- Create an updated patch file
or
- merge the changes and commit.
Cheers
Christian
This message was sent using IMP, the Internet Messaging Program.
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
On Thu, Nov 18, 2010 at 12:44 PM, <christian.mueller@anonymised.com> wrote:
Last week I invested into a patch for moving from acegi security to
spring security 2.0.6
See:
http://jira.codehaus.org/browse/GEOS-4215
The patch touches a lot of files, a quick check today shows me that I
have to merge some files since they have changed in the repository
since last week.
Sorry I did not have any time to look at it. I'll try to give it a quick
peek this weekend.
Yes, having a patch that is up to date would help.
Cheers
Andrea
-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584962313
fax: +39 0584962313
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-----------------------------------------------------
Hi Andrea, added a new patch file and some comments.
http://jira.codehaus.org/browse/GEOS-4215
The date is encoded in the patch file name.
If anything is ok I want to commit this week end.
Thanks,Christian
Quoting Andrea Aime <andrea.aime@anonymised.com>:
On Thu, Nov 18, 2010 at 12:44 PM, <christian.mueller@anonymised.com> wrote:
Last week I invested into a patch for moving from acegi security to
spring security 2.0.6
See:
http://jira.codehaus.org/browse/GEOS-4215
The patch touches a lot of files, a quick check today shows me that I
have to merge some files since they have changed in the repository
since last week.
Sorry I did not have any time to look at it. I'll try to give it a quick
peek this weekend.
Yes, having a patch that is up to date would help.
Cheers
Andrea
-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584962313
fax: +39 0584962313
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-----------------------------------------------------
----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.
On Fri, Nov 19, 2010 at 5:57 PM, <christian.mueller@anonymised.com> wrote:
Hi Andrea, added a new patch file and some comments.
http://jira.codehaus.org/browse/GEOS-4215
The date is encoded in the patch file name.
If anything is ok I want to commit this week end.
Looked at the patch, works for me, no objections on the commit
Cheers
Andrea
-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584962313
fax: +39 0584962313
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-----------------------------------------------------