Hi,
been looking at HeaderContribution and it seem it goes
a long way in allowing the restyling of the GeoServer
interface to blend it with a larger site.
One thing that I've noticed is missing is changing
the favicon, which requires one line in the header as
well (it's one thing that cannot be customized via
css, as far as my Google searches go):
<link href="favicon.ico" rel="shortcut icon"/>
Do you mind if we add a getFavicon() method to the
contributor? The base page would look for a contributor
provided resource, and if not found, would fall back
on the default one
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.
The only problem I see is that it seems somewhat out of place. HeaderContribution instances should behave in an additive way, there should never ever be an assumption that there is only one. Would multiple favicons on a page make sense?
I wonder if what we need is the idea of a "Theme" extension point. Something that could be set via context parameter (or some other way) that would encapsulate everything (css, javascript, favicon) into a single class.
Anyways, I would be fine with adding favicon to HeaderContribution for now as a temporary measure (unless i am missing something and they should be additive), but I think the Theme idea warrants some thought.
2c.
-Justin
Andrea Aime wrote:
Hi,
been looking at HeaderContribution and it seem it goes
a long way in allowing the restyling of the GeoServer
interface to blend it with a larger site.
One thing that I've noticed is missing is changing
the favicon, which requires one line in the header as
well (it's one thing that cannot be customized via
css, as far as my Google searches go):
<link href="favicon.ico" rel="shortcut icon"/>
Do you mind if we add a getFavicon() method to the
contributor? The base page would look for a contributor
provided resource, and if not found, would fall back
on the default one
Cheers
Andrea
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
Justin Deoliveira ha scritto:
The only problem I see is that it seems somewhat out of place. HeaderContribution instances should behave in an additive way, there should never ever be an assumption that there is only one. Would multiple favicons on a page make sense?
I wonder if what we need is the idea of a "Theme" extension point. Something that could be set via context parameter (or some other way) that would encapsulate everything (css, javascript, favicon) into a single class.
Anyways, I would be fine with adding favicon to HeaderContribution for now as a temporary measure (unless i am missing something and they should be additive), but I think the Theme idea warrants some thought.
You're right, they are not additive.
The issue I see with Theme is that imho it would probably have to go and encompass icons as well, which is a good thing, but a lot of work too.
Also a single central theme would probably break pluggability as icons
are provided by various modules (so the icons providers should probably
be pluggable as well).
The direction is good, but requires some more thinking and more work.
The idea of favicon breaks the current additive nature of the contributions, at the same time it's in line with the fact that part
is header only (the other icons are spread around the code instead,
thought we already have here and there some icons factories).
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.
Justin Deoliveira ha scritto:
The only problem I see is that it seems somewhat out of place. HeaderContribution instances should behave in an additive way, there should never ever be an assumption that there is only one. Would multiple favicons on a page make sense?
I wonder if what we need is the idea of a "Theme" extension point. Something that could be set via context parameter (or some other way) that would encapsulate everything (css, javascript, favicon) into a single class.
Anyways, I would be fine with adding favicon to HeaderContribution for now as a temporary measure (unless i am missing something and they should be additive), but I think the Theme idea warrants some thought.
Here are the two jiras for the short and long term:
http://jira.codehaus.org/browse/GEOS-3558
http://jira.codehaus.org/browse/GEOS-3559
The short term one contains a patch that I'd like to apply in the web
module
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.