[Geoserver-devel] Patch for issue GEOS-3489 (Too many open files left by wicket ui)

GeoServer GeoServer Developer
1

Hi,

I'd say I'm more a user than a developer but I hope it's fine to ask this here:

I'm trying to apply the patch attached to issue GEOS-3489 (Too many
open files left by wicket ui) [1]. I checked out sources from trunk
and noticed that part of its content has been applied to
web/core/src/main/java/org/geoserver/web/GeoServerApplication.java and
web/app/src/test/java/org/geoserver/wicket/test/WicketTestApplication.java,
but not to web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java
(I read about some issues regarding the Apache 2.0 license)

Would it be OK to apply the patch only for
web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java?
I noticed that these differences are not present in the "monster"
patch recently scheduled for trunk. Are there any plans to fully
include this patch in trunk soon?

[1] http://jira.codehaus.org/browse/GEOS-3849

Kind regards,
Abel

2

Abel Martín ha scritto:

Hi,

I'd say I'm more a user than a developer but I hope it's fine to ask this here:

I'm trying to apply the patch attached to issue GEOS-3489 (Too many
open files left by wicket ui) [1]. I checked out sources from trunk
and noticed that part of its content has been applied to
web/core/src/main/java/org/geoserver/web/GeoServerApplication.java and
web/app/src/test/java/org/geoserver/wicket/test/WicketTestApplication.java,
but not to web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java
(I read about some issues regarding the Apache 2.0 license)

I'm confused.... as far as I can see the patch has been applied fully
to both trunk and 2.0.x:

http://svn.codehaus.org/geoserver/trunk/src/web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java
http://svn.codehaus.org/geoserver/branches/2.0.x/src/web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java

Can you be more specific on what is missing?

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

3

On Mon, May 3, 2010 at 11:13 AM, Andrea Aime <aaime@anonymised.com> wrote:

Abel Martín ha scritto:

Hi,

I'd say I'm more a user than a developer but I hope it's fine to ask this
here:

I'm trying to apply the patch attached to issue GEOS-3489 (Too many
open files left by wicket ui) [1]. I checked out sources from trunk
and noticed that part of its content has been applied to
web/core/src/main/java/org/geoserver/web/GeoServerApplication.java and

web/app/src/test/java/org/geoserver/wicket/test/WicketTestApplication.java,
but not to
web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java
(I read about some issues regarding the Apache 2.0 license)

I'm confused.... as far as I can see the patch has been applied fully
to both trunk and 2.0.x:

http://svn.codehaus.org/geoserver/trunk/src/web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java
http://svn.codehaus.org/geoserver/branches/2.0.x/src/web/core/src/main/java/org/geoserver/web/GeoServerResourceStreamLocator.java

Can you be more specific on what is missing?

My mistake. Now I see it's been applied. I got confused because of the
leading Apache 2.0 licensing paragraph. Sorry for the inconvenience.

Regards,
Abel