Hi all (Andrea),
There is a patch attached to this jira issue which fixes the kvp parser conflict problem. If someone could review that would be great. Thanks.
http://jira.codehaus.org/browse/GEOS-1730
-Justin
--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com
Justin Deoliveira ha scritto:
Hi all (Andrea),
There is a patch attached to this jira issue which fixes the kvp parser conflict problem. If someone could review that would be great. Thanks.
Patch looks good, only one minor thing. That commented code that you
removed in a patch is actually an optimization I wanted to submit
you and that allows to bail out of the loop as soon as the value
has been parsed. On the same topic, I guess it would be interesting
to merge the two loops in your patch so that the most likely
filter to discard a kvp parser executes first
(if (key.equalsIgnoreCase(parser.getKey())), and then the service,
version and request ones are executed.
Hmm... ok, the point of view of a performance maniac if you want...
commit the version you like best
Cheers
Andrea