[Geoserver-devel] Patch for trunk "ready", but two problems

Hi,
the patch for trunk is ready, as promised it's a monster.
If you want to have a look at it or just have a trunk
that builds it's attached to this mail (gzipped, uncompressed
it's 592K)

There are two problems though, one big, one minor.

The big one is that I had to disable solid the WCS tests.
Why?
Well, because the image-mosaic in gt2 is out of the build
and the one we have in the repo will throw exception about
non existing methods so... it's unusable.

Long story short, to get WCS back in business we have
to fix the build in imagemosaic and put it back in the
build too. I've tried, but it does not build due to
missing dependencies on trunk (postgis ng and friends).

The second issue is that the tests of app-schema do not
work. No, wait, I did not touch them, promise.
They are breaking because the test data is coming out
of the classpath (jar: URI) instead of the file system.
Not sure why, but I noticed there is probably one
commit that has landed on 2.0.x and was not ported
over to trunk:

------------------------------------------------------------------------
r14291 | riniangreani | 2010-04-29 12:04:47 +0200 (gio, 29 apr 2010) | 1 line

I see no equivalent commit on trunk.

So... PSC, what do we do? Shall I commit as is?
Does anybody else want to check, try a different approach maybe?

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

(attachments)

simple.patch.gz (74.4 KB)

I would say go ahead, commit and disable WCS with the agreement that
you will give us some help with pushing back to the build the
imagemosaic on trunk and therefore the WCS module. Deal?

Simone.
-------------------------------------------------------
Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy

phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/simonegiannecchini
http://twitter.com/simogeo

-------------------------------------------------------

On Fri, Apr 30, 2010 at 7:50 PM, Andrea Aime <aaime@anonymised.com> wrote:

Hi,
the patch for trunk is ready, as promised it's a monster.
If you want to have a look at it or just have a trunk
that builds it's attached to this mail (gzipped, uncompressed
it's 592K)

There are two problems though, one big, one minor.

The big one is that I had to disable solid the WCS tests.
Why?
Well, because the image-mosaic in gt2 is out of the build
and the one we have in the repo will throw exception about
non existing methods so... it's unusable.

Long story short, to get WCS back in business we have
to fix the build in imagemosaic and put it back in the
build too. I've tried, but it does not build due to
missing dependencies on trunk (postgis ng and friends).

The second issue is that the tests of app-schema do not
work. No, wait, I did not touch them, promise.
They are breaking because the test data is coming out
of the classpath (jar: URI) instead of the file system.
Not sure why, but I noticed there is probably one
commit that has landed on 2.0.x and was not ported
over to trunk:

------------------------------------------------------------------------
r14291 | riniangreani | 2010-04-29 12:04:47 +0200 (gio, 29 apr 2010) | 1
line

I see no equivalent commit on trunk.

So... PSC, what do we do? Shall I commit as is?
Does anybody else want to check, try a different approach maybe?

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------

_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Simone Giannecchini ha scritto:

I would say go ahead, commit and disable WCS with the agreement that
you will give us some help with pushing back to the build the
imagemosaic on trunk and therefore the WCS module. Deal?

I'll definitely try to help, and hopefully it's just a matter of fixing
the pom (it's evident that some dependencies are missing).
Next time, it's better to keep the "stable" modules into the build :-p

From the plugin/pom.xml svn log the module has been out of the build for
almost 6 months:

------------------------------------------------------------------
r34576 | simonegiannecchini | 2009-11-30 19:59:28 +0100 (lun, 30 nov 2009) | 1 line

moved imagemosaic out of the build for hardcore experimenting
------------------------------------------------------------------

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

The second issue is that the tests of app-schema do not
work. No, wait, I did not touch them, promise.
They are breaking because the test data is coming out
of the classpath (jar: URI) instead of the file system.
Not sure why, but I noticed there is probably one
commit that has landed on 2.0.x and was not ported
over to trunk:

------------------------------------------------------------------------
r14291 | riniangreani | 2010-04-29 12:04:47 +0200 (gio, 29 apr 2010) | 1
line

I see no equivalent commit on trunk.

Ah, forget about that, I was missing the external that has the
test data, added that and app-scheme-tests built fine
Nice, down to one problem

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Nice work andrea!
Jody
On 01/05/2010, at 5:35 AM, Andrea Aime wrote:

The second issue is that the tests of app-schema do not
work. No, wait, I did not touch them, promise.
They are breaking because the test data is coming out
of the classpath (jar: URI) instead of the file system.
Not sure why, but I noticed there is probably one
commit that has landed on 2.0.x and was not ported
over to trunk:

------------------------------------------------------------------------
r14291 | riniangreani | 2010-04-29 12:04:47 +0200 (gio, 29 apr 2010) | 1
line

I see no equivalent commit on trunk.

Ah, forget about that, I was missing the external that has the
test data, added that and app-scheme-tests built fine
Nice, down to one problem

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Andrea Aime ha scritto:

Simone Giannecchini ha scritto:

I would say go ahead, commit and disable WCS with the agreement that
you will give us some help with pushing back to the build the
imagemosaic on trunk and therefore the WCS module. Deal?

I'll definitely try to help, and hopefully it's just a matter of fixing
the pom (it's evident that some dependencies are missing).

Hi Simone,
just put image mosaic back in the gt-trunk build.
I went ahead and committed since it was really just a matter of adding
a test dependency and fixing a few imports. No big deal

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

Thanks Andrea,
I was expecting something like that since I had one of our guys fixing
the ImageMosaic build and tests on trunk after the shapefile patch, we
probably just forgot (we as in me) to push it back to the build.

Ciao,
Simone.
-------------------------------------------------------
Ing. Simone Giannecchini
GeoSolutions S.A.S.
Founder - Software Engineer
Via Carignoni 51
55041 Camaiore (LU)
Italy

phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/simonegiannecchini
http://twitter.com/simogeo

-------------------------------------------------------

On Sat, May 1, 2010 at 10:46 AM, Andrea Aime <aaime@anonymised.com> wrote:

Andrea Aime ha scritto:

Simone Giannecchini ha scritto:

I would say go ahead, commit and disable WCS with the agreement that
you will give us some help with pushing back to the build the
imagemosaic on trunk and therefore the WCS module. Deal?

I'll definitely try to help, and hopefully it's just a matter of fixing
the pom (it's evident that some dependencies are missing).

Hi Simone,
just put image mosaic back in the gt-trunk build.
I went ahead and committed since it was really just a matter of adding
a test dependency and fixing a few imports. No big deal

Cheers
Andrea

--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel