Hi all,
I would like to start backporting the fix for http://jira.codehaus.org/browse/GEOS-5587 (already merged on master) to the 2.2.x branch.
In the meantime I created a new jira for the backport (http://jira.codehaus.org/browse/GEOS-5598).
The backport should cause no issues, since GetLegendGraphic code is almost identical in master and 2.2.x branches and the bugfix only applies on a use case that was previously throwing an exception.
Opinions?
Thanks.
Mauro Bartolomeoli
–
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
On Thu, Jan 24, 2013 at 10:36 AM, Mauro Bartolomeoli
<mauro.bartolomeoli@anonymised.com> wrote:
Hi all,
I would like to start backporting the fix for
http://jira.codehaus.org/browse/GEOS-5587 (already merged on master) to the
2.2.x branch.
In the meantime I created a new jira for the backport
(http://jira.codehaus.org/browse/GEOS-5598).
The backport should cause no issues, since GetLegendGraphic code is almost
identical in master and 2.2.x branches and the bugfix only applies on a use
case that was previously throwing an exception.
Opinions?
It seems to me it's good to go. Backporting bug fixes normally
requires no public discussion,
unless the bug fix itself demands for deep changes in some core module.
It's when we backport a new feature that discussion/voting is required
The thing about layer groups is sort of a middle ground, layer groups
are declared
in the caps document as a single layer, so they have to be supported
by GetLegendGraphics,
otherwise the WMS can be considered buggy... at the same time, it's
something that
we did not have before.
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
The thing about layer groups is sort of a middle ground, layer groups
are declared
in the caps document as a single layer, so they have to be supported
by GetLegendGraphics,
otherwise the WMS can be considered buggy... at the same time, it's
something that
we did not have before.
Sure, but think about the way a normal user can react about it: currently
GeoServer, if asked for GetLegendGraphic on a layer group gives the
following response:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE ServiceExceptionReport SYSTEM "
http://localhost:8090/geoserver/schemas/wms/1.1.1/WMS_exception_1_1_1.dtd">
<ServiceExceptionReport version="1.1.1" >
<ServiceException>
spearfish layer does not exist.
</ServiceException>
</ServiceExceptionReport>
But the spearfish layer DOES exit, I can see it in the Layer Preview list,
it is just not supported, by now.
As a user, I would surely signal this as a bug: I asked for a layer legend,
the layer exists, GeoServer told me this is not true: who is lying here 
?
Just my opinion.
Thanks.
Mauro Bartolomeoli
--
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Thu, Jan 24, 2013 at 11:14 AM, Mauro Bartolomeoli
<mauro.bartolomeoli@anonymised.com> wrote:
Sure, but think about the way a normal user can react about it: currently
GeoServer, if asked for GetLegendGraphic on a layer group gives the
following response:
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE ServiceExceptionReport SYSTEM
"http://localhost:8090/geoserver/schemas/wms/1.1.1/WMS_exception_1_1_1.dtd">
<ServiceExceptionReport version="1.1.1" >
<ServiceException>
spearfish layer does not exist.
</ServiceException>
</ServiceExceptionReport>
But the spearfish layer DOES exit, I can see it in the Layer Preview list,
it is just not supported, by now.
As a user, I would surely signal this as a bug: I asked for a layer legend,
the layer exists, GeoServer told me this is not true: who is lying here
?
I agree with your reasoning, just asked you to share this one on the ml because
I wanted to make sure there was an agreement on it
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------