[Geoserver-devel] porting dynamic icons to new kml module

GeoServer GeoServer Developer
1

Hi all,

As discussed on the previous thread I have taken a crack at porting the kml dynamic icon work done by kevin and david to the new kml module. The entire work (including the original implementation) can be found in this pull request.

https://github.com/geoserver/geoserver/pull/261

I changed one aspect of the original work, the service used to render icons. It didn’t seem to fit that the service was part of restconfig and secured by default. So i moved it out into a separate servlet/controller exposed through the kml module itself. The change for that is here:

https://github.com/jdeolive/geoserver/commit/1bbaf2d1be4454e50ec6a9f69299331c9c6bb212

Here is the specific changeset for the porting to the new kml module.

https://github.com/jdeolive/geoserver/commit/6785ac7c6ad14ea14aefd94079e939541b9d5f47

All tests in the new module are passing.

-Justin

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

2

On Wed, Jul 3, 2013 at 4:01 AM, Justin Deoliveira <jdeolive@anonymised.com>wrote:

Hi all,

As discussed on the previous thread I have taken a crack at porting the
kml dynamic icon work done by kevin and david to the new kml module. The
entire work (including the original implementation) can be found in this
pull request.

  https://github.com/geoserver/geoserver/pull/261

I changed one aspect of the original work, the service used to render
icons. It didn't seem to fit that the service was part of restconfig and
secured by default. So i moved it out into a separate servlet/controller
exposed through the kml module itself. The change for that is here:

https://github.com/jdeolive/geoserver/commit/1bbaf2d1be4454e50ec6a9f69299331c9c6bb212

Here is the specific changeset for the porting to the new kml module.

https://github.com/jdeolive/geoserver/commit/6785ac7c6ad14ea14aefd94079e939541b9d5f47

All tests in the new module are passing.

Had a look, looks good, merged it.

Just one note, it seems the stroke of the marks is not quite reproduced
properly in Google Earth.
Compare this:

!tiger-ny.png|354x512

With the GE output:

!ge.jpeg|378x493

The icon is yellow, but the red border is not there

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

3

Thanks for the prompt review and merge Andrea, indeed it seems some of the original styling is dropped when rendering the icon.

I am going to pull in David, who i believe is the original author of the code.

@David: is this done intentionally? Does this change make sense?

https://gist.github.com/jdeolive/5919466

(attachments)

tiger-ny.png
ge.jpeg

···

On Wed, Jul 3, 2013 at 3:16 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, Jul 3, 2013 at 4:01 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Hi all,

As discussed on the previous thread I have taken a crack at porting the kml dynamic icon work done by kevin and david to the new kml module. The entire work (including the original implementation) can be found in this pull request.

https://github.com/geoserver/geoserver/pull/261

I changed one aspect of the original work, the service used to render icons. It didn’t seem to fit that the service was part of restconfig and secured by default. So i moved it out into a separate servlet/controller exposed through the kml module itself. The change for that is here:

https://github.com/jdeolive/geoserver/commit/1bbaf2d1be4454e50ec6a9f69299331c9c6bb212

Here is the specific changeset for the porting to the new kml module.

https://github.com/jdeolive/geoserver/commit/6785ac7c6ad14ea14aefd94079e939541b9d5f47

All tests in the new module are passing.

Had a look, looks good, merged it.

Just one note, it seems the stroke of the marks is not quite reproduced properly in Google Earth.
Compare this:

Inline image 1

With the GE output:

Inline image 2

The icon is yellow, but the red border is not there

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

4

Yes, this seems to be an error; if values from the query are not being injected then we should take the ones from the style, not null.

(attachments)

tiger-ny.png
ge.jpeg

···

On Wed, Jul 3, 2013 at 11:37 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Thanks for the prompt review and merge Andrea, indeed it seems some of the original styling is dropped when rendering the icon.

I am going to pull in David, who i believe is the original author of the code.

@David: is this done intentionally? Does this change make sense?

https://gist.github.com/jdeolive/5919466

On Wed, Jul 3, 2013 at 3:16 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Wed, Jul 3, 2013 at 4:01 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Hi all,

As discussed on the previous thread I have taken a crack at porting the kml dynamic icon work done by kevin and david to the new kml module. The entire work (including the original implementation) can be found in this pull request.

https://github.com/geoserver/geoserver/pull/261

I changed one aspect of the original work, the service used to render icons. It didn’t seem to fit that the service was part of restconfig and secured by default. So i moved it out into a separate servlet/controller exposed through the kml module itself. The change for that is here:

https://github.com/jdeolive/geoserver/commit/1bbaf2d1be4454e50ec6a9f69299331c9c6bb212

Here is the specific changeset for the porting to the new kml module.

https://github.com/jdeolive/geoserver/commit/6785ac7c6ad14ea14aefd94079e939541b9d5f47

All tests in the new module are passing.

Had a look, looks good, merged it.

Just one note, it seems the stroke of the marks is not quite reproduced properly in Google Earth.
Compare this:

Inline image 1

With the GE output:

Inline image 2

The icon is yellow, but the red border is not there

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

5

Awesome, thanks for confirming David. I’ll push that change in with a test momentarily.

(attachments)

ge.jpeg
tiger-ny.png

···

On Wed, Jul 3, 2013 at 11:06 AM, David Winslow <dwinslow@anonymised.com> wrote:

Yes, this seems to be an error; if values from the query are not being injected then we should take the ones from the style, not null.

–
David Winslow
OpenGeo - http://opengeo.org/

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

On Wed, Jul 3, 2013 at 11:37 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Thanks for the prompt review and merge Andrea, indeed it seems some of the original styling is dropped when rendering the icon.

I am going to pull in David, who i believe is the original author of the code.

@David: is this done intentionally? Does this change make sense?

https://gist.github.com/jdeolive/5919466

On Wed, Jul 3, 2013 at 3:16 AM, Andrea Aime <andrea.aime@anonymised.com1268…> wrote:

On Wed, Jul 3, 2013 at 4:01 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Hi all,

As discussed on the previous thread I have taken a crack at porting the kml dynamic icon work done by kevin and david to the new kml module. The entire work (including the original implementation) can be found in this pull request.

https://github.com/geoserver/geoserver/pull/261

I changed one aspect of the original work, the service used to render icons. It didn’t seem to fit that the service was part of restconfig and secured by default. So i moved it out into a separate servlet/controller exposed through the kml module itself. The change for that is here:

https://github.com/jdeolive/geoserver/commit/1bbaf2d1be4454e50ec6a9f69299331c9c6bb212

Here is the specific changeset for the porting to the new kml module.

https://github.com/jdeolive/geoserver/commit/6785ac7c6ad14ea14aefd94079e939541b9d5f47

All tests in the new module are passing.

Had a look, looks good, merged it.

Just one note, it seems the stroke of the marks is not quite reproduced properly in Google Earth.
Compare this:

Inline image 1

With the GE output:

Inline image 2

The icon is yellow, but the red border is not there

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it