[Geoserver-devel] PR Questions

GeoServer GeoServer Developer
1

Hi all,

I put up a PR for geojson encoding for list and map types.

https://github.com/geoserver/geoserver/pull/1523

Wanna make sure I get it all done right. My company is working on the contributor agreement.

Should I make a separate PR for master (assuming it's worth of merge)?

This is my first attempt at a commit. Lemme know what I did wrong!

Thanks,

Andrew

2

Hi Andrew,

CCRi should have a little bit of the paperwork on hand. In terms of committing, I think the first PR might have to go against master and then we'd have to ask for the backport.

Cheers,

Jim

On 03/02/2016 01:39 PM, Andrew Hulbert wrote:

Hi all,

I put up a PR for geojson encoding for list and map types.

https://github.com/geoserver/geoserver/pull/1523

Wanna make sure I get it all done right. My company is working on the
contributor agreement.

Should I make a separate PR for master (assuming it's worth of merge)?

This is my first attempt at a commit. Lemme know what I did wrong!

Thanks,

Andrew

------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

3

Hi Andrew,
I did not have time to look at the pull request (and might not have for a few days),
but there is a contribution guide here with expectations for the contributions
that might be useful to self-check the pull request:

https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md

There is also a non official, non binding pull request review guide that might
be of interest:
https://github.com/geoserver/geoserver/wiki/Pull-request-review-guide

Cheers
Andrea

···

On Wed, Mar 2, 2016 at 7:39 PM, Andrew Hulbert <ahulbert@anonymised.com> wrote:

Hi all,

I put up a PR for geojson encoding for list and map types.

https://github.com/geoserver/geoserver/pull/1523

Wanna make sure I get it all done right. My company is working on the
contributor agreement.

Should I make a separate PR for master (assuming it’s worth of merge)?

This is my first attempt at a commit. Lemme know what I did wrong!

Thanks,

Andrew

Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

4

Andrea (and others),

Sounds good…thanks for taking the time to look.

I also put up a request for master.

Our counsel (Heather) sent over a commit agreement to info@anonymised.com

-Andrew

···

On 03/02/2016 03:25 PM, Andrea Aime wrote:

Hi Andrew,
I did not have time to look at the pull request (and might not have for a few days),
but there is a contribution guide here with expectations for the contributions
that might be useful to self-check the pull request:

https://github.com/geoserver/geoserver/blob/master/CONTRIBUTING.md

There is also a non official, non binding pull request review guide that might
be of interest:
https://github.com/geoserver/geoserver/wiki/Pull-request-review-guide

Cheers
Andrea

On Wed, Mar 2, 2016 at 7:39 PM, Andrew Hulbert <ahulbert@anonymised.com> wrote:

Hi all,

I put up a PR for geojson encoding for list and map types.

https://github.com/geoserver/geoserver/pull/1523

Wanna make sure I get it all done right. My company is working on the
contributor agreement.

Should I make a separate PR for master (assuming it’s worth of merge)?

This is my first attempt at a commit. Lemme know what I did wrong!

Thanks,

Andrew

Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.