Hi,
here is the pull request:
https://github.com/geoserver/geoserver/pull/415
Most of the changes have been performed automatically with the attached
java program (which yes, has assumptions, but ensure I’m not going to reformat
files and/or change newlines in them).
However, I had to manually change the packaging instructions for the extensions
and community modules… tried to pay as much attention as I could, but
this is quite error prone.
How do you suggest we test it? Extensions maintainers review?
Organize some manual tests?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
(attachments)
PrefixUpgrader.java (2.73 KB)
How about building a full release before and after, and checking that the release artifacts before and after have (about) the same size and each contain the same number of files? This would be a basic sanity check. If I have time, I might try this.
The app-schema extension contains only tests in GeoServer-land (only gt-* and dependency jars) and will be unaffected by this change.
Kind regards,
Ben.
On 30/11/13 23:09, Andrea Aime wrote:
Hi,
here is the pull request:
https://github.com/geoserver/geoserver/pull/415
Most of the changes have been performed automatically with the attached
java program (which yes, has assumptions, but ensure I'm not going to
reformat
files and/or change newlines in them).
However, I had to manually change the packaging instructions for the
extensions
and community modules... tried to pay as much attention as I could, but
this is quite error prone.
How do you suggest we test it? Extensions maintainers review?
Organize some manual tests?
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
Andrea,
I built a release before and then after your patch. All plugin zip files have similar sizes and "unzip -l" produces the same number of lines after your patch is applied. I had a quick look through all the "unzip -l" output and the names seem OK. So basic sanity checks hold.
Kind regards,
Ben.
# size in bytes: plugin before after difference
$ for f in release.old/*-plugin.zip; do ff=`basename $f`; s1=`ls -l release.old/$ff | awk '{print $5}'`; s2=`ls -l release.new/$ff | awk '{print $5}'`; echo $ff $s1 $s2 $((s2-s1)); done
geoserver-2.5-SNAPSHOT-app-schema-plugin.zip 307814 307814 0
geoserver-2.5-SNAPSHOT-arcsde-plugin.zip 3606018 3606042 24
geoserver-2.5-SNAPSHOT-cas-plugin.zip 132086 132101 15
geoserver-2.5-SNAPSHOT-charts-plugin.zip 1586427 1586427 0
geoserver-2.5-SNAPSHOT-control-flow-plugin.zip 21995 22005 10
geoserver-2.5-SNAPSHOT-css-plugin.zip 7070942 7070952 10
geoserver-2.5-SNAPSHOT-csw-plugin.zip 951489 951590 101
geoserver-2.5-SNAPSHOT-db2-plugin.zip 47211 47211 0
geoserver-2.5-SNAPSHOT-excel-plugin.zip 8865045 8865061 16
geoserver-2.5-SNAPSHOT-feature-pregeneralized-plugin.zip 42770 42773 3
geoserver-2.5-SNAPSHOT-gdal-plugin.zip 322602 322613 11
geoserver-2.5-SNAPSHOT-geosearch-plugin.zip 24192 24218 26
geoserver-2.5-SNAPSHOT-h2-plugin.zip 1268480 1268487 7
geoserver-2.5-SNAPSHOT-imagemap-plugin.zip 41007 41011 4
geoserver-2.5-SNAPSHOT-imagemosaic-jdbc-plugin.zip 107097 107097 0
geoserver-2.5-SNAPSHOT-inspire-plugin.zip 30444 30467 23
geoserver-2.5-SNAPSHOT-jp2k-plugin.zip 301507 301507 0
geoserver-2.5-SNAPSHOT-monitor-hibernate-plugin.zip 3934652 3934665 13
geoserver-2.5-SNAPSHOT-monitor-plugin.zip 8613056 8613066 10
geoserver-2.5-SNAPSHOT-mysql-plugin.zip 773950 773950 0
geoserver-2.5-SNAPSHOT-ogr-plugin.zip 16651 16670 19
geoserver-2.5-SNAPSHOT-oracle-plugin.zip 1537198 1537198 0
geoserver-2.5-SNAPSHOT-pyramid-plugin.zip 23176 23176 0
geoserver-2.5-SNAPSHOT-querylayer-plugin.zip 10884 10878 -6
geoserver-2.5-SNAPSHOT-sqlserver-plugin.zip 27611 27611 0
geoserver-2.5-SNAPSHOT-teradata-plugin.zip 41596 41596 0
geoserver-2.5-SNAPSHOT-wps-plugin.zip 1423378 1423272 -106
geoserver-2.5-SNAPSHOT-xslt-plugin.zip 33283 33281 -2
# "unzip -l" lines: plugin before after
$ for f in release.old/*-plugin.zip; do ff=`basename $f`; echo $ff `unzip -l release.old/$ff | wc -l` `unzip -l release.new/$ff | wc -l`; done
geoserver-2.5-SNAPSHOT-app-schema-plugin.zip 80 80
geoserver-2.5-SNAPSHOT-arcsde-plugin.zip 13 13
geoserver-2.5-SNAPSHOT-cas-plugin.zip 10 10
geoserver-2.5-SNAPSHOT-charts-plugin.zip 9 9
geoserver-2.5-SNAPSHOT-control-flow-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-css-plugin.zip 9 9
geoserver-2.5-SNAPSHOT-csw-plugin.zip 17 17
geoserver-2.5-SNAPSHOT-db2-plugin.zip 8 8
geoserver-2.5-SNAPSHOT-excel-plugin.zip 14 14
geoserver-2.5-SNAPSHOT-feature-pregeneralized-plugin.zip 7 7
geoserver-2.5-SNAPSHOT-gdal-plugin.zip 26 26
geoserver-2.5-SNAPSHOT-geosearch-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-h2-plugin.zip 12 12
geoserver-2.5-SNAPSHOT-imagemap-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-imagemosaic-jdbc-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-inspire-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-jp2k-plugin.zip 11 11
geoserver-2.5-SNAPSHOT-monitor-hibernate-plugin.zip 19 19
geoserver-2.5-SNAPSHOT-monitor-plugin.zip 13 13
geoserver-2.5-SNAPSHOT-mysql-plugin.zip 9 9
geoserver-2.5-SNAPSHOT-ogr-plugin.zip 8 8
geoserver-2.5-SNAPSHOT-oracle-plugin.zip 10 10
geoserver-2.5-SNAPSHOT-pyramid-plugin.zip 8 8
geoserver-2.5-SNAPSHOT-querylayer-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-sqlserver-plugin.zip 6 6
geoserver-2.5-SNAPSHOT-teradata-plugin.zip 7 7
geoserver-2.5-SNAPSHOT-wps-plugin.zip 24 24
geoserver-2.5-SNAPSHOT-xslt-plugin.zip 6 6
On 02/12/13 10:36, Ben Caradoc-Davies wrote:
How about building a full release before and after, and checking that
the release artifacts before and after have (about) the same size and
each contain the same number of files? This would be a basic sanity
check. If I have time, I might try this.
The app-schema extension contains only tests in GeoServer-land (only
gt-* and dependency jars) and will be unaffected by this change.
Kind regards,
Ben.
On 30/11/13 23:09, Andrea Aime wrote:
Hi,
here is the pull request:
https://github.com/geoserver/geoserver/pull/415
Most of the changes have been performed automatically with the attached
java program (which yes, has assumptions, but ensure I'm not going to
reformat
files and/or change newlines in them).
However, I had to manually change the packaging instructions for the
extensions
and community modules... tried to pay as much attention as I could, but
this is quite error prone.
How do you suggest we test it? Extensions maintainers review?
Organize some manual tests?
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
On Mon, Dec 2, 2013 at 6:26 AM, Ben Caradoc-Davies <
Ben.Caradoc-Davies@anonymised.com> wrote:
Andrea,
I built a release before and then after your patch. All plugin zip files
have similar sizes and "unzip -l" produces the same number of lines after
your patch is applied. I had a quick look through all the "unzip -l" output
and the names seem OK. So basic sanity checks hold.
Hi Ben,
thanks a lot for the checks and the simple but effective suggestion.
I've repeated the same checks in the community modules and found a few
issues in my original patch
related to modules being build nightly, which I've hopefully fixed.
Patch merged (on trunk only)
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------