[Geoserver-devel] Proposal: New ResourcePool extension point

Hi all,

I’m looking to propose a new extension point in ResourcePool. The long and short of it is, the ResourcePool attempts to instantiate GridCoverageReaders and ImageInputStreams by analyzing the input object passed to it. ImageInputStreams in particular advertise an “inputClass”, which is used to match the class type of the input object.

The ResourcePool currently makes a single attempt to determine if the input object is a String that represents a File URL. If so, it creates a new File object and uses that as the input. There is currently no way to define custom input objects that may align with readers that require specialized input classes.

I’ve created a draft proposal on Gist and was hoping to start a conversation before formally making the proposal. Any feedback would be appreciated.

https://gist.github.com/joshfix/d5458221192fe6f678f37e5a225954cd

···

Josh Fix

Systems Architect
Planet Federal

josh@anonymised.com5476…

+1 321.444.0412

Hi Josh,
not much to add, looks good to me

Cheers
Andrea

···

Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

Thanks Andrea. Proposal is up (thanks Torben):

https://github.com/geoserver/geoserver/wiki/GSIP-188

···

Josh Fix

Systems Architect
Planet Federal

josh@anonymised.com

+1 321.444.0412

Torben actually added this page as I don’t seem to have the proper permissions to add/edit. I’m refining a few things and it would be nice to be able to edit this page. Is there any way I could get minimal access to make edits to the proposal?

Thanks!

···

Josh Fix

Systems Architect
Planet Federal

josh@anonymised.com

+1 321.444.0412

I created a new team-geoserver-wiki and added you to it Josh, permissions are set to triage for now- please check if that is enough to allow wiki access?
We are not that comfortable making our wiki publicly editable, and just completed an activity removing inactive committers.

···


Jody Garnett

Unfortunately that didn’t seem to do it, but I totally understand that you don’t want public access :slight_smile:

···

Josh Fix

Systems Architect
Planet Federal

josh@anonymised.com

+1 321.444.0412

Thanks for testing, I will increase that groups permission levels a notch (it will give us an easy way to manage the difference between core contributors and those with access for wiki or community modules).

···


Jody Garnett

That did it – I have the new page and edit buttons now. Thanks!

···

Josh Fix

Systems Architect
Planet Federal

josh@anonymised.com

+1 321.444.0412

Haven’t seen any activity on this change proposal. I went ahead and posted a PR: https://github.com/geoserver/geoserver/pull/4157

I’m available to answer any questions or concerns if anybody has them.

Thank you!

···

Josh Fix

Systems Architect
Planet Federal

josh@anonymised.com

+1 321.444.0412

Let me start an email asking folks to vote :slight_smile:

I have added my own +1.

We recently changed our policy around here so votes would not be stuck for weeks, but part of that involves asking.

···


Jody Garnett