Hey all,
Following up on the discussions over the last week (or two) I've finished
adding functional support for the configured proxyUrl working with the new
dispatching system, but adding a 'baseUrl' field to all request objects.
The patch for the code against a current revision is here:
http://maps.massgis.state.ma.us/~sfarber/proxyUrlSupport.patch
All tests are passing. I had to fix some tests, as there were some calls to
response.write() which didn't actually pass in the request object, and which
needed to. But other than that there were no broken tests.
The other question was whether my editing the ecore files with eclipse 3.3
(when they're run with the 3.2 runtime in geoserver) would cause any
problems. So far I haven't had any problems at all, and I've run the
test-suite from maven, as well as building a geoserver war-file and running
it on a completely different server. Everything works just fine, so I'm
pretty sure there shouldn't be any problems from that angle...but it's worth
looking at the diffs just to make sure they make sense.
Justin, would you mind taking a look at this, just to have another set of
eyes on it? Also you're pretty familiar with the Dispatcher stuff, so the
(minor) changes should be obvious to you.
Feedback from anyone else would be appreciated too.
I plan to build a fresh geoserver war and run our own functional test-suite
here in-house, and if everything passes, hopefully commit this tomorrow or
tuesday (Monday is a US holiday). Let me know if it breaks anything for
anyone, and I'll be sure and hold up.
thanks,
--saul
--
View this message in context: http://www.nabble.com/ProxyURL-support-in-geoserver-trunk-tf4356881.html#a12415989
Sent from the GeoServer - Dev mailing list archive at Nabble.com.