Hi,
the freemarker templates editing via REST is ready for backport, has pull requests
in line.
Its position regarding to the guidelines for new feature backports is borderline,
it’s indeed the implementation of a set of extension points without significant
changes to core, but it’s also new API for the users.
(see the “committing guidelines” section http://geoserver.org/display/GEOS/GSIP+77±+Time+boxed+release+model)
Hi,
the freemarker templates editing via REST is ready for backport, has pull requests
in line.
Its position regarding to the guidelines for new feature backports is borderline,
it’s indeed the implementation of a set of extension points without significant
changes to core, but it’s also new API for the users.
(see the “committing guidelines” section http://geoserver.org/display/GEOS/GSIP+77±+Time+boxed+release+model)
Keep yourself connected to Go Parallel:
INSIGHTS What’s next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
On Wed, Nov 28, 2012 at 12:28 PM, Christian Mueller <mcrmcr21@anonymised.com> wrote:
I am not involved in the topic, my vote is
+0
2012/11/28 Andrea Aime <andrea.aime@anonymised.com>
Hi,
the freemarker templates editing via REST is ready for backport, has pull
requests
in line.
Its position regarding to the guidelines for new feature backports is
borderline,
it's indeed the implementation of a set of extension points without
significant
changes to core, but it's also new API for the users.
(see the "committing guidelines" section http://geoserver.org/display/GEOS/GSIP+77+-+Time+boxed+release+model)
There has been significant discussion on the devel mailing list on the
subject before the work
got committed on trunk:
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
INSIGHTS What's next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geoserver-devel
0 - when i reviewed the work i never did it in the context of the stable branch so i would need time (probably not until the weekend) to do another review.
I do have questions about whether this work is appropriate for the stable branch though. I also believe that in the past purely additive changed have been rejected with arguments that they went against stability.
Anyways, this isn’t a negative vote, just a neutral one.
Hi,
the freemarker templates editing via REST is ready for backport, has pull
requests
in line.
Its position regarding to the guidelines for new feature backports is
borderline,
it’s indeed the implementation of a set of extension points without
significant
changes to core, but it’s also new API for the users.
(see the “committing guidelines” section http://geoserver.org/display/GEOS/GSIP+77±+Time+boxed+release+model)
There has been significant discussion on the devel mailing list on the
subject before the work
got committed on trunk:
Keep yourself connected to Go Parallel:
INSIGHTS What’s next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
Keep yourself connected to Go Parallel:
INSIGHTS What’s next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
Keep yourself connected to Go Parallel:
INSIGHTS What’s next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
I do have questions about whether this work is appropriate for the stable branch though. I also believe that in the past purely additive changed have been rejected with arguments that they went against stability.
Hum… uh? What work has been rejected on stable while being purely additive?
On Wed, Nov 28, 2012 at 10:21 AM, Andrea Aime
<andrea.aime@anonymised.com>wrote:
On Wed, Nov 28, 2012 at 5:05 PM, Justin Deoliveira <jdeolive@anonymised.com>wrote:
I do have questions about whether this work is appropriate for the stable
branch though. I also believe that in the past purely additive changed have
been rejected with arguments that they went against stability.
Hum... uh? What work has been rejected on stable while being purely
additive?
I don't want to start another holy war on this but iirc the catalog api
changes for GSIP 69 were additive.
Stable is open for extension with new features. Note that when we add a new API (or catalog feature) to stable, we are committing to keep it in the long term. Are you satisfied that the new API (both REST and catalog format) has been used enough to be confident that is is complete and stable? If so, backporting to stable is quite acceptable.
Kind regards,
Ben.
On 28/11/12 18:50, Andrea Aime wrote:
Hi,
the freemarker templates editing via REST is ready for backport, has
pull requests
in line.
Its position regarding to the guidelines for new feature backports is
borderline,
it's indeed the implementation of a set of extension points without
significant
changes to core, but it's also new API for the users.
(see the "committing guidelines" section http://geoserver.org/display/GEOS/GSIP+77+-+Time+boxed+release+model)
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
+1 (and thanks for checking, at the very least it gives us a chance to notice what is going on release wise)
–
Jody Garnett
On Wednesday, 28 November 2012 at 8:50 PM, Andrea Aime wrote:
Hi,
the freemarker templates editing via REST is ready for backport, has pull requests
in line.
Its position regarding to the guidelines for new feature backports is borderline,
it’s indeed the implementation of a set of extension points without significant
changes to core, but it’s also new API for the users.
(see the “committing guidelines” section http://geoserver.org/display/GEOS/GSIP+77±+Time+boxed+release+model)
Keep yourself connected to Go Parallel:
INSIGHTS What’s next for parallel hardware, programming and related areas?
Interviews and blogs by thought leaders keep you ahead of the curve. http://goparallel.sourceforge.net
Stable is open for extension with new features. Note that when we add a new API (or catalog feature) to stable, we are committing to keep it in the long term. Are you satisfied that the new API (both REST and catalog format) has been used enough to be confident that is is complete and stable? If so, backporting to stable is quite acceptable.
The work extends the REST api, but not internal APIs. The API has been discussed with the community at length
in order to make it viable long term, so I don’t expect further changes to it
Stable is open for extension with new features. Note that when we add a new API (or catalog feature) to stable, we are committing to keep it in the long term. Are you satisfied that the new API (both REST and catalog format) has been used enough to be confident that is is complete and stable? If so, backporting to stable is quite acceptable.
The work extends the REST api, but not internal APIs. The API has been discussed with the community at length
in order to make it viable long term, so I don’t expect further changes to it
Keep yourself connected to Go Parallel:
VERIFY Test and improve your parallel project with help from experts
and peers. http://goparallel.sourceforge.net
The work extends the REST api, but not internal APIs. The API has been
discussed with the community at length
in order to make it viable long term, so I don't expect further changes
to it
We also need to consider the workspace filesystem layout for the templates to be stable so it survives dot-point upgrades (I think you modified this a bit in the drafts?). If the workspace filesystem layout stable, then the backport should be fine.
(I know you know this; I just wanted to discuss it on the list as your work is IMO a good example of the criteria a feature must meet to be backported.)
Kind regards,
--
Ben Caradoc-Davies <Ben.Caradoc-Davies@anonymised.com>
Software Engineer
CSIRO Earth Science and Resource Engineering
Australian Resources Research Centre
The work extends the REST api, but not internal APIs. The API has been
discussed with the community at length
in order to make it viable long term, so I don’t expect further changes
to it
We also need to consider the workspace filesystem layout for the templates to be stable so it survives dot-point upgrades (I think you modified this a bit in the drafts?). If the workspace filesystem layout stable, then the backport should be fine.
Hmm… it has been stable since we switched to the 2.0 data dir model, if we ever do a 3.x we will be able to change it,
but 3.x also means we’re breaking backwards compatibility, so we’re going to be fine