Hi all,
I submitted the following pull request to geoserver master:
https://github.com/geoserver/geoserver/pull/318
Since the actual user is the geonode project, I would need this to be backported to 2.3.x which is the branch geonode works against. (and hence 2.4.x for the sake of completeness).
Please review and comment on any concern with it. (btw, I found it hard to come up with a unit test using the current testing infrastructure so if that’s needed and you have a recommendation on how to do so I’m all ears).
TIA,
Gabriel
–
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
On Wed, Sep 4, 2013 at 7:56 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
Hi all,
I submitted the following pull request to geoserver master:
https://github.com/geoserver/geoserver/pull/318
Since the actual user is the geonode project, I would need this to be
backported to 2.3.x which is the branch geonode works against. (and hence
2.4.x for the sake of completeness).
Can we backport to 2.4.x once 2.4.0 is out?
Please review and comment on any concern with it. (btw, I found it hard to
come up with a unit test using the current testing infrastructure so if
that's needed and you have a recommendation on how to do so I'm all ears).
Eh, not easy indeed. The way to go would be, probably, to write a testing
store that acts like a mock, but whose
factory can be registered and be picked up by GeoServer as a real store.
Lot of work...
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
On Wed, Sep 4, 2013 at 3:08 PM, Andrea Aime <andrea.aime@anonymised.com>wrote:
On Wed, Sep 4, 2013 at 7:56 PM, Gabriel Roldan <groldan@anonymised.com>wrote:
Hi all,
I submitted the following pull request to geoserver master:
https://github.com/geoserver/geoserver/pull/318
Since the actual user is the geonode project, I would need this to be
backported to 2.3.x which is the branch geonode works against. (and hence
2.4.x for the sake of completeness).
Can we backport to 2.4.x once 2.4.0 is out?
Sure. The real question is whether we can backport to 2.3.x now. If not its
not a big issue, I guess they can run a custom build for the time being.
Please review and comment on any concern with it. (btw, I found it hard
to come up with a unit test using the current testing infrastructure so if
that's needed and you have a recommendation on how to do so I'm all ears).
Eh, not easy indeed. The way to go would be, probably, to write a testing
store that acts like a mock, but whose
factory can be registered and be picked up by GeoServer as a real store.
Lot of work...
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
On Wed, Sep 4, 2013 at 8:14 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
On Wed, Sep 4, 2013 at 3:08 PM, Andrea Aime <andrea.aime@anonymised.com>wrote:
On Wed, Sep 4, 2013 at 7:56 PM, Gabriel Roldan <groldan@anonymised.com>wrote:
Hi all,
I submitted the following pull request to geoserver master:
https://github.com/geoserver/geoserver/pull/318
Since the actual user is the geonode project, I would need this to be
backported to 2.3.x which is the branch geonode works against. (and hence
2.4.x for the sake of completeness).
Can we backport to 2.4.x once 2.4.0 is out?
Sure. The real question is whether we can backport to 2.3.x now. If not
its not a big issue, I guess they can run a custom build for the time
being.
Hum... 2.3.x is officially abandoned, there are no more releases from it,
so I don't see a reason not to backport.
Unless others have objects and/or want to make more releases, but the patch
seemed innocuous enough
Cheers
Andrea
--
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------