[Geoserver-devel] Re: short time plans

Yeah, I'm for that refactoring. But hold off on things this week, as I'm
at refractions, and we may be able to do some good work on sld and lite
renderer2, and it'll be a lot harder if it's being refactored from under
us. We should talk about plans for this week, I"ll try to send an email
later today, and to get online at a time to talk to you. But basically we
will probably get Jesse's help to use literenderer2, and redo style
management in geoserver a bit (like the uploading of new styles, and want
to allow users to directly edit styles in the web app (like with a text
box). What's the status of the SLD support you've done? I don't know if
we'll get to it, but want to work through supporting SLD in WMS requests,
and to support WMS Post requests, for udig. But basically we can get
refractions assistance this week, so we should use it, and coordinate our
plans, since we want the same thing, a much better WMS. After this week
you can refactor into core/wms/wfs, ect. I always thought that was how it
should have been done in the first place. Just make sure the gui all
works quite nicely, test everything.

Ok, a bit later in the day. Jody is all for the refactoring as well. But
he wants the config/action/form stuff also _in_ the services. I am for
this - notice that each of them also divides up into wms/wfs/data, ect.
These two I believe should be across the services. This implies that the
struts gui is a core component, that each service should have, which I
think I essentially agree with. Perhaps Jody can sound in a bit - we can
map out the new structure that we want, make sure that everyone is really
on the same page before you go redoing it all. And please hold off till
next week, so we can get these changes in first, so we don't have to deal
with broken builds and having everything flip around, as it needs to,
since it's a massive refactoring. But it's a good one, pointing in the
right directions for sure.

Chris

On Mon, 28 Feb 2005, Gabriel Roldán wrote:

Hi Chris and David,
this is to ask you for your permission to start doing some refactoring
to the geoserver code base (sound scary, but don't fear)

The thing is, I'm currently working (finally) on getlegendgraphic
support, wms demo, etc. and the more I work on the code base as it is,
the less I like it (I know it's my fault, may be it is time of start
resolving it)

In the mean time, I already did a slight refactoring to register map
producers as factories, just like filterfactory, datastorefactory, etc.
in geotools. It seems working perfectly, and provided a way to easyly
incorporate GIF support provided by Richar Didier, without code
duplication, since now both JaiMapProducer and GifMapProducer are based
on the same DefaultRasterMapProducer (lite renderer based) and just need
to implement writeTo(OutputStream) to encode the BufferedImage produced
bu LiteR.

So, my plan is to keep doing such things for the rest of operations,
starting with GetLegendGraphic, and in short have all the services by
this way.

There is also the fact that the code base is getting a monster and
difficult to follow, due to the way packages are organized. This, along
with the plan to separate services as plugins, goes to the need of
refactoring the packages on a service base. Something like-

org.vfny.geoserver.wms.*
org.vfny.geoserver.wfs.*
org.vfny.geoserver.core.*
org.vfny.geoserver.config.*
etc.
              
If you're ok with this, I can manage to start doing this refactoring in
a slight fashion, provided that the build is not broken.

May be we should plan a maven style project model for 1.4?

please let me know what you think,

best regards,

Gabriel Roldán (groldan@anonymised.com)
Axios Engineering
CR/Basurtu-Kastrexana 70, Mod. 14
48002, Bilbao - Bizkaia - Spain
Tel. (+34) 944 41 63 84
Fax. (+34) 944 41 64 90

--