[Geoserver-devel] Ready for the feature collection cleanup to land?

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

If everything is ready can we also have the pull request on the Geoserver side
so that we can give it a kick and call this refactor done?

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Sounds good on this end, will make a 9.0-M0 tag before the patch is applied (so there is a safe point to latch onto for any projects that need it).


Jody Garnett

On Saturday, 10 November 2012 at 7:09 PM, Andrea Aime wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

If everything is ready can we also have the pull request on the Geoserver side
so that we can give it a kick and call this refactor done?

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov


GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

I pushed the changes up to my own repo last weekend and was waiting for a review, specially of the secure feature collection part of the changes. Perhaps I missed it but never heard back if it looked ok or not.

If everything is ready can we also have the pull request on the Geoserver side
so that we can give it a kick and call this refactor done?

https://github.com/geoserver/geoserver/pull/61

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov


GeoTools-Devel mailing list
GeoTools-Devel@anonymised.coms.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

I commented on github, will do so again here:

  1. The changes were smoothly applied, did not see any major workarounds like in GeoTools or uDig
    2 We could make use of some of those DataUtilities methods.
  2. I tend to do try / finally around each FeatureIterator
  3. The security feature collections were fine, I wanted to make sure there was no way to accidentally get to the delegate and “add” anything. And yes they are all wrapped up


Jody Garnett

On Monday, 12 November 2012 at 10:46 AM, Justin Deoliveira wrote:

On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

I pushed the changes up to my own repo last weekend and was waiting for a review, specially of the secure feature collection part of the changes. Perhaps I missed it but never heard back if it looked ok or not.

If everything is ready can we also have the pull request on the Geoserver side
so that we can give it a kick and call this refactor done?

https://github.com/geoserver/geoserver/pull/61

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov


GeoTools-Devel mailing list
GeoTools-Devel@anonymised.coms.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.


Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov


GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

On Mon, Nov 12, 2012 at 1:46 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

I pushed the changes up to my own repo last weekend and was waiting for a review, specially of the secure feature collection part of the changes. Perhaps I missed it but never heard back if it looked ok or not.

Ops, sorry Justin, I definitely reviewed the changes and they were ok, believe I’ve wrote
something down too on the pull request but I guess I got distracted and failed to
send the message… sorry!

Anyways, good to go

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Great, thanks guys. So if i read the meeting minutes the plan is to pull the trigger on this (geoserver + udig) next weekend?

On Mon, Nov 12, 2012 at 7:47 AM, Andrea Aime <andrea.aime@anonymised.com…1268…> wrote:

On Mon, Nov 12, 2012 at 1:46 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

I pushed the changes up to my own repo last weekend and was waiting for a review, specially of the secure feature collection part of the changes. Perhaps I missed it but never heard back if it looked ok or not.

Ops, sorry Justin, I definitely reviewed the changes and they were ok, believe I’ve wrote
something down too on the pull request but I guess I got distracted and failed to
send the message… sorry!

Anyways, good to go

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

Yep. We are ready now ( after your branch is rebased ), it chose to avoid the work week.

Are you okay for Friday afternoon Justin? I can join you on IRC and push the button. then it should be done by the time Andrea wakes up and checks what happened to rendering performance.


Jody Garnett

On 13/11/2012, at 3:19 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Great, thanks guys. So if i read the meeting minutes the plan is to pull the trigger on this (geoserver + udig) next weekend?

On Mon, Nov 12, 2012 at 7:47 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Nov 12, 2012 at 1:46 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

I pushed the changes up to my own repo last weekend and was waiting for a review, specially of the secure feature collection part of the changes. Perhaps I missed it but never heard back if it looked ok or not.

Ops, sorry Justin, I definitely reviewed the changes and they were ok, believe I’ve wrote
something down too on the pull request but I guess I got distracted and failed to
send the message… sorry!

Anyways, good to go

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.


Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov


GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

On Mon, Nov 12, 2012 at 4:31 PM, Jody Garnett <jody.garnett@anonymised.com> wrote:

Yep. We are ready now ( after your branch is rebased ), it chose to avoid the work week.

Are you okay for Friday afternoon Justin? I can join you on IRC and push the button. then it should be done by the time Andrea wakes up and checks what happened to rendering performance.

Yup, sure i will be around. And in the meantime I will try to merge in the latest to my branch (i never rebase a public branch until doing a merge back into a primary branch) .


Jody Garnett

On 13/11/2012, at 3:19 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Great, thanks guys. So if i read the meeting minutes the plan is to pull the trigger on this (geoserver + udig) next weekend?

On Mon, Nov 12, 2012 at 7:47 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

On Mon, Nov 12, 2012 at 1:46 AM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

On Sat, Nov 10, 2012 at 2:09 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
I was chatting with Jody on IRC and it seems the feature collection work on
the Geotools side is done with a pull request ready to be merged.
uDig seems to be ready as well, whilst GeoServer wise as far as I understand
we have a branch that Justin made that also works, but no pull request.

I pushed the changes up to my own repo last weekend and was waiting for a review, specially of the secure feature collection part of the changes. Perhaps I missed it but never heard back if it looked ok or not.

Ops, sorry Justin, I definitely reviewed the changes and they were ok, believe I’ve wrote
something down too on the pull request but I guess I got distracted and failed to
send the message… sorry!

Anyways, good to go

Cheers

Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it



Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.


Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_nov


GeoTools-Devel mailing list
GeoTools-Devel@anonymised.comeforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.