[Geoserver-devel] Regression in GWC UI in 2.8-RC1 [GEOS-7203]

GeoServer GeoServer Developer
1

Reported as https://osgeo-org.atlassian.net/browse/GEOS-7203

I have a fix for the NPE, but fixing the unit tests that should have
caught this problem is proving extremely difficult. I just can't figure
out what Wicket is doing in order to get the test to replicate it.

You can't leave the tile caching tab (by saving or switching tabs) while
the layer has no cache. This means the cache can't be removed via the
UI, and any changes made on other tabs will be lost if the user visits
the tile caching tab and doesn't turn on caching. This seems to be a
blocker level bug so if I can't get the test fixed today, we either need
to merge the fix without a test, or push back the release (or someone
else needs to get the unit test working)

Fix:

https://github.com/smithkm/geoserver/commit/f4bbc6ebcff8f63e871ceb9711df3ae3280103a9

Unit test that's failing to detect the problem:

https://github.com/geoserver/geoserver/blob/master/src/web/gwc/src/test/java/org/geoserver/gwc/web/layer/LayerCacheOptionsTabPanelTest.java#L156

--
  Kevin Michael Smith
  smithkm@anonymised.com

2

I have the test failing without the patch although the way I
accomplished it isn't pretty.

https://github.com/geoserver/geoserver/pull/1220/commits

--
  Kevin Michael Smith
  smithkm@anonymised.com

On Thu, Sep 17, 2015, at 01:16 PM, Kevin Smith wrote:

Reported as https://osgeo-org.atlassian.net/browse/GEOS-7203

I have a fix for the NPE, but fixing the unit tests that should have
caught this problem is proving extremely difficult. I just can't figure
out what Wicket is doing in order to get the test to replicate it.

You can't leave the tile caching tab (by saving or switching tabs) while
the layer has no cache. This means the cache can't be removed via the
UI, and any changes made on other tabs will be lost if the user visits
the tile caching tab and doesn't turn on caching. This seems to be a
blocker level bug so if I can't get the test fixed today, we either need
to merge the fix without a test, or push back the release (or someone
else needs to get the unit test working)

Fix:

https://github.com/smithkm/geoserver/commit/f4bbc6ebcff8f63e871ceb9711df3ae3280103a9

Unit test that's failing to detect the problem:

https://github.com/geoserver/geoserver/blob/master/src/web/gwc/src/test/java/org/geoserver/gwc/web/layer/LayerCacheOptionsTabPanelTest.java#L156

--
  Kevin Michael Smith
  smithkm@anonymised.com

------------------------------------------------------------------------------
Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

3

Hi Kevin,
just to be sure, the release is still planned for the 23rd, yes?

Cheers
Andrea

···

On Thu, Sep 17, 2015 at 10:16 PM, Kevin Smith <smithkm@anonymised.com> wrote:

Reported as https://osgeo-org.atlassian.net/browse/GEOS-7203

I have a fix for the NPE, but fixing the unit tests that should have
caught this problem is proving extremely difficult. I just can’t figure
out what Wicket is doing in order to get the test to replicate it.

You can’t leave the tile caching tab (by saving or switching tabs) while
the layer has no cache. This means the cache can’t be removed via the
UI, and any changes made on other tabs will be lost if the user visits
the tile caching tab and doesn’t turn on caching. This seems to be a
blocker level bug so if I can’t get the test fixed today, we either need
to merge the fix without a test, or push back the release (or someone
else needs to get the unit test working)

Fix:

https://github.com/smithkm/geoserver/commit/f4bbc6ebcff8f63e871ceb9711df3ae3280103a9

Unit test that’s failing to detect the problem:

https://github.com/geoserver/geoserver/blob/master/src/web/gwc/src/test/java/org/geoserver/gwc/web/layer/LayerCacheOptionsTabPanelTest.java#L156

–
Kevin Michael Smith
smithkm@anonymised.com

Monitor Your Dynamic Infrastructure at Any Scale With Datadog!
Get real-time metrics from all of your servers, apps and tools
in one place.
SourceForge users - Click here to start your Free Trial of Datadog now!
http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

4

On Fri, Sep 18, 2015 at 12:53 AM, Kevin Smith <smithkm@anonymised.com> wrote:

I have the test failing without the patch although the way I
accomplished it isn't pretty.

Wicket ain't pretty....

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

5

On 2015-09-17 04:05 PM, Andrea Aime wrote:

Hi Kevin,
just to be sure, the release is still planned for the 23rd, yes?

Sorry, I started this email yesterday then forgot to send it.

As far as I know, assuming that PR gets merged and backported. I'm on
vacation at the moment so I'm not really following things too closely
though. Internet access on the 23rd may be problematic so I may not be
able to do the GWC 1.8.0 release. I can probably get at least email via
my phone, although it may be a bit unreliable and if there's no other
option I'll head back to civilization. Knowing ahead of time when
(what time of day) the GeoTools Release will probably be done would help.

--
Kevin Michael Smith
<smithkm@anonymised.com>