[Geoserver-devel] Reinstating request logging?

GeoServer GeoServer Developer
1

Hi,
with the last raft of changes in trunk we apparently lost
request logging at info level (I don't know if it's
the logging subsystem changes or anythign else).

Anyways, I think it would be nice to have it back,
and the most natural place would be the Dispatcher,
aint' it?

Would it make sense to you if we put the, say, first 1024
chars of whatever request at info logging level, and the
full request if the fine or finer level is enabled? (well,
full, maybe 10k or something, I mean, xml requests are
really unbounded).

Cheers
Andrea

2

That makes so much sense to me that it's already a running non-commited change on my local gs-trunk checkout.

+1 from me.

--saul

________________________________

From: geoserver-devel-bounces@lists.sourceforge.net on behalf of Andrea Aime
Sent: Mon 7/16/2007 4:45 AM
To: Geoserver-devel
Subject: [Geoserver-devel] Reinstating request logging?

Hi,
with the last raft of changes in trunk we apparently lost
request logging at info level (I don't know if it's
the logging subsystem changes or anythign else).

Anyways, I think it would be nice to have it back,
and the most natural place would be the Dispatcher,
aint' it?

Would it make sense to you if we put the, say, first 1024
chars of whatever request at info logging level, and the
full request if the fine or finer level is enabled? (well,
full, maybe 10k or something, I mean, xml requests are
really unbounded).

Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

3

Farber, Saul (EEA) ha scritto:

That makes so much sense to me that it's already a running non-commited change on my local gs-trunk checkout.

Nice, what does it do in particular? I mean, does it log all requests, only the first xxx bytes, all of it, which log levels and so on?
Cheers
Andrea

4

Hmm., I guess I actually did commit it. The lines are lines 239-247 of ows/.../Dispatcher.java.

Here: http://rafb.net/p/r1ImDl90.html

It only displays the first 1024 bytes of an XML-POST request, when log-level is FINE or higher (meaning that org.geoserver.ows.Dispatcher=DEBUG in log4j terms)

I think this idea should be made a bit more general, but don't forget that the debug levels need to get translated into log4j now.

So if you set org.geoserver.ows.Dispatcher=DEBUG then you'll get a detailed examination of the requests. First 1024 (or 2048?) bytes of the request?

If you set org.geoserver.ows.Dispatcher=INFO then you'll get a basic, no-frills, semi-terse examination of the requests. Perhaps just a "request.toString()" of the request?

--saul

________________________________

From: geoserver-devel-bounces@lists.sourceforge.net on behalf of Andrea Aime
Sent: Mon 7/16/2007 10:49 AM
To: Farber, Saul (EEA)
Cc: Geoserver-devel
Subject: Re: [Geoserver-devel] Reinstating request logging?

Farber, Saul (EEA) ha scritto:

That makes so much sense to me that it's already a running non-commited change on my local gs-trunk checkout.

Nice, what does it do in particular? I mean, does it log all requests,
only the first xxx bytes, all of it, which log levels and so on?
Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

5

Farber, Saul (EEA) ha scritto:

Hmm., I guess I actually did commit it. The lines are lines 239-247 of ows/.../Dispatcher.java.
Here: http://rafb.net/p/r1ImDl90.html
It only displays the first 1024 bytes of an XML-POST request, when log-level is FINE or higher (meaning that org.geoserver.ows.Dispatcher=DEBUG in log4j terms)

Nice, it would be good to have the same for GET requests tought.

I think this idea should be made a bit more general, but don't forget that the debug levels need to get translated into log4j now.
So if you set org.geoserver.ows.Dispatcher=DEBUG then you'll get a detailed examination of the requests. First 1024 (or 2048?) bytes of the request?
If you set org.geoserver.ows.Dispatcher=INFO then you'll get a basic, no-frills, semi-terse examination of the requests. Perhaps just a "request.toString()" of the request?

Yeah, that would be good too.
Cheers
Anbdrea