[Geoserver-devel] Release GeoTools 12.0 / GeoServer 2.6.0 plan

Andrea Aime wrote:

On Mon, Sep 22, 2014 at 1:25 PM, Ian Turton <ijturton@...403...> wrote:

from a quick check (sorry still jet lagged) I think everything up to GEOS-6647 will go in. GEOS-6651 is the only one that looks like a show stopper but I have no idea if any one is working on it.

Doh, GEOS-6651 is actually a user error, they changed the version of WMS without flipping the bbox coordinates, no wonder
it's not showing anything...

https://jira.codehaus.org/browse/GEOS-6651

Right, and I made an elementary mistake by not checking that. Perhaps there is still something also on our side. Notice that the wrong axis order was hidden because &VERSION=1.3 sent a map. Actually almost anything in VERSION sends a map: "000", "0.00", "99.99". It needs to be something like "XYZ" before getting an error:
<ows:Exception exceptionCode="NoApplicableCode">
<ows:ExceptionText>java.util.IllegalFormatConversionException: d != java.lang.String
d != java.lang.String</ows:ExceptionText>
</ows:Exception>
</ows:ExceptionReport>

Perhaps we should send an error also for unsupported numeric WMS versions ? Excerpt from WMS 1.3.0 standard:

1) 7.3.3.1 VERSION
The mandatory VERSION parameter is defined in 6.9.1. The value “1.3.0” shall be used for GetMap requests that
comply with this International Standard.

2) An invalid GetMap request shall yield an error output in the requested Exceptions format (or a network protocol
error response in extreme cases).

-Jukka Rahkonen-

On Tue, Sep 23, 2014 at 3:16 PM, Rahkonen Jukka (Tike) <
jukka.rahkonen@anonymised.com> wrote:

Andrea Aime wrote:

> On Mon, Sep 22, 2014 at 1:25 PM, Ian Turton <ijturton@anonymised.com> wrote:
>> from a quick check (sorry still jet lagged) I think everything up
to GEOS-6647 will go in. GEOS-6651 is the only one that looks like a show
stopper but I have no idea if any one is working on it.

> Doh, GEOS-6651 is actually a user error, they changed the version of WMS
without flipping the bbox coordinates, no wonder
> it's not showing anything...

> https://jira.codehaus.org/browse/GEOS-6651

Right, and I made an elementary mistake by not checking that

I actually did not notice either the first time, realized it because I took
the preview, opened the options,
switched to wms 1.3 there, and it was still working... that led me to
double check the request better.

. Perhaps there is still something also on our side. Notice that the wrong
axis order was hidden because &VERSION=1.3 sent a map. Actually almost
anything in VERSION sends a map: "000", "0.00", "99.99". It needs to be
something like "XYZ" before getting an error:
<ows:Exception exceptionCode="NoApplicableCode">
<ows:ExceptionText>java.util.IllegalFormatConversionException: d !=
java.lang.String
d != java.lang.String</ows:ExceptionText>
</ows:Exception>
</ows:ExceptionReport>

Perhaps we should send an error also for unsupported numeric WMS versions
? Excerpt from WMS 1.3.0 standard:

1) 7.3.3.1 VERSION
The mandatory VERSION parameter is defined in 6.9.1. The value “1.3.0”
shall be used for GetMap requests that
comply with this International Standard.

2) An invalid GetMap request shall yield an error output in the requested
Exceptions format (or a network protocol
error response in extreme cases).

GeoServer has traditionally been lenient towards the version parameter, we
have never made it mandatory.
About the invalid version number, not sure either, I've just tried sending
a request with version=1.2.0 and it
was accepted returning nothing, probably because the axis flipping logic
only checks for version exactly
equal to "1.3.0"

Also, when zooming out a lot in OL and other classic js based tools we get
"invalid" requests all time, as in, requests
that have out of range values for lon/lat, but I don't believe we shouldbe
complaining (or if we want, that should
be part of the cite compliance flags).

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------