[Geoserver-devel] Remove legacy json path support

Dear sirs,

I’m writing to propose the removal of legacy json path for MongoDB since they are causing failings in latest version. The will involve the removal of the class ComplexMongoDBLegacyTest.java as well as all the code which uses or references the property org.geotools.data.mongodb.complex.useLegacyPaths.

Here the Jira ticket https://osgeo-org.atlassian.net/browse/GEOS-9429.

Best regards,
Marco Volpini

Hi all,
I’m working whit Marco on this one, adding a bit of historical context:

When support for MongoDB was added in App-Schema (a few years ago) we always had to use the full JSON path, even when chaining features together.
After a few real use cases tests, while MongoDB was still in unsupported land, it become evident that always referencing the full JSON path was not a good idea:

  • we could not reuse mappings for a feature type that appear in several places
  • every chained feature trigger a completely new mapping tree

… so the system was changed to allow relative paths to be used, so when chaining a feature the provided JSON paths will always assumed to be relative to the parent features [1].

The old full JSON path syntax was keep around just because it was already there, but has not be maintained and its pretty much broke, hence the mail from Marco proposing to remove it.

So if someone is against it, please let us know :slight_smile:

Kind regards,
Nuno Oliveira

[1] https://docs.geoserver.org/latest/en/user/data/app-schema/mongo-tutorial.html

On Thu, 2019-12-12 at 10:24 +0100, Marco Volpini wrote:

Dear sirs,

I’m writing to propose the removal of legacy json path for MongoDB since they are causing failings in latest version. The will involve the removal of the class ComplexMongoDBLegacyTest.java as well as all the code which uses or references the property org.geotools.data.mongodb.complex.useLegacyPaths.

Here the Jira ticket https://osgeo-org.atlassian.net/browse/GEOS-9429.

Best regards,
Marco Volpini

_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@anonymised.comsts.sourceforge.net](mailto:Geoserver-devel@lists.sourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the
experts! 
Visit http://goo.gl/it488V for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Con riferimento alla normativa sul trattamento dei dati 
personali (Reg. UE 2016/679 - Regolamento generale sulla 
protezione dei dati “GDPR”), si precisa che ogni 
circostanza inerente alla presente email (il suo contenuto, 
gli eventuali allegati, etc.) è un dato la cui conoscenza 
è riservata al/i solo/i destinatario/i indicati dallo 
scrivente. Se il messaggio Le è giunto per errore, è 
tenuta/o a cancellarlo, ogni altra operazione è illecita. 
Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to 
which it is addressed and may contain information that 
is privileged, confidential or otherwise protected from 
disclosure. We remind that - as provided by European 
Regulation 2016/679 “GDPR” - copying, dissemination or 
use of this e-mail or the information herein by anyone 
other than the intended recipient is prohibited. If you 
have received this email by mistake, please notify 
us immediately by telephone or e-mail.

Thanks for the background Nuno, I am not using this datastore presently and do not have any input. If we are really concerned we could reach out to the user list (or search who has asked questions about it recently).

Beyond that Stefano and myself are listed as geotools module maintainer for MongoDB. In my this case from my time at Boundless where I had access to a test environment. Perhaps this should updated if you are working with customers on this platform?

···


Jody Garnett

Hi Jody,
Fernando just did a PR adding us as the modules maintainers:
https://github.com/geotools/geotools/pull/2738

Best regards,
Nuno Oliveira

···


Jody Garnett