Alessio,
I removed backup-restore from the communityRelease profile because it does not compile.
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
The backup-restore PR has been merged before all its dependencies have been merged.
In this specific case, the https://github.com/geoserver/geoserver/pull/1664 must be merged before backup-restore otherwise it won’t compile.
···
On Thu, Jul 28, 2016 at 5:04 AM, Ben Caradoc-Davies <ben@anonymised.com> wrote:
Alessio,
I removed backup-restore from the communityRelease profile because it does not compile.
Kind regards,
–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Best Regards,
Alessio Fabiani.
==
GeoServer Professional Services from the experts!
Visit http://goo.gl/it488V for more information.
Ing. Alessio Fabiani
@alfa7691
Founder/Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
On Thu, Jul 28, 2016 at 9:31 AM, Alessio Fabiani <
alessio.fabiani@anonymised.com> wrote:
The backup-restore PR has been merged before all its dependencies have
been merged.In this specific case, the
https://github.com/geoserver/geoserver/pull/1664 must be merged before
backup-restore otherwise it won't compile.
My fault, I thought I merged that one and instead merged the backport on
2.9.x (having both master pull and backport at the same time confused me).
I reverted the backport and merged the right one
Cheers
Andrea
--
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
On 28/07/16 19:39, Andrea Aime wrote:
My fault, I thought I merged that one and instead merged the backport on
2.9.x (having both master pull and backport at the same time confused me).
I reverted the backport and merged the right one
Thanks, Andrea. That fixed the compilation of backup-restore for me so I added it back to the communityRelease profile.
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
On 29/07/16 09:52, Ben Caradoc-Davies wrote:
On 28/07/16 19:39, Andrea Aime wrote:
My fault, I thought I merged that one and instead merged the backport on
2.9.x (having both master pull and backport at the same time confused me).
I reverted the backport and merged the right oneThanks, Andrea. That fixed the compilation of backup-restore for me so I
added it back to the communityRelease profile.
There is nothing in our Travis CI configuration to test whether a build with -DskipTests -PcommunityRelease succeeds. This means that we will not find out if a pull request targeting a community module breaks Jenkins on ares until it is merged.
Travis CI allows multiple script commands. At the cost of slower builds, would it be worthwhile to add coverage of communityRelease. The manual also documents the use of a "&&" short circuit to fail fast:
https://docs.travis-ci.com/user/customizing-the-build/
I think fail-fast is more appropriate as there is no point building with -PcommunityRelease as with two mvn commands there is not reactor to coordinate module dependencies.
I will make a pull request for your consideration.
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
On 29/07/16 10:42, Ben Caradoc-Davies wrote:
There is nothing in our Travis CI configuration to test whether a build
with -DskipTests -PcommunityRelease succeeds. This means that we will
not find out if a pull request targeting a community module breaks
Jenkins on ares until it is merged.
Travis CI allows multiple script commands. At the cost of slower builds,
would it be worthwhile to add coverage of communityRelease. The manual
also documents the use of a "&&" short circuit to fail fast:
https://docs.travis-ci.com/user/customizing-the-build/
I think fail-fast is more appropriate as there is no point building with
-PcommunityRelease as with two mvn commands there is not reactor to
coordinate module dependencies.
I will make a pull request for your consideration.
Add Travis CI coverage of communityRelease profile
https://github.com/geoserver/geoserver/pull/1720
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand