[Geoserver-devel] Removing commons-digester dependency from gs-main?

Andrea_Aime4 · July 25, 2014, 10:10am

Hi,
following up this report:
https://jira.codehaus.org/browse/GEOS-6589
I did some checks, and it seems to me we don’t need digester
anymore, I just removed it from the pom, did a full build,
and it worked.

Objections/concerns about removing that dependency?

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Justin_Deoliveira · July 25, 2014, 2:29pm

None here. The more dependencies we can remove from core modules the better imo.

···

On Fri, Jul 25, 2014 at 4:10 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
following up this report:
https://jira.codehaus.org/browse/GEOS-6589
I did some checks, and it seems to me we don’t need digester
anymore, I just removed it from the pom, did a full build,
and it worked.

Objections/concerns about removing that dependency?

Cheers
Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world’s largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Justin Deoliveira
VP Engineering | Boundless
jdeolive@anonymised.com
@boundlessgeo

Andrea_Aime4 · July 26, 2014, 10:04am

On Fri, Jul 25, 2014 at 4:29 PM, Justin Deoliveira <
jdeolive@anonymised.com> wrote:

None here. The more dependencies we can remove from core modules the
better imo.

Removed it.
Then I had a look with mvn dependency:analyze, the plugin can apparenlty
find unused dependencies
(well, sort of, it cannot spot stuff that we depend on via spring).
The output is:

[WARNING] Unused declared dependencies found:
[WARNING] commons-fileupload:commons-fileupload:jar:1.2.1:compile
[WARNING] commons-httpclient:commons-httpclient:jar:3.1:compile
[WARNING] commons-validator:commons-validator:jar:1.1.4:compile
[WARNING] oro:oro:jar:2.0.8:compile
[WARNING] org.geotools:gt-validation:jar:12-SNAPSHOT:compile
[WARNING] org.geotools:gt-data:jar:12-SNAPSHOT:compile
[WARNING] org.geotools:gt-epsg-hsql:jar:12-SNAPSHOT:compile
[WARNING] org.springframework:spring-aop:jar:3.1.4.RELEASE:compile
[WARNING] cglib:cglib-nodep:jar:2.2:test
[WARNING] org.geotools:gt-arcgrid:jar:12-SNAPSHOT:test
[WARNING] org.geotools:gt-gtopo30:jar:12-SNAPSHOT:test
[WARNING] org.geotools:gt-image:jar:12-SNAPSHOT:test
[WARNING] org.geotools.jdbc:gt-jdbc-postgis:jar:12-SNAPSHOT:test
[WARNING]
org.springframework.security:spring-security-config:jar:3.1.0.RELEASE:compile
[INFO]
------------------------------------------------------------------------

While there is some obvious stuff we depend on via spring, or that is there
because we have some test data using it in other modules, there is
also stuff that I believe could be dropped, such as:
- oro
- gt-validation
- commons-validation

Going to make some full builds and see if there is anything else we can drop

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Andrea_Aime4 · July 26, 2014, 5:00pm

On Sat, Jul 26, 2014 at 12:04 PM, Andrea Aime <andrea.aime@anonymised.com>
wrote:

While there is some obvious stuff we depend on via spring, or that is there
because we have some test data using it in other modules, there is
also stuff that I believe could be dropped, such as:
- oro
- gt-validation
- commons-validation

Going to make some full builds and see if there is anything else we can
drop

All right, got a few more that seemed obvious candidates to drop, here is
a pull request:
https://github.com/geoserver/geoserver/pull/665

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Justin_Deoliveira · July 27, 2014, 7:30am

Nice. One step in the right direction towards a leaner meaner GeoServer

+1

···

On Sat, Jul 26, 2014 at 11:00 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

–

Justin Deoliveira
VP Engineering | Boundless
jdeolive@anonymised.com
@boundlessgeo

On Sat, Jul 26, 2014 at 12:04 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

All right, got a few more that seemed obvious candidates to drop, here is
a pull request:
https://github.com/geoserver/geoserver/pull/665

Cheers

Andrea

–

==

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

While there is some obvious stuff we depend on via spring, or that is there

because we have some test data using it in other modules, there is
also stuff that I believe could be dropped, such as:

oro
gt-validation
commons-validation

Going to make some full builds and see if there is anything else we can drop

Chris_Snider · July 28, 2014, 1:54pm

Hi,

Having run into this issue myself on other projects, are there any dependencies that can be marked with scope test to prevent them in the final jar/war?

Chris Snider

Senior Software Engineer

Intelligent Software Solutions, Inc.

(attachments)

···

Nice. One step in the right direction towards a leaner meaner GeoServer

+1

On Sat, Jul 26, 2014 at 11:00 AM, Andrea Aime <andrea.aime@…1268…> wrote:

On Sat, Jul 26, 2014 at 12:04 PM, Andrea Aime <andrea.aime@…1268…> wrote:

While there is some obvious stuff we depend on via spring, or that is there

because we have some test data using it in other modules, there is

also stuff that I believe could be dropped, such as:

oro
gt-validation
commons-validation

Going to make some full builds and see if there is anything else we can drop

All right, got a few more that seemed obvious candidates to drop, here is

a pull request:

https://github.com/geoserver/geoserver/pull/665

Cheers

Andrea

–

==

GeoServer Professional Services from the experts! Visit

http://goo.gl/NWWaa2 for more information.

==

Ing. Andrea Aime

@geowolf

Technical Lead

GeoSolutions S.A.S.

Via Poggio alle Viti 1187

55054 Massarosa (LU)

Italy

phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 339 8844549

http://www.geo-solutions.it

http://twitter.com/geosolutions_it

–

Justin Deoliveira
VP Engineering | Boundless
jdeolive@…3839…
@boundlessgeo

Andrea_Aime4 · July 28, 2014, 2:08pm

On Mon, Jul 28, 2014 at 3:54 PM, Chris Snider <chris.snider@anonymised.com>
wrote:

Hi,

Having run into this issue myself on other projects, are there any
dependencies that can be marked with scope test to prevent them in the
final jar/war?

I've removed a few others in this pull request:
https://github.com/geoserver/geoserver/pull/665/files
If you find others that you think could be removed because unused, please
let us know.

I also believe there might be other depedencies that could be removed by
reworking the small
bits of code using them, of course that is a lot riskier, but I believe
we're open to it if you
can show a dependency is causing troubles, and you have time to work on a
pull request
to rework the code

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------