Hi,
this commit backports the rendering based featureinfo to the 2.4.x branch:
https://github.com/aaime/geoserver/commit/9b61a38e1fdbc50da720a4af9a10713723986550
Before you freak out, 99% of the code in there is new files for the rendering based feature info,
the interesting bit touching the existing 2.4.x code is in the GetFeatureInfo class:
if(VectorRenderingLayerIdentifier.RENDERING_FEATUREINFO_ENABLED && layer.getFeatureSource(false).getSchema() instanceof SimpleFeatureType) {
FeatureInfoRequestParameters params = new FeatureInfoRequestParameters(request);
params.setCurrentLayer(i);
List collections = new VectorRenderingLayerIdentifier(wms).identify(params, maxFeatures);
if(collections != null && collections.size() > 0) {
collection = collections.get(0);
collection = selectProperties(collection, names);
}
} else {
final Map<String, String> viewParam = viewParams != null ? viewParams.get(i) : null;
collection = identifyVectorLayer(filters, x, y, buffer, viewParam,
requestedCRS, width, height, bbox, ff, results, i, layer, rules, maxFeatures,
times, elevations, names);
}
That is, the new code won’t kick in unless someone also explicitly sets -Dorg.geoserver.wms.featureinfo.render.enabled=true
among the system variables (so, the default is the opposite from trunk)
It’s a way for people to test it out sooner, and gather feedback before beta/RC status (which not many users
are willing to use anyways).
Objections, concerns?
Ah, for some reason when I make a pull request from my 2.4.x checkout it always ends up
targetting master (e.g., the diff viewer shows differences between my branch and master)… no idea why?
Anyone has previous experiences on why this might be happening?
For reference the branch is here:
https://github.com/aaime/geoserver/tree/featureinfo-backport
Cheers
Andrea
–
== GeoSolutions will be closed for seasonal holidays from 23/12/2013 to 06/01/2014 ==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it