Hi list,
As you may have noticed by some last JIRAs, we are doing some improvements on the ImageMosaic plugin to allow, as an instance, specifying a ThreadPoolExecutor through Hints from the outside (which will be used to manage multithreaded Granules loading).
In such a context, the idea is to allow the user to configure some parameters through the GeoServer GUI which will be used as default to initialize and configure a global ThreadPoolExecutor to be passed as Hints to the readers.
Therefore, I’m thinking about a new page in the navigation menu, exposing several parameters which can be customized in order to configure the coverage access settings.
As an instance, for the ThreadPoolExecutor configuration, they will be “Thread pool core size”, “Thread pool maximum size”, “Thread pool keep alive time”.
However, in the future, I think we can add more of them for different purposes.
I would avoid to insert these parameters in the JAI page or in the Global settings page since the first one is specific for “JAI’s topic” and the second one is for general settings.
I’m looking for suggestions on how to name that page… something like “Coverage access settings”…
Finally, what is the formal procedure to introduce/handle the changes? It is a “JIRA + patch to be reviewed” enough?
Please, let me know.
Regards,
Daniele
–
Eng. Daniele Romagnoli
Software Engineer
GeoSolutions S.A.S.
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39 0584983027
fax: +39 0584983027
mob: +39 328 0559267
http://www.geo-solutions.it
Hi Andrea,
On Sat, Aug 14, 2010 at 9:41 AM, Andrea Aime <aaime@anonymised.com> wrote:
On Wed, Aug 11, 2010 at 11:31 AM, Daniele Romagnoli
<daniele.romagnoli@anonymised.com68…> wrote:
Hi list,
As you may have noticed by some last JIRAs, we are doing some improvements on the ImageMosaic plugin to allow, as an instance, specifying a ThreadPoolExecutor through Hints from the outside (which will be used to manage multithreaded Granules loading).
In such a context, the idea is to allow the user to configure some parameters through the GeoServer GUI which will be used as default to initialize and configure a global ThreadPoolExecutor to be passed as Hints to the readers.
Therefore, I’m thinking about a new page in the navigation menu, exposing several parameters which can be customized in order to configure the coverage access settings.
As an instance, for the ThreadPoolExecutor configuration, they will be “Thread pool core size”, “Thread pool maximum size”, “Thread pool keep alive time”.
However, in the future, I think we can add more of them for different purposes.
I would avoid to insert these parameters in the JAI page or in the Global settings page since the first one is specific for “JAI’s topic” and the second one is for general settings.
I’m looking for suggestions on how to name that page… something like “Coverage access settings”…
What you propose makes sense to me. I am worried the lateral menu is
getting longer and longer and some day we’ll be forced to move to some
kind of “accordion” setup to allow at least the major titles to be
visible, but I guess we can face that problem later
Finally, what is the formal procedure to introduce/handle the changes? It is a “JIRA + patch to be reviewed” enough?
It normally is unless the change is massive. Question, where do you
plan to store all the new properties, object model wise?
I have checked what exists for similar thing and what I did was adding a “CoverageAccessInfo” interface similar to “JAIInfo, ContactInfo,…” as well as a proper implementation, and then added a getCoverageAccess and setCoverageAccess (like get/set-JAI, get/set-Contact) to the GeoServerInfo so that things will be stored in the global.xml like JAI settings and contact settings. Does it sound reasonable?
Regards,
Daniele
Cheers
Andrea
–
Eng. Daniele Romagnoli
Software Engineer
GeoSolutions S.A.S.
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39 0584983027
fax: +39 0584983027
mob: +39 328 0559267
http://www.geo-solutions.it