[Geoserver-devel] request to turn off formatting

GeoServer GeoServer Developer
1

Hi all,

I just lost 2 hours some work doing to the formatting problem. For some
reason my maven profile to turn off formatting in my settings.xml did
not engage and formatting went forward. When i reverted i accidentally
reverted some actual new code.

Furthermore i have a bunch of changes that i need to backport from trunk
to 1.5.x that will now be a lot more work to do.

Can i ask that we stop formatting until we have a solution that works
for every platform.

Thanks,

-Justin

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

2

Justin Deoliveira ha scritto:

Hi all,

I just lost 2 hours some work doing to the formatting problem. For some
reason my maven profile to turn off formatting in my settings.xml did
not engage and formatting went forward. When i reverted i accidentally
reverted some actual new code.

Furthermore i have a bunch of changes that i need to backport from trunk
to 1.5.x that will now be a lot more work to do.

Can i ask that we stop formatting until we have a solution that works
for every platform.

I feel your pain, so I'm not going to say no.
This means we'll be back to caos in a couple of months, too bad.
I don't see a cross platform, in build solution be available anywhere
soon.
The big bad format on release seems to be the best idea thought, one
person in the pool reformatting everything with Eclipse. Not ideal,
but probably better than what we have now.

Cheers
Andrea

3

Andrea, is there somewhere a sort of coding convention document we can adopt as strict rule for GeoServer coding, like tabs, tabs spaces and so on? If not we can create one … I know, this won’t solve our problem, but at least will be a sort of agreement for developers, and hopefully will help to maintain some order.

On 6/13/07, Andrea Aime <aaime@anonymised.com> wrote:

Justin Deoliveira ha scritto:

Hi all,

I just lost 2 hours some work doing to the formatting problem. For some
reason my maven profile to turn off formatting in my settings.xml did
not engage and formatting went forward. When i reverted i accidentally
reverted some actual new code.

Furthermore i have a bunch of changes that i need to backport from trunk
to 1.5.x that will now be a lot more work to do.

Can i ask that we stop formatting until we have a solution that works
for every platform.

I feel your pain, so I’m not going to say no.
This means we’ll be back to caos in a couple of months, too bad.
I don’t see a cross platform, in build solution be available anywhere
soon.
The big bad format on release seems to be the best idea thought, one
person in the pool reformatting everything with Eclipse. Not ideal,
but probably better than what we have now.

Cheers
Andrea

This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–

Eng. Alessio Fabiani
Vice-President /CTO GeoSolutions S.A.S.
Via Carignoni 51
55041 Camaiore (LU)
Italy

phone: +39 0584983027
fax: +39 0584983027
mob: +39 349 8227000

http://www.geo-solutions.it

4

Alessio Fabiani ha scritto:

Andrea, is there somewhere a sort of coding convention document we can adopt as strict rule for GeoServer coding, like tabs, tabs spaces and so on? If not we can create one ... I know, this won't solve our problem, but at least will be a sort of agreement for developers, and hopefully will help to maintain some order.

Well, I guess we should convert the jalopy configuration file into an Eclipse one. I think it's really just a matter of taking the Geotools
one (already available in geotools's SVN) and changing the headers.

Cheers
Andrea

5

Andrea Aime wrote:

Alessio Fabiani ha scritto:

Andrea, is there somewhere a sort of coding convention document we can adopt as strict rule for GeoServer coding, like tabs, tabs spaces and so on? If not we can create one ... I know, this won't solve our problem, but at least will be a sort of agreement for developers, and hopefully will help to maintain some order.

Well, I guess we should convert the jalopy configuration file into an Eclipse one. I think it's really just a matter of taking the Geotools
one (already available in geotools's SVN) and changing the headers.

Yeah, we have a standard, see: http://docs.codehaus.org/display/GEOSDOC/1+Formatting It's basically Sun's coding standards, with a couple small tweaks like putting on our headers. Making an eclipse version of the jalopy config would probably go a long way.

C

Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

!DSPAM:4005,466fa4e1126101137850744!

--
Chris Holmes
The Open Planning Project
http://topp.openplans.org

6

Chris Holmes ha scritto:

Andrea Aime wrote:

Alessio Fabiani ha scritto:

Andrea, is there somewhere a sort of coding convention document we can adopt as strict rule for GeoServer coding, like tabs, tabs spaces and so on? If not we can create one ... I know, this won't solve our problem, but at least will be a sort of agreement for developers, and hopefully will help to maintain some order.

Well, I guess we should convert the jalopy configuration file into an Eclipse one. I think it's really just a matter of taking the Geotools
one (already available in geotools's SVN) and changing the headers.

Yeah, we have a standard, see: http://docs.codehaus.org/display/GEOSDOC/1+Formatting It's basically Sun's coding standards, with a couple small tweaks like putting on our headers. Making an eclipse version of the jalopy config would probably go a long way.

Justin,
I'm finding myself not buildilng these days because formatting would
invitably mix in with my (unrelated) changes... ouff... ok, can you
remove jalopy from the build, and then issue an Eclipse configuration file?

Cheers
Andrea

7

Justin,
I'm finding myself not buildilng these days because formatting would
invitably mix in with my (unrelated) changes... ouff... ok, can you
remove jalopy from the build, and then issue an Eclipse configuration file?

I dont understand? This sounds like the same problem I am having?
Perhaps before taking this drastic measure I can corner saul and get him
to explain to me how he got it to work.

Saul, do i have it correct that once you set your locale to an
ISO-8859-1 one and then rechecked out the source code from scratch it
worked ok for you?

Cheers
Andrea

!DSPAM:4007,4671532c158988992556831!

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com

8

Justin,
Yes, I believe this was the fix, but in reality there were two different issues going on for me:
1) 'special' characters were getting changed (causing spurrious file changes)
2) unformatted files were getting formatted, causing what *looked* like spurrious file changes

The ISO-8859-1 change fixed #1, but until you run a big bulk format once, you'll still get the 'unformatted but in SVN' changes that come from #2.

I'll hop on IRC and we can try to work through it if you like. I think it'd be good for me to actually convince myself that it's really working, too. I could have fixed half of the problem and then just never discovered the other half of the problem.
--saul

________________________________

From: Justin Deoliveira [mailto:jdeolive@anonymised.com]
Sent: Thu 6/14/2007 11:28 AM
To: Andrea Aime
Cc: Saul Farber; geoserver-devel@lists.sourceforge.net
Subject: Re: [Geoserver-devel] request to turn off formatting

Justin,
I'm finding myself not buildilng these days because formatting would
invitably mix in with my (unrelated) changes... ouff... ok, can you
remove jalopy from the build, and then issue an Eclipse configuration file?

I dont understand? This sounds like the same problem I am having?
Perhaps before taking this drastic measure I can corner saul and get him
to explain to me how he got it to work.

Saul, do i have it correct that once you set your locale to an
ISO-8859-1 one and then rechecked out the source code from scratch it
worked ok for you?

Cheers
Andrea

!DSPAM:4007,4671532c158988992556831!

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com