Hi list,
I have been briefly looking at the new config, I am reporting a few
minor issues:
the eUML .ucd files have been committed, we should porbably get rid of them
I have noticed that for some interfaces the set of getters is not idempotent to the set of setters: as an instance the MapInfo interface is missing a setLayers method. Is this wanted or the side effect of a late night commit? Can I add the missing methods to the interfaces while I review the code?
Ciao,
Simone.
--
-------------------------------------------------------
Eng. Simone Giannecchini
President /CEO GeoSolutions S.A.S.
Via Carignoni 51
55041 Camaiore (LU)
Italy
phone: +39 0584983027
fax: +39 0584983027
mob: +39 333 8128928
http://www.geo-solutions.it
-------------------------------------------------------
Oops, i will remove the the ucd files... accidentally committed them.
As for MapInfo.setLayers, the method is intentionally not there. The convention i have been following in the model is to have properties of collections not have a setter. Instead just modifying the list returned from the getter directly.
Simone Giannecchini wrote:
Hi list,
I have been briefly looking at the new config, I am reporting a few
minor issues:
the eUML .ucd files have been committed, we should porbably get rid of them
I have noticed that for some interfaces the set of getters is not idempotent to the set of setters: as an instance the MapInfo interface is missing a setLayers method. Is this wanted or the side effect of a late night commit? Can I add the missing methods to the interfaces while I review the code?
Ciao,
Simone.
--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com