I've just attached a patch to
http://jira.codehaus.org/browse/GEOS-4803 that sets the css style on
input text components that have no style set, for the sake of
consistency in the UI, as the mix of styled and unstyled text fields
render more weirdly on some browsers than others.
But I'd like a review and go ahead before committing.
TIA,
Gabriel
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
Looks good to me.
On Wed, Oct 19, 2011 at 3:27 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
I’ve just attached a patch to
http://jira.codehaus.org/browse/GEOS-4803 that sets the css style on
input text components that have no style set, for the sake of
consistency in the UI, as the mix of styled and unstyled text fields
render more weirdly on some browsers than others.But I’d like a review and go ahead before committing.
TIA,
GabrielGabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@anonymised.com Self-Assessment and learn
about Cisco certifications, training, and career opportunities.
http://p.sf.net/sfu/cisco-dev2dev
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
On Wed, Oct 19, 2011 at 11:27 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
I've just attached a patch to
http://jira.codehaus.org/browse/GEOS-4803 that sets the css style on
input text components that have no style set, for the sake of
consistency in the UI, as the mix of styled and unstyled text fields
render more weirdly on some browsers than others.
Nice, thanks for the fix. Out of curiosity, what browser rendered them
more weirdly?
I normally use Chrome and Firefox (7) on Ubuntu, I actually never
noticed some of them
were unstyled
Cheers
Andrea
--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-------------------------------------------------------
On Thu, Oct 20, 2011 at 2:59 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
On Wed, Oct 19, 2011 at 11:27 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
I’ve just attached a patch to
http://jira.codehaus.org/browse/GEOS-4803 that sets the css style on
input text components that have no style set, for the sake of
consistency in the UI, as the mix of styled and unstyled text fields
render more weirdly on some browsers than others.Nice, thanks for the fix. Out of curiosity, what browser rendered them
more weirdly?
I normally use Chrome and Firefox (7) on Ubuntu, I actually never
noticed some of them
were unstyled
Yeah it is not to pull hears in Chrome and Firefox, but IE (6) sucks.
Actually it sucks a lot more on the un-styled buttons too. Don’t have other browsers to test with though.
Rollie: do you think the UI buttons could/should be homogenized too? (afaik we only have styled buttons mirroring the save/cancel links in case you need to use a button instead of a link?).
Cheers,
Gabriel
Cheers
Andrea–
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech leadVia Poggio alle Viti 1187
55054 Massarosa (LU)
Italyphone: +39 0584 962313
fax: +39 0584 962313http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
–
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
On Thu, Oct 20, 2011 at 7:58 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
Yeah it is not to pull hears in Chrome and Firefox, but IE (6) sucks.
Actually it sucks a lot more on the un-styled buttons too. Don’t have other browsers to test with though.
Are we still supporting IE6? I understand later versions, but six…
Rollie: do you think the UI buttons could/should be homogenized too? (afaik we only have styled buttons mirroring the save/cancel links in case you need to use a button instead of a link?).
Not sure what the issue is here, could you please explain it to me?
—R
On Thu, Oct 20, 2011 at 5:26 PM, Rolando Peñate <rpenate@anonymised.com> wrote:
On Thu, Oct 20, 2011 at 7:58 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
Yeah it is not to pull hears in Chrome and Firefox, but IE (6) sucks.
Actually it sucks a lot more on the un-styled buttons too. Don’t have other browsers to test with though.Are we still supporting IE6? I understand later versions, but six…
I think not, just thought buttons/unstyled text fields would look equally weird on newer IE versions. Might be wrong, don’t have any newer version to try.
Rollie: do you think the UI buttons could/should be homogenized too? (afaik we only have styled buttons mirroring the save/cancel links in case you need to use a button instead of a link?).
Not sure what the issue is here, could you please explain it to me?
Not really an issue but a question. We have a bunch of buttons in the UI for which (it looks to me) we don’t apply any styling. Should we?
G.
—R
–
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
On Thu, Oct 20, 2011 at 8:29 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
On Thu, Oct 20, 2011 at 5:26 PM, Rolando Peñate <rpenate@anonymised.com> wrote:
On Thu, Oct 20, 2011 at 7:58 PM, Gabriel Roldan <groldan@anonymised.com> wrote:
Rollie: do you think the UI buttons could/should be homogenized too? (afaik we only have styled buttons mirroring the save/cancel links in case you need to use a button instead of a link?).
Not sure what the issue is here, could you please explain it to me?
Not really an issue but a question. We have a bunch of buttons in the UI for which (it looks to me) we don’t apply any styling. Should we?
Well, styling forms is tricky because there is no consistent way to do it across browsers. Firefox/Gecko does a decent job but IE and Safari use OS chrome and don’t let you style much of anything. Are you talking about making links look like buttons? I find that to be nice and friendly but the link-based buttons end up not looking the same as the input buttons.
In general, I’d avoid this as much as possible beyond setting a border/background on text fields or textual inputs.
Does that answer help?
—R
Not really an issue but a question. We have a bunch of buttons in the UI for which (it looks to me) we don't apply any styling. Should we?
Well, styling forms is tricky because there is no consistent way to do it across browsers. Firefox/Gecko does a decent job but IE and Safari use OS chrome and don't let you style much of anything. Are you talking about making links look like buttons? I find that to be nice and friendly but the link-based buttons end up not looking the same as the input buttons.
In general, I'd avoid this as much as possible beyond setting a border/background on text fields or textual inputs.
Does that answer help?
yup, thanks.
—R
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.