[Geoserver-devel] SLD XDO

Jody,

Other than being DOM based instead of SAX based, why dont you like the
SLD parser?

I havent found any problems with it (when you give it proper input) and
I wrote a SLD schema validator so you dont make any mistakes.

I assume that it uses the SAX parser to parse <Filter>.

(basically I don't think I can do a decent theme based editor without
better SLD support)

Its not like you're going to get more functionality moving to XDO!

I'm thinking about making some changes to the Geotools SLD .xsd - is
that easy to do in XDO or do you have to start from scratch?

dave

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/

Quoting dblasby@anonymised.com:

Jody,

Other than being DOM based instead of SAX based, why dont you like
the
SLD parser?

I havent found any problems with it (when you give it proper input)
and
I wrote a SLD schema validator so you dont make any mistakes.

Hrm. One of my biggest beefs with it is awful error reporting. Though
I suppose if you put your validator in the request code then it would
be better. Did you do that for the GET stuff in GetMap requests? When
users include SLD or use a remote SLD? That would be helpful indeed.

I assume that it uses the SAX parser to parse <Filter>.

No, this is my other big problem with it. It uses a different
(crappier, less tested) filter parser, a DOM one. This has been a big
thorn in my side, as I constantly had to fix bugs with it. It probably
works decently now, but it's still quite lame that we use different
filter parsers. I suppose you could change it to use SAX, but it'd be
weird. You'd probably have to do it at a higher level, and parse
through the document twice, once with DOM and once with SAX...

>(basically I don't think I can do a decent theme based editor
without
>better SLD support)

Its not like you're going to get more functionality moving to XDO!

I'm thinking about making some changes to the Geotools SLD .xsd - is
that easy to do in XDO or do you have to start from scratch?

dave

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/

-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/

dblasby@anonymised.com wrote:

Jody,

Other than being DOM based instead of SAX based, why dont you like the
SLD parser?
I havent found any problems with it (when you give it proper input) and
I wrote a SLD schema validator so you dont make any mistakes.

It could be that my experience is colored by our weeks of bug fixes. It could be that both udig and
geoserver use has rendered it capable. It was more a question of what you want to do long term.

I assume that it uses the SAX parser to parse <Filter>.

We cannot intergrate it with anything is the problem. It is hard for us to "switch over" in the middle of
parsing a GetMap request to the SLD parser. Degree supports the inline addition of GML in the middle
of a GetMap request - so the abilty to use the right parser for the job (mid stream) is kind of important.

Aka this is a long term issue :slight_smile:

(basically I don't think I can do a decent theme based editor without
better SLD support)
   

Its not like you're going to get more functionality moving to XDO!

True, see above comments about testing. But yeah we can keep on with DOM for a udig
1.0 if needed.

I'm thinking about making some changes to the Geotools SLD .xsd - is
that easy to do in XDO or do you have to start from scratch?

Changing the xsd (that sounds standard :slight_smile: ), the answer really comes down to dzwiers again. In the first three itterations the process was not smooth. In his latest round he was going to/has switch things around so write place *just* the parsing code. And the structure representing the schema is parsed directly from the xsd file.

But yeah, lets talk to dzwiers. Or stick with DOM until someone trys to do WMS Post.
Jody