[Geoserver-devel] Small change to wcs11 javacc config

Hi all,

Recently I switched to IntelliJ for my IDE. I have to say it is has been nice, the maven integration is great, and it handles both GeoTools and GeoServer pretty smoothly. There is however one hitch on the GeoServer side that results in the wcs1_1 module.

The way the javacc plugin is configured is that it creates two generated source directories:

target/generated-sources/jjtree
target/generated-sources/javacc

The problem is that the the same class sources end up in both directories. Intellij picks them both up and complains during compilation. Now I can manually remove the jjtree directory but this becomes painful pretty fast because every time i re-import due to a maven pom change it wipes away my settings.

So, I was hoping to make a small change so that the jjtree directory doesn’t end up under target/generated-sources. Here is the patch:

https://gist.github.com/jdeolive/7cc0fa4cbdeeb208568e

As I understand the jjtree sources are simply an intermediary step. I did a build with tests locally and the change doesn’t seem to have any ill effect.

-Justin

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

Since there was no objection I went ahead and committed this on master.

···

On Thu, Jun 12, 2014 at 5:15 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Hi all,

Recently I switched to IntelliJ for my IDE. I have to say it is has been nice, the maven integration is great, and it handles both GeoTools and GeoServer pretty smoothly. There is however one hitch on the GeoServer side that results in the wcs1_1 module.

The way the javacc plugin is configured is that it creates two generated source directories:

target/generated-sources/jjtree
target/generated-sources/javacc

The problem is that the the same class sources end up in both directories. Intellij picks them both up and complains during compilation. Now I can manually remove the jjtree directory but this becomes painful pretty fast because every time i re-import due to a maven pom change it wipes away my settings.

So, I was hoping to make a small change so that the jjtree directory doesn’t end up under target/generated-sources. Here is the patch:

https://gist.github.com/jdeolive/7cc0fa4cbdeeb208568e

As I understand the jjtree sources are simply an intermediary step. I did a build with tests locally and the change doesn’t seem to have any ill effect.

-Justin

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

Justin Deoliveira
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive

On Fri, Jun 20, 2014 at 3:05 PM, Justin Deoliveira <
jdeolive@anonymised.com> wrote:

Since there was no objection I went ahead and committed this on master.

Sorry, totally missed your mail
No objection indeed, looks good

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Fri, Jun 13, 2014 at 1:15 AM, Justin Deoliveira <
jdeolive@anonymised.com> wrote:

Hi all,

Recently I switched to IntelliJ for my IDE. I have to say it is has been
nice, the maven integration is great, and it handles both GeoTools and
GeoServer pretty smoothly.

Btw, did IntelliJ learn to compile as one codes like Eclipse? Last time I
checked it was running the build on
demand and was taking a lot of time to launch tests or start GeoServer.

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Fri, Jun 20, 2014 at 2:11 PM, Andrea Aime <andrea.aime@anonymised.com>
wrote:

On Fri, Jun 13, 2014 at 1:15 AM, Justin Deoliveira <
jdeolive@anonymised.com> wrote:

Hi all,

Recently I switched to IntelliJ for my IDE. I have to say it is has been
nice, the maven integration is great, and it handles both GeoTools and
GeoServer pretty smoothly.

Btw, did IntelliJ learn to compile as one codes like Eclipse? Last time I
checked it was running the build on
demand and was taking a lot of time to launch tests or start GeoServer.

Yeah, there is an option to turn that on. I actually don't use it though

and have got used to running builds manually. I find it's pretty good about
only rebuilding what needs to be rebuilt.

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

--
*Justin Deoliveira*
Vice President, Engineering | Boundless
jdeolive@anonymised.com
@j_deolive <https://twitter.com/j_deolive&gt;