Please join me smoke testing 2.8.1 release artifacts:
http://ares.boundlessgeo.com/geoserver/release/2.8.1
See also:
http://ares.boundlessgeo.com/jenkins/view/release/job/geoserver-release/90/consoleText
https://osgeo-org.atlassian.net/projects/GEOS/versions/11500
https://osgeo-org.atlassian.net/jira/secure/ReleaseNote.jspa?projectId=10000&version=11500
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Hi,
Geoserver 2.8.1 seems to be OK on Windows. However, there is perhaps something wrong with the NetCDF plugin which I downloaded from
http://netcologne.dl.sourceforge.net/project/geoserve/GeoServer/2.8.1/extensions/geoserver-2.8.1-netcdf-out-plugin.zip
The plugin prevents startup, snippet of the startup log:
Caused by: org.springframework.beans.TypeMismatchException: Failed to convert pr
operty value of type 'java.lang.String' to required type 'java.lang.Class' for p
roperty 'factoryClass'; nested exception is java.lang.IllegalArgumentException:
Cannot find class [org.geotools.coverage.io.netcdf.NetCDFFormat]
-Jukka Rahkonen-
________________________________________
Ben Caradoc-Davies wrote:
Please join me smoke testing 2.8.1 release artifacts:
http://ares.boundlessgeo.com/geoserver/release/2.8.1
See also:
http://ares.boundlessgeo.com/jenkins/view/release/job/geoserver-release/90/consoleText
https://osgeo-org.atlassian.net/projects/GEOS/versions/11500
https://osgeo-org.atlassian.net/jira/secure/ReleaseNote.jspa?projectId=10000&version=11500
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
Confirmed (although I see different classes fail, likely classpath order). The netcdf-out plugin appears to require gt-coverage-api-14.1.jar and gt-netcdf-14.1.jar which are not included in geoserver-2.8.1-netcdf-out-plugin.zip but can be found in geoserver-2.8.1-netcdf-plugin.zip. Perhaps it was assumed that netcdf-out would be installed alongside the netcdf plugin? Looks like a bug to me.
Kind regards,
Ben.
On 21/11/15 02:04, Rahkonen Jukka (MML) wrote:
Hi,
Geoserver 2.8.1 seems to be OK on Windows. However, there is perhaps something wrong with the NetCDF plugin which I downloaded from
http://netcologne.dl.sourceforge.net/project/geoserve/GeoServer/2.8.1/extensions/geoserver-2.8.1-netcdf-out-plugin.zipThe plugin prevents startup, snippet of the startup log:
Caused by: org.springframework.beans.TypeMismatchException: Failed to convert pr
operty value of type 'java.lang.String' to required type 'java.lang.Class' for p
roperty 'factoryClass'; nested exception is java.lang.IllegalArgumentException:
Cannot find class [org.geotools.coverage.io.netcdf.NetCDFFormat]-Jukka Rahkonen-
________________________________________
Ben Caradoc-Davies wrote:Please join me smoke testing 2.8.1 release artifacts:
http://ares.boundlessgeo.com/geoserver/release/2.8.1See also:
http://ares.boundlessgeo.com/jenkins/view/release/job/geoserver-release/90/consoleText
https://osgeo-org.atlassian.net/projects/GEOS/versions/11500
https://osgeo-org.atlassian.net/jira/secure/ReleaseNote.jspa?projectId=10000&version=11500Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Hi Ben,
yeah, normally those that want NetCDF output also have it has the input: it’s a format for a very specific niche, people
normally want it in first, and eventually out too.
Regardless, one could have a multidimensional mosaic of tiffs, and use NetCDF output for whatever reason,
so I’d say we should indeed change the assembly descriptors.
What about we open a ticket to solve it, and make a note in the release annoucement that for now, in order
to use the NetCDF output, one also needs to install the NetCDF reader module?
Cheers
Andrea
On Fri, Nov 20, 2015 at 7:24 PM, Ben Caradoc-Davies <ben@anonymised.com> wrote:
Confirmed (although I see different classes fail, likely classpath
order). The netcdf-out plugin appears to require
gt-coverage-api-14.1.jar and gt-netcdf-14.1.jar which are not included
in geoserver-2.8.1-netcdf-out-plugin.zip but can be found in
geoserver-2.8.1-netcdf-plugin.zip. Perhaps it was assumed that
netcdf-out would be installed alongside the netcdf plugin? Looks like a
bug to me.Kind regards,
Ben.On 21/11/15 02:04, Rahkonen Jukka (MML) wrote:
Hi,
Geoserver 2.8.1 seems to be OK on Windows. However, there is perhaps something wrong with the NetCDF plugin which I downloaded from
http://netcologne.dl.sourceforge.net/project/geoserve/GeoServer/2.8.1/extensions/geoserver-2.8.1-netcdf-out-plugin.zipThe plugin prevents startup, snippet of the startup log:
Caused by: org.springframework.beans.TypeMismatchException: Failed to convert pr
operty value of type ‘java.lang.String’ to required type ‘java.lang.Class’ for p
roperty ‘factoryClass’; nested exception is java.lang.IllegalArgumentException:
Cannot find class [org.geotools.coverage.io.netcdf.NetCDFFormat]-Jukka Rahkonen-
Ben Caradoc-Davies wrote:
Please join me smoke testing 2.8.1 release artifacts:
http://ares.boundlessgeo.com/geoserver/release/2.8.1See also:
http://ares.boundlessgeo.com/jenkins/view/release/job/geoserver-release/90/consoleText
https://osgeo-org.atlassian.net/projects/GEOS/versions/11500
https://osgeo-org.atlassian.net/jira/secure/ReleaseNote.jspa?projectId=10000&version=11500Kind regards,
–
Ben Caradoc-Davies <ben@anonymised.com.>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel–
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
A bug report is needed. I will file one.
I do not want to complicate the release announcement and establish the misconception that netcdf-plugin is required to use netcdf-out-plugin.
Any objection to me manually adding the two missing jars to the netcdf-out-plugin and uploading it to sourceforge?
Kind regards,
Ben.
On 21/11/15 07:37, Andrea Aime wrote:
Hi Ben,
yeah, normally those that want NetCDF output also have it has the input:
it's a format for a very specific niche, people
normally want it in first, and eventually out too.Regardless, one could have a multidimensional mosaic of tiffs, and use
NetCDF output for whatever reason,
so I'd say we should indeed change the assembly descriptors.What about we open a ticket to solve it, and make a note in the release
annoucement that for now, in order
to use the NetCDF output, one also needs to install the NetCDF reader
module?Cheers
AndreaOn Fri, Nov 20, 2015 at 7:24 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:Confirmed (although I see different classes fail, likely classpath
order). The netcdf-out plugin appears to require
gt-coverage-api-14.1.jar and gt-netcdf-14.1.jar which are not included
in geoserver-2.8.1-netcdf-out-plugin.zip but can be found in
geoserver-2.8.1-netcdf-plugin.zip. Perhaps it was assumed that
netcdf-out would be installed alongside the netcdf plugin? Looks like a
bug to me.Kind regards,
Ben.On 21/11/15 02:04, Rahkonen Jukka (MML) wrote:
Hi,
Geoserver 2.8.1 seems to be OK on Windows. However, there is perhaps
something wrong with the NetCDF plugin which I downloaded from
The plugin prevents startup, snippet of the startup log:
Caused by: org.springframework.beans.TypeMismatchException: Failed to
convert pr
operty value of type 'java.lang.String' to required type
'java.lang.Class' for p
roperty 'factoryClass'; nested exception is
java.lang.IllegalArgumentException:
Cannot find class [org.geotools.coverage.io.netcdf.NetCDFFormat]
-Jukka Rahkonen-
________________________________________
Ben Caradoc-Davies wrote:Please join me smoke testing 2.8.1 release artifacts:
http://ares.boundlessgeo.com/geoserver/release/2.8.1See also:
http://ares.boundlessgeo.com/jenkins/view/release/job/geoserver-release/90/consoleText
https://osgeo-org.atlassian.net/projects/GEOS/versions/11500
https://osgeo-org.atlassian.net/jira/secure/ReleaseNote.jspa?projectId=10000&version=11500
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand------------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
On Fri, Nov 20, 2015 at 8:01 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:
A bug report is needed. I will file one.
I do not want to complicate the release announcement and establish the
misconception that netcdf-plugin is required to use netcdf-out-plugin.Any objection to me manually adding the two missing jars to the
netcdf-out-plugin and uploading it to sourceforge?
None from me
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
On 21/11/15 08:02, Andrea Aime wrote:
On Fri, Nov 20, 2015 at 8:01 PM, Ben Caradoc-Davies <ben@anonymised.com>
Any objection to me manually adding the two missing jars to the
netcdf-out-plugin and uploading it to sourceforge?None from me
Done.
Jukka, please try the updated plugin and see if it works for you:
http://sourceforge.net/projects/geoserver/files/GeoServer/2.8.1/extensions/geoserver-2.8.1-netcdf-out-plugin.zip/download
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
On 21/11/15 08:01, Ben Caradoc-Davies wrote:
A bug report is needed. I will file one.
https://osgeo-org.atlassian.net/browse/GEOS-7325
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Geoserver 2.8.1 starts with the updated plugin. I have no idea if the plugin itself works, I was just adding plugins one by one and tested if startup was still successful. If I knew what to do with NetCDF output I would probably installed the input module first and never captured this issue, just like the developers 
-Jukka-
________________________________________
Ben Caradoc-Davies wrote:
On 21/11/15 08:02, Andrea Aime wrote:
On Fri, Nov 20, 2015 at 8:01 PM, Ben Caradoc-Davies <ben@anonymised.com>
Any objection to me manually adding the two missing jars to the
netcdf-out-plugin and uploading it to sourceforge?None from me
Done.
Jukka, please try the updated plugin and see if it works for you:
http://sourceforge.net/projects/geoserver/files/GeoServer/2.8.1/extensions/geoserver-2.8.1-netcdf-out-plugin.zip/download
Kind regards,
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
Thanks very much, Jukka. I am pleased by your thorough testing.
It almost seems worth automating this process to catch missing jars as this has happened before. For each plugin, unpack the bin.zip, install the plugin, and try to start geoserver. A Jenkins parameterised build, perhaps?
Kind regards,
Ben.
On 21/11/15 08:29, Rahkonen Jukka (MML) wrote:
Geoserver 2.8.1 starts with the updated plugin. I have no idea if the plugin itself works, I was just adding plugins one by one and tested if startup was still successful. If I knew what to do with NetCDF output I would probably installed the input module first and never captured this issue, just like the developers
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand
On Fri, Nov 20, 2015 at 8:35 PM, Ben Caradoc-Davies <ben@anonymised.com>
wrote:
Thanks very much, Jukka. I am pleased by your thorough testing.
It almost seems worth automating this process to catch missing jars as
this has happened before. For each plugin, unpack the bin.zip, install the
plugin, and try to start geoserver. A Jenkins parameterised build, perhaps?
Hum... one by one is one thing, other issues can raise out of combinations
but... to go there it would mean testing
a lot of possible combinations (if we do the power set, 38! is an awfully
large number) , with a startup for each one.
But yeah, if we have someone willing to setup that build, it would help
catch some issues, like missing jars,
that tend to happen when we promote new modules to extension
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
I believe that testing plugins one by one would reveal the missing jars and then installing them all together some bad interactions. But would such interactions normally prevent startup? Perhaps scanning if plugins have different versions of the same jars could prevent more problems.
-Jukka Rahkonen-
Andrea Aime wrote:
On Fri, Nov 20, 2015 at 8:35 PM, Ben Caradoc-Davies <ben@anonymised.com> wrote:
Thanks very much, Jukka. I am pleased by your thorough testing.
It almost seems worth automating this process to catch missing jars as this has happened before. For each plugin, unpack the bin.zip, install the plugin, and try to start geoserver. A Jenkins parameterised build, perhaps?
Hum… one by one is one thing, other issues can raise out of combinations but… to go there it would mean testing
a lot of possible combinations (if we do the power set, 38! is an awfully large number) , with a startup for each one.
But yeah, if we have someone willing to setup that build, it would help catch some issues, like missing jars,
that tend to happen when we promote new modules to extension
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
On Fri, Nov 20, 2015 at 9:49 PM, Rahkonen Jukka (MML) <
jukka.rahkonen@anonymised.com> wrote:
I believe that testing plugins one by one would reveal the missing jars
and then installing them all together some bad interactions.
Yep, you have a point, once we have it going, we just need to throw
everything in to catch regressions. Just 39 startups then 
But would such interactions normally prevent startup?
Maybe, maybe not.
Perhaps scanning if plugins have different versions of the same jars could
prevent more problems.
That's another good idea. Theoretically we should manage versions in the
global dependency management section
of the main pom, but plugins graduating from community often have their
local ones
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------