[Geoserver-devel] Something bizzarre about the importer: proposed import context ids and advancement

GeoServer GeoServer Developer
1

Hi,
working on the JDBC status store I stumbled into something I was not aware of, and that seems really odd.
Apparently a client can propose a import context id, and the system will respond back with a context having
such id, or if busy, an id that is higher:

https://docs.geoserver.org/latest/en/user/extensions/importer/rest_reference.html#import-object

The justification is that “allows an external system to dictate the id management”.

However I don’t see why it has to be that way, or what usefulness it has… as long as import ids are unique,
everything should be fine, and maybe the external system can propose an identifier, and the importer
could use it if free, discard and propose another if busy (at the client risk of stumbling into an existing import
and updating it though…).
But why force the ids to be a sequence that always goes up?

Is there any actual system using this functionality, or was it just an oddity due to some initial development
constraints? I’d rather drop it… but I guess I can also just ignore it in the JDBC store implementation, and document the deviation.

Cheers
Andrea

···

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.

2

Hey, I don’t know about that provided id, seems odd really, I’d say drop it or ignore it.

Thinking out loud, have you considered using spring batch for this? It provides an RDBMS JobRepository out of the box and in general I think it’d be nice to use it instead of cooking our own job/task management code.

···

Gabriel Roldán

3

Oh, just tasked to get a working system already using the importer to a state where multiple nodes can run imports in parallel (that is,
increase the system data ingestion scalability). The new community module is already in, check the sources.

However, that should not stop you from experimenting and eventually propose a refactor, if the subject interests you.
I think Alessio used some bits from Spring Batch in the backup/restore module.

Cheers
Andrea

···

GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail.