[Geoserver-devel] Spaces in custom dimension values

Hi all,
I’m trying to build a mosaic using a custom domain which contains spaces.

The result in the getCapabilities is:

Cropvalue,Yield

Should be:


Crop value,Yield

I’ll provide a simple pull req for this.
Cheers,
Carlo

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
mobile: +39 3371094494
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Fri, Oct 11, 2013 at 6:51 PM, carlo cancellieri <
carlo.cancellieri@anonymised.com> wrote:

Hi all,
I'm trying to build a mosaic using a custom domain which contains spaces.

The result in the getCapabilities is:
....
<Dimension name="MEASURE"
default="Crop value"
units="">Cropvalue,Yield</Dimension>
...

Should be:
....
<Dimension name="MEASURE"
default="Crop value"
units="">Crop value,Yield</Dimension>
...

As long as the spaces are within the value I don't foresee problems, by a
quick read of the spec,
you'd only have troubles if you have spaces at the beginning or end of the
value, where they should
be ignored (e.g., " myvalue " would be actually interpreted as "myvalue")

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Andrea,
thanks for replies.
Here is the pull req for spaces within dimensions:
https://github.com/geoserver/geoserver/pull/361

Cheers,
Carlo

···

2013/10/11 Andrea Aime <andrea.aime@anonymised.com>

On Fri, Oct 11, 2013 at 6:51 PM, carlo cancellieri <carlo.cancellieri@anonymised.com> wrote:

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
mobile: +39 3371094494
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


Hi all,
I’m trying to build a mosaic using a custom domain which contains spaces.

The result in the getCapabilities is:

Cropvalue,Yield

Should be:


Crop value,Yield

As long as the spaces are within the value I don’t foresee problems, by a quick read of the spec,
you’d only have troubles if you have spaces at the beginning or end of the value, where they should
be ignored (e.g., " myvalue " would be actually interpreted as “myvalue”)

Cheers
Andrea

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Tue, Oct 15, 2013 at 11:27 AM, carlo cancellieri <
carlo.cancellieri@anonymised.com> wrote:

Andrea,
thanks for replies.
Here is the pull req for spaces within dimensions:
https://github.com/geoserver/geoserver/pull/361

I believe we should still drop spaces at the begin and end of the string
using trim.
Opinions?

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Andrea

I believe we should still drop spaces at the begin and end of the string

using trim.
Opinions?

right, updated with trim.

Carlo

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
mobile: +39 3371094494
fax: +39 0584 1660272

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Build stalled…

https://travis-ci.org/geoserver/geoserver/jobs/12561504


<details class='elided'>
<summary title='Show trimmed content'>&#183;&#183;&#183;</summary>

2013/10/15 carlo cancellieri <[carlo.cancellieri@anonymised.com](mailto:carlo.cancellieri@anonymised.com)>

> 

--

==
Our support, Your Success! Visit [http://opensdi.geo-solutions.it](http://opensdi.geo-solutions.it) for more information.
==

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
mobile: +39 3371094494
fax: +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it/)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------

Andrea

> 

right, updated with trim.

Carlo

--

==
Our support, Your Success! Visit [http://opensdi.geo-solutions.it](http://opensdi.geo-solutions.it) for more information.
==

Dott. Carlo Cancellieri
@cancellieric
Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313

mobile: +39 3371094494
fax: +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it/)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------

I believe we should still drop spaces at the begin and end of the string using trim.
Opinions?

</details>

On Tue, Oct 15, 2013 at 2:15 PM, carlo cancellieri <
carlo.cancellieri@anonymised.com> wrote:

Build stalled....
https://travis-ci.org/geoserver/geoserver/jobs/12561504

Eh, Travis is giving up a very nice service by building the pull requests,
but the build itself over the is not that
stable... long story short, when a build fails, it might be unrelated to
the pull request...

I'm going to try fetching and building the pull request locally.

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------