Hi,
as reported in http://jira.codehaus.org/browse/GEOS-4421 the current automatic
filter integration with the spring context is causing trouble in security land,
making it impossible to disable spring security, causing potential
ordering issues
in the filter execution and doubling up the security filters work.
What about having SpringDelegatingFilter look for a specific marker interface
for filters that we wish to be integrated, instead of just picking any Filter?
Something like:
/**
* Interface implemented by filters that want to be plugged into the
* web request processing by simple declaration into the Spring context
*/
interface GeoServePluginFilter extends Filter {
}
Cheers
Andrea
--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 333 8128928
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-------------------------------------------------------
Sounds like a good plan to me. Any filters that relied on the old behaviour will of course have to be updated… off the top of my head there should be one in dbconfig, and two in monitoring. One of the filters is a straight hibernate OpenSessionInViewFilter so we’ll have to subclass it but that should not be an issue. I can update those modules after the fact or take a crack at a patch. Just let me know.
-Justin
On Mon, Mar 14, 2011 at 3:27 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
Hi,
as reported in http://jira.codehaus.org/browse/GEOS-4421 the current automatic
filter integration with the spring context is causing trouble in security land,
making it impossible to disable spring security, causing potential
ordering issues
in the filter execution and doubling up the security filters work.
What about having SpringDelegatingFilter look for a specific marker interface
for filters that we wish to be integrated, instead of just picking any Filter?
Something like:
/**
- Interface implemented by filters that want to be plugged into the
- web request processing by simple declaration into the Spring context
*/
interface GeoServePluginFilter extends Filter {
}
Cheers
Andrea
–
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 333 8128928
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
Colocation vs. Managed Hosting
A question and answer guide to determining the best fit
for your organization - today and in the future.
http://p.sf.net/sfu/internap-sfd2d
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
On Mon, Mar 14, 2011 at 2:17 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:
Sounds like a good plan to me. Any filters that relied on the old behaviour
will of course have to be updated.. off the top of my head there should be
one in dbconfig, and two in monitoring. One of the filters is a straight
hibernate OpenSessionInViewFilter so we'll have to subclass it but that
should not be an issue. I can update those modules after the fact or take a
crack at a patch. Just let me know.
Going to have a look at the other cite tests. I think I can take care
of this one,
leaving you free to work on the wfs gml namespace thing if you like to 
Cheers
Andrea
--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 333 8128928
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-------------------------------------------------------
On Mon, Mar 14, 2011 at 6:25 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
On Mon, Mar 14, 2011 at 2:17 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:
Sounds like a good plan to me. Any filters that relied on the old behaviour
will of course have to be updated… off the top of my head there should be
one in dbconfig, and two in monitoring. One of the filters is a straight
hibernate OpenSessionInViewFilter so we’ll have to subclass it but that
should not be an issue. I can update those modules after the fact or take a
crack at a patch. Just let me know.
Going to have a look at the other cite tests. I think I can take care
of this one,
leaving you free to work on the wfs gml namespace thing if you like to
Sure thing. Although I probably won’t get to it until end of day.
Cheers
Andrea
–
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 333 8128928
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
On Mon, Mar 14, 2011 at 2:52 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:
On Mon, Mar 14, 2011 at 6:25 AM, Andrea Aime <andrea.aime@anonymised.com>
wrote:
On Mon, Mar 14, 2011 at 2:17 PM, Justin Deoliveira <jdeolive@anonymised.com>
wrote:
> Sounds like a good plan to me. Any filters that relied on the old
> behaviour
> will of course have to be updated.. off the top of my head there should
> be
> one in dbconfig, and two in monitoring. One of the filters is a straight
> hibernate OpenSessionInViewFilter so we'll have to subclass it but that
> should not be an issue. I can update those modules after the fact or
> take a
> crack at a patch. Just let me know.
Going to have a look at the other cite tests. I think I can take care
of this one,
leaving you free to work on the wfs gml namespace thing if you like to
Sure thing. Although I probably won't get to it until end of day.
That would be perfect
Cheers
Andrea
--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 962313
mob: +39 333 8128928
http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf
-------------------------------------------------------