[Geoserver-devel] Strange behavior with the GeoServer REST

Hi all,
something doesn’t look right with GeoServer REST.

First the GWC end-points seem to be indexed and prefixed with EST ? Not sure what EST stands for:

  • est
  • est/diskquota
  • est/layers
  • est/masstruncate
  • est/seed.json
  • est/statistics
    Then when accessing the other REST end-points or I get a NPE, a 404 error or I get the correct result
    this seems be a bit random … and I can’t see why this is happening.

Is anyone else experiencing this ?

Regards,

Nuno Oliveira

···
-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Hi Nuno,
I can confirm at least for the GWC endpoints that there are issues. I’m currently working on Swagger docs for those endpoints and they should look like:

~/geoserver/

  • gwc/rest
  • gwc/rest/diskquota
  • gwc/rest/layers
  • gwc/rest/masstruncate
  • gwc/rest/seed.json
  • gwc/rest/statistics
    As for the other endpoints I’m unsure of at the moment.

John

···

On Thu, Sep 28, 2017 at 11:16 AM, Nuno Oliveira <nuno.oliveira@anonymised.com> wrote:

Hi all,
something doesn’t look right with GeoServer REST.

First the GWC end-points seem to be indexed and prefixed with EST ? Not sure what EST stands for:

  • est
  • est/diskquota
  • est/layers
  • est/masstruncate
  • est/seed.json
  • est/statistics
    Then when accessing the other REST end-points or I get a NPE, a 404 error or I get the correct result
    this seems be a bit random … and I can’t see why this is happening.

Is anyone else experiencing this ?

Regards,

Nuno Oliveira

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Found the issue. Definately a bug in IndexController - it just blindly trims off the first four characters (normally “rest”) of the path when constructing the index.
I don’t think the original rest index included the gwc endpoints - is this something we want to have included?

Torben

···

On Thu, Sep 28, 2017 at 3:18 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Hi Nuno,

What GeoServer version are you seeing this behavior on? master, 2.12-beta, 2.12-RC1, something else?

I would guess that ‘est’ is ‘rest’ missing the ‘r’, but that definitely seems wrong.

Testing it out on 2.12-beta, I see the same behavior looking at the index page. If I click on any of the ‘est’ links I get a 404 though, and the expected links work fine. So, this looks like a bug in how the index page handles the new GeoWebCache rest links.

Torben

On Thu, Sep 28, 2017 at 9:16 AM, Nuno Oliveira <nuno.oliveira@anonymised.comit> wrote:

Hi all,
something doesn’t look right with GeoServer REST.

First the GWC end-points seem to be indexed and prefixed with EST ? Not sure what EST stands for:

  • est
  • est/diskquota
  • est/layers
  • est/masstruncate
  • est/seed.json
  • est/statistics
    Then when accessing the other REST end-points or I get a NPE, a 404 error or I get the correct result
    this seems be a bit random … and I can’t see why this is happening.

Is anyone else experiencing this ?

Regards,

Nuno Oliveira

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

I’ve got a simple fix for the GeoWebCache issue here: https://github.com/geoserver/geoserver/pull/2547
In the interests of a prompt release, I’ve just excluded the geowebcache endpoints (which is the same way the old index page worked).

And I’ve made a bug report for it here: https://osgeo-org.atlassian.net/browse/GEOS-8308

Torben

···

On Thu, Sep 28, 2017 at 2:49 PM, John Schulz <jschulz@anonymised.com.3839…> wrote:

Hi Nuno,
I can confirm at least for the GWC endpoints that there are issues. I’m currently working on Swagger docs for those endpoints and they should look like:

~/geoserver/

  • gwc/rest
  • gwc/rest/diskquota
  • gwc/rest/layers
  • gwc/rest/masstruncate
  • gwc/rest/seed.json
  • gwc/rest/statistics
    As for the other endpoints I’m unsure of at the moment.

John


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

On Thu, Sep 28, 2017 at 11:16 AM, Nuno Oliveira <nuno.oliveira@anonymised.comit> wrote:

Hi all,
something doesn’t look right with GeoServer REST.

First the GWC end-points seem to be indexed and prefixed with EST ? Not sure what EST stands for:

  • est
  • est/diskquota
  • est/layers
  • est/masstruncate
  • est/seed.json
  • est/statistics
    Then when accessing the other REST end-points or I get a NPE, a 404 error or I get the correct result
    this seems be a bit random … and I can’t see why this is happening.

Is anyone else experiencing this ?

Regards,

Nuno Oliveira

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

I suppose it depends on whether we want to consider the GWC REST API a subset of the GeoServer REST API, or a separate API within the application.

Given it’s /gwc/rest rather than /rest/gwc it seems to make more sense to keep them separate.

···

On 2017-09-28 03:25 PM, Torben Barsballe wrote:

Found the issue. Definately a bug in IndexController - it just blindly trims off the first four characters (normally “rest”) of the path when constructing the index.
I don’t think the original rest index included the gwc endpoints - is this something we want to have included?

Torben

On Thu, Sep 28, 2017 at 3:18 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

Hi Nuno,

What GeoServer version are you seeing this behavior on? master, 2.12-beta, 2.12-RC1, something else?

I would guess that ‘est’ is ‘rest’ missing the ‘r’, but that definitely seems wrong.

Testing it out on 2.12-beta, I see the same behavior looking at the index page. If I click on any of the ‘est’ links I get a 404 though, and the expected links work fine. So, this looks like a bug in how the index page handles the new GeoWebCache rest links.

Torben

On Thu, Sep 28, 2017 at 9:16 AM, Nuno Oliveira <nuno.oliveira@anonymised.comit> wrote:

Hi all,
something doesn’t look right with GeoServer REST.

First the GWC end-points seem to be indexed and prefixed with EST ? Not sure what EST stands for:

  • est
  • est/diskquota
  • est/layers
  • est/masstruncate
  • est/seed.json
  • est/statistics
    Then when accessing the other REST end-points or I get a NPE, a 404 error or I get the correct result
    this seems be a bit random … and I can’t see why this is happening.

Is anyone else experiencing this ?

Regards,

Nuno Oliveira

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! [http://sdm.link/slashdot](http://sdm.link/slashdot)
_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@lists.sourceforge.net](mailto:Geoserver-devel@anonymised.comsourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)

-- 
Kevin Michael Smith
[<smithkm@anonymised.com>](mailto:smithkm@anonymised.com)

On Fri, Sep 29, 2017 at 12:25 AM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

Found the issue. Definately a bug in IndexController - it just blindly
trims off the first four characters (normally "rest") of the path when
constructing the index.
I don't think the original rest index included the gwc endpoints - is this
something we want to have included?

Traditionally they were separated but I don't really see a good reason to,
it's nice to have all REST admin
endpoints in one place, part of the GWC proper integration story imho.
That said, it would be an improvement, I don't see it as a requirement or a
release blocker.

Cheers
Andrea

--

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

+1 (and thanks all for the feedback)

···

On 09/29/2017 07:15 AM, Andrea Aime wrote:

On Fri, Sep 29, 2017 at 12:25 AM, Torben Barsballe <tbarsballe@…3839…> wrote:

Found the issue. Definately a bug in IndexController - it just blindly trims off the first four characters (normally “rest”) of the path when constructing the index.
I don’t think the original rest index included the gwc endpoints - is this something we want to have included?

Traditionally they were separated but I don’t really see a good reason to, it’s nice to have all REST admin
endpoints in one place, part of the GWC proper integration story imho.
That said, it would be an improvement, I don’t see it as a requirement or a release blocker.

Cheers
Andrea

Regards,

Andrea Aime

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

I agree it shouldn’t be a release blocker. Since GeoServer and GWC have different rest entrypoints (/rest vs /gwc/rest), it might be an idea to have different sections for them in the index page. At the very least, a little thought should be put into presentation.

Torben

···

On Thu, Sep 28, 2017 at 11:15 PM, Andrea Aime <andrea.aime@anonymised.com…> wrote:

On Fri, Sep 29, 2017 at 12:25 AM, Torben Barsballe <tbarsballe@anonymised.com.> wrote:

Found the issue. Definately a bug in IndexController - it just blindly trims off the first four characters (normally “rest”) of the path when constructing the index.
I don’t think the original rest index included the gwc endpoints - is this something we want to have included?

Traditionally they were separated but I don’t really see a good reason to, it’s nice to have all REST admin
endpoints in one place, part of the GWC proper integration story imho.
That said, it would be an improvement, I don’t see it as a requirement or a release blocker.

Cheers
Andrea

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Hi all, wanted to throw my two cents in about the IndexController. The
IndexController currently builds the list of links from a private method
inside of the IndexController, which makes it impossible to extend,
override, or append to. Any logic or code that produces dynamic content
should really not be inside of a controller, as the controller should only
serve to define the interface or entry point to the code base. That being
said, I would recommend another service class (something like
RestIndexUrlService) that is responsible for building the links that get
generated for the REST index page.

The only endpoints currently displayed on the page are those discovered from
Spring MVC's RequestMappingHandlerMapping. It would be nice to provide an
interface such as "RestIndexUrlProvider" that defines a single method
"Set<String> getLinks();". The RestIndexUrlService could potentially call
"GeoServerExtensions.extension(RestIndexUlrProvider)" to get all objects
that implement the interface then aggregate all of the results in a new
Set<String> that gets returned to the index controller.
This would allow other extensions or plugins the ability to provide their
own endpoints to be displayed on the page without the need for them to be
implemented via Spring, without the odd possibility that they aren't in the
same web context as the IndexController itself, or to provide any other
customization that may be necessary.

The list of endpoints on the rest page have grown quite a bit. To take it
one step further, instead of providing Set of strings with urls, the page
could be updated to group related links under some sort of category, ie, GWC
endpoints would all appear under a GWC header element. In that case, the
RestIndexUrlProvider would define a Map<String, String> vs a Set, where the
key is the "title" and the value is the URL path.

None of this obviously is a release blocker, but it seems it would be a very
nice improvement and I just wanted to share my thoughts.

Cheers

Josh

--
Sent from: http://osgeo-org.1560.x6.nabble.com/GeoServer-Dev-f3819232.html