[Geoserver-devel] Style editor, zen mode, and looking for help on side by side editing

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

···

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Very nice work. Unfortunately I’m not quite skilled on frontend development, however I can volunteer some spare time if you need some help.

(attachments)

Selezione_187.png
image.png
Selezione_189.png
Selezione_188.png

···

2018-05-06 15:51 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Regards,

Alessio Fabiani

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

This looks quite helpful.

I’ve got some front-end experience - I’ll take a look at that branch and try and get something responsive working sometime this weekend.

Some initial thoughts/possibilities as to layout options:

  1. Fixed-width style editor with a variable width map.

  2. Style editor and map both take up half the width of the window.

  3. Style editor initialized to some starting width, with a draggable divider between it and the map. This might be tricky to get working with Wicket.
    Cheers,

Torben

(attachments)




···

On Mon, May 7, 2018 at 12:46 AM, Alessio Fabiani <alessio.fabiani@anonymised.com> wrote:

Very nice work. Unfortunately I’m not quite skilled on frontend development, however I can volunteer some spare time if you need some help.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Regards,

Alessio Fabiani

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

2018-05-06 15:51 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Hi Alessio,
any help with can get is welcomed!

Cheers
Andrea

(attachments)

Selezione_187.png
Selezione_188.png
Selezione_189.png
image.png

···

On Mon, May 7, 2018 at 9:46 AM, Alessio Fabiani <alessio.fabiani@anonymised.com> wrote:

Very nice work. Unfortunately I’m not quite skilled on frontend development, however I can volunteer some spare time if you need some help.

Regards,

Alessio Fabiani

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Alessio Fabiani

@alfa7691
Founder/Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 331 6233686

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

2018-05-06 15:51 GMT+02:00 Andrea Aime <andrea.aime@anonymised.com>:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

On Mon, May 7, 2018 at 6:06 PM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:

This looks quite helpful.

I've got some front-end experience - I'll take a look at that branch and
try and get something responsive working sometime this weekend.

That would be awesome!! It's probably obvious to you, but just in case, so
far all the "magic" is done by flipping on and off a class in a container,
and have sub-styles react to that and alter layout, the only bit of
javascript is the one flipping the class.

Some initial thoughts/possibilities as to layout options:

   1. Fixed-width style editor with a variable width map.
   2. Style editor and map both take up half the width of the window.
   3. Style editor initialized to some starting width, with a draggable
   divider between it and the map. This might be tricky to get working with
   Wicket.

Yes, number 3 would be the ideal, but I understand it could be tricky

indeed. :slight_smile:

Cheers
Andrea

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

Hi Andrea,

This is really a good improvement, thank you !!!

I will also have a look, to see where I can help.

(attachments)

Selezione_187.png
Selezione_188.png
Selezione_189.png
image.png

···

On 05/06/2018 02:51 PM, Andrea Aime wrote:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! [http://sdm.link/slashdot](http://sdm.link/slashdot)
_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@lists.sourceforge.net](mailto:Geoserver-devel@lists.sourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

I’ve got some semblance of a responsive fullscreen mode here: https://github.com/tbarsballe/geoserver/tree/style_editor_side_by_side

Code Mirror editor and Layer preview now expand to fit the screen hight (minimum 300px).

If you resize the screen manually, they should update.
If the Layer Preview tab is not initially visible, it should be updated when selected.

I disabled the editor resize drop-down when in fullscreen mode since it automatically resizes instead.

There is a bit of tuning here and there that could still be done, mainly with regards to alignment of components.

Please try it out, and see what you think.

Cheers,

Torben

(attachments)




···

On Tue, May 8, 2018 at 2:29 AM, Nuno Oliveira <nuno.oliveira@anonymised.com> wrote:

Hi Andrea,

This is really a good improvement, thank you !!!

I will also have a look, to see where I can help.

On 05/06/2018 02:51 PM, Andrea Aime wrote:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! [http://sdm.link/slashdot](http://sdm.link/slashdot)
_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@anonymised.com.366...sourceforge.net](mailto:Geoserver-devel@lists.sourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Hi Torben,
played with it a bit, looks awesome to me:

I’d give it the green light, clean up the commits, and merge.
Anyone else wants to improve it further?

Cheers
Andrea

(attachments)

Selezione_188.png
image.png
Selezione_187.png
Selezione_189.png

···

On Sat, May 12, 2018 at 9:36 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

I’ve got some semblance of a responsive fullscreen mode here: https://github.com/tbarsballe/geoserver/tree/style_editor_side_by_side

Code Mirror editor and Layer preview now expand to fit the screen hight (minimum 300px).

If you resize the screen manually, they should update.
If the Layer Preview tab is not initially visible, it should be updated when selected.

I disabled the editor resize drop-down when in fullscreen mode since it automatically resizes instead.

There is a bit of tuning here and there that could still be done, mainly with regards to alignment of components.

Please try it out, and see what you think.

Cheers,

Torben

On Tue, May 8, 2018 at 2:29 AM, Nuno Oliveira <nuno.oliveira@anonymised.comit> wrote:

Hi Andrea,

This is really a good improvement, thank you !!!

I will also have a look, to see where I can help.

On 05/06/2018 02:51 PM, Andrea Aime wrote:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! [http://sdm.link/slashdot](http://sdm.link/slashdot)
_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@anonymised.comrge.net](mailto:Geoserver-devel@lists.sourceforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
Via di Montramito 3/A
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Squashed some commits, opened a PR with my changes here: https://github.com/geoserver/geoserver/pull/2867

Torben

(attachments)





···

On Sat, May 12, 2018 at 7:56 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi Torben,
played with it a bit, looks awesome to me:

I’d give it the green light, clean up the commits, and merge.
Anyone else wants to improve it further?

Cheers
Andrea

On Sat, May 12, 2018 at 9:36 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:

I’ve got some semblance of a responsive fullscreen mode here: https://github.com/tbarsballe/geoserver/tree/style_editor_side_by_side

Code Mirror editor and Layer preview now expand to fit the screen hight (minimum 300px).

If you resize the screen manually, they should update.
If the Layer Preview tab is not initially visible, it should be updated when selected.

I disabled the editor resize drop-down when in fullscreen mode since it automatically resizes instead.

There is a bit of tuning here and there that could still be done, mainly with regards to alignment of components.

Please try it out, and see what you think.

Cheers,

Torben

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

On Tue, May 8, 2018 at 2:29 AM, Nuno Oliveira <nuno.oliveira@anonymised.comt> wrote:

Hi Andrea,

This is really a good improvement, thank you !!!

I will also have a look, to see where I can help.

On 05/06/2018 02:51 PM, Andrea Aime wrote:

Hi,
in the last few months I’ve tried, very much on and off (hack 2 hours, rest 2 months), to improve the style editor page, in order to get
more space for the editor itself.
I’ve come to a point were I can probably commit what I have, and getting close a significant improvement that I have troubles finishing myself.

Going in order, the first set of changes I’ve made is to reduce need-less vertical space usage, here is a side by side comparison of
the style editor before the change, on a server that has the latest nightly, along with some extra plugins, so excuse the different menu entries,
and after the change, on my local machine:

Small improvement, but enough to make the whole thing fill the screen in its default state. However, if you check the UI, you’ll see there is a new “height” drop down on top of the style
editor, and a tempting “arrows-out” icon on the top right. What happens if one clicks that icon, and then increases the height of the editor? This, “full screen” editing with less distractions,
aka “zen mode” (this is all you see in the browser, I did not cut away anything):

As you can see, the editor has been pumped up from 300px to 550px, or almost twice as big.
The “arrows-out” becomes “arrows-in”, clicking it you can return to the previous state.

These changes can be found in this pull request, I invite you to comment, review, improve it:
https://github.com/geoserver/geoserver/pull/2867

Now, the above form factor helps with a side by side comparison, but screens nowadays are large and
doing the same on a large one results in wasted space, it’s not a mistake that common style editors
done by HTML/CSS/JS pros have a different layout, a “side by side” one.
Can we do the same? Turns out, with a modern browser one can get there using the “flex” layout
mode, however, I’m not good enough with HTML/CSS/JS to get from prototype to something actually useful.
Here is what I have so far:

and the branch:
https://github.com/aaime/geoserver/tree/style_editor_side_by_side

To make it usable, imho, some more responsive design would be needed, where the editor and the map
automatically resize to fill the available space. A sub-par solution that would still be acceptable, imho,
could be to add a height dropdown to the map editor… having to click on two dropdowns to adapt
the page to the screen would be clunky but… better than nothing?
Bonus points for a draggable vertical separator allowing to adjust the relative width of editor and map.

However, as said, I’m having difficulties making that happen. Sorry, I’m an almost pure server side dev,
getting no occasions to work on the client side, even if I’d like to.
So… wondering, is there any good soul with the right client side skills that could bring this second part of
the work to completion? :slight_smile:

Cheers
Andrea

== GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via di Montramito 3/A 55054 Massarosa (LU) phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! [http://sdm.link/slashdot](http://sdm.link/slashdot)
_______________________________________________
Geoserver-devel mailing list
[Geoserver-devel@anonymised.comrge.net](mailto:Geoserver-devel@anonymised.comeforge.net)
[https://lists.sourceforge.net/lists/listinfo/geoserver-devel](https://lists.sourceforge.net/lists/listinfo/geoserver-devel)

-- 
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit [http://goo.gl/it488V](http://goo.gl/it488V) for more information.
==

Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer

GeoSolutions S.A.S.
[Via di Montramito 3/A](https://maps.google.com/?q=Via+di+Montramito+3/A+%0D%0A+55054+%C2%A0Massarosa&entry=gmail&source=g)
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax:      +39 0584 1660272

[http://www.geo-solutions.it](http://www.geo-solutions.it)
[http://twitter.com/geosolutions_it](http://twitter.com/geosolutions_it)

-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
 
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility  for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot


Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel