While fixing GEOS-8080, I have discovered a change in the behaviour of Style GET introduced by the REST API Refresh.
Assume we have a GeoServer configuration as follows:
foo is the default workspace
There is a style named bar in foo
There is a style named baz in foo
There is also a global style named baz
In GeoServer <= 2.11:
GET /rest/styles/bar returns 404.
GET /rest/styles/baz returns the workspaced baz style (This is the GEOS-8080 bug).
GET /rest/workspaces/styles/bar returns the bar style.
GET /rest/workspaces/styles/baz returns the workspaced baz style.
In GeoServer >= 2.12:
GET /rest/styles/bar returns returns the bar style (This is the behavioral change).
GET /rest/styles/baz returns the workspaced baz style (This is the GEOS-8080 bug).
GET /rest/workspaces/styles/bar returns the bar style.
GET /rest/workspaces/styles/baz returns the workspaced baz style.
I think we should probably revert 2.12 to the previous behaviour of returning 404 when requesting a style that only exists in a workspace from the /rest/styles endpoint.
Does anyone have a good reason why the new behaviour should be preserved?
Torben
Hi Torben,
I agree the behavior should be matching 1-1 the request, when one requests a global style,
it’s either an existing global style, or 404
Cheers
Andrea
···
On Mon, May 29, 2017 at 6:55 PM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
While fixing GEOS-8080, I have discovered a change in the behaviour of Style GET introduced by the REST API Refresh.
Assume we have a GeoServer configuration as follows:
foo is the default workspace
There is a style named bar in foo
There is a style named baz in foo
There is also a global style named baz
In GeoServer <= 2.11:
GET /rest/styles/bar returns 404.
GET /rest/styles/baz returns the workspaced baz style (This is the GEOS-8080 bug).
GET /rest/workspaces/styles/bar returns the bar style.
GET /rest/workspaces/styles/baz returns the workspaced baz style.
In GeoServer >= 2.12:
GET /rest/styles/bar returns returns the bar style (This is the behavioral change).
GET /rest/styles/baz returns the workspaced baz style (This is the GEOS-8080 bug).
GET /rest/workspaces/styles/bar returns the bar style.
GET /rest/workspaces/styles/baz returns the workspaced baz style.
I think we should probably revert 2.12 to the previous behaviour of returning 404 when requesting a style that only exists in a workspace from the /rest/styles endpoint.
Does anyone have a good reason why the new behaviour should be preserved?
Torben
Check out the vibrant tech community on one of the world’s most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.