Hi to everybody,
one of our clients signalled a bug on the GetLegendGraphic rendering of symbols/icons.
Currently all symbols are sized independently of the requested icon size, so if we have to render a big symbol/icon it is clipped so that it is rendered inside the requested box.
I would like to propose a patch (on master) to resolve the bug, doing this:
- scan all requested Style for symbols/icons and accumulate the max rendered size of them all
- use the accumulated size to scale all symbols/icons during rendering to this max size, to mantain symbols proportion
Is this ok for you? Can I proceed to create the patch?
Thanks.
–
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
An image to explain better the problem. On the left side the current behaviour, on the right the desidered one.
Sounds like a nice improvement to me.
(attachments)
···
On Wed, Jan 16, 2013 at 6:22 AM, Mauro Bartolomeoli <mauro.bartolomeoli@anonymised.com> wrote:
An image to explain better the problem. On the left side the current behaviour, on the right the desidered one.
![Immagine in linea 1]()
–
Dott. Mauro Bartolomeoli
@mauro_bart
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only – learn more at:
http://p.sf.net/sfu/learnmore_122612
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
On Wed, Jan 16, 2013 at 4:29 PM, David Winslow <dwinslow@anonymised.com> wrote:
Sounds like a nice improvement to me.
With large marks, it’s a bug fix more than an improvement, if the icons
are significantly larger than the 20x20 box used to paint them the legend
graphics we get now is just useless.
See for example the _Concept rule, who would have guessed that thing
looking like a red fill is actually a round mark 
?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it