Hi,
chiming in with my own point of view on the matter.
Yes, I agree that mixed tabs are a significant nuisance, some parts of the code are quite messy because of that (although I’d normally
be more concerned about GeoTools than GeoServer in terms of tabs).
Personally I am not against the change, provided it’s applied on all active branches to avoid making bug fix backports harder than strictly necessary.
Justin raises a fair point about this making it harder to merge code from outside, but I’m not sure I agree with the conclusion.
Jira wise, I’ve been telling people that we do not accept patches anymore for at least a couple of years.
Now, we still have some, and it’s not easy to locate all of them, I’ve tried here by checking that the word “patch” is in the
ticket and that we have an attachment, unfortunately this also matches tickets having an attachment and in which we ask
for a patch:
https://osgeo-org.atlassian.net/issues/?jql=project%20%3D%20GEOS%20AND%20status%20%3D%20Open%20AND%20text%20~%20patch%20AND%20NOT%20attachments%20is%20EMPTY%20ORDER%20BY%20created%20DESC
That said… nobody is applying this patches anyways so… should we be concerned about them? Most of them do
not apply anyways of how old they are. If we had a champion that would process them and turn them into
pull request, well, that would be amazing of course 
In general, I’d ask if people with significant work in progress could have a look at the tabs pull request and report if they are going
to be affected in a significant way. Raise of hands please, are we going to make your life hell by merging this patch?
In the end I believe we should be concerned about stuff that is due to get merged soon-ish, our code changes fast, keeping up
a long lived branch is like running after a train that would never stop regardless.
Cheers
Andrea
···
On Sat, May 14, 2016 at 12:42 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Moving the discussion for https://github.com/geoserver/geoserver/pull/1598 to the mailing lists.
This is a non-functional change that has the potential to cause merge conflicts in some percentage of the currently open pull requests.
This change has been discussed in the past, but has generally been considered too much of a hassle.
A change of this magnitude will likely always be a hassle to deal with, so we might as well do it eventually. Given that we recently branched of 2.9.x, we are in a relatively good position to do this now. Unfortunately, there are also a lot (23) of Pull Requests open against GeoServer right now, which makes this a less attractive change at this point.
Torben
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.