[Geoserver-devel] Test fail on latest from git

GeoServer GeoServer Developer
1

Hi all,

I am trying to "maven clean build" geoserver in my new Netbeans 7.3
IDE. The build for the Main Module fails on one test. Is this common
and can anybody tell me what needs to be done to make the failed test
pass? Do I need a running geoserver for instance?

Results :

Failed tests: testInactive(org.geoserver.security.GeoServerCustomFilterTest)

Tests run: 513, Failures: 1, Errors: 0, Skipped: 1

------------------------------------------------------------------------
Reactor Summary:

GeoServer ......................................... SUCCESS [0.226s]
Open Web Service Module ........................... SUCCESS [2.807s]
Main Module ....................................... FAILURE [50.436s]
Web Feature Service Module ........................ SKIPPED
Web Coverage Service Module ....................... SKIPPED
Web Map Service Module ............................ SKIPPED
GeoServer Web Modules ............................. SKIPPED
Core UI Module .................................... SKIPPED
Security UI Module ................................ SKIPPED
GeoServer Security Modules ........................ SKIPPED
GeoServer JDBC Security Module .................... SKIPPED
GeoServer LDAP Security Module .................... SKIPPED
Web Coverage Service 1.0 Module ................... SKIPPED
Web Coverage Service 1.1 Module ................... SKIPPED
Web Map Service KML output formats ................ SKIPPED
GeoWebCache (GWC) Module .......................... SKIPPED
REST Support Module ............................... SKIPPED
REST Configuration Service Module ................. SKIPPED
WMS UI Module ..................................... SKIPPED
GWC UI Module ..................................... SKIPPED
WFS UI Module ..................................... SKIPPED
Demoes Module ..................................... SKIPPED
WCS UI Module ..................................... SKIPPED
GeoServer Web Application ......................... SKIPPED
Community Space ................................... SKIPPED
GeoServer Extensions .............................. SKIPPED
------------------------------------------------------------------------
BUILD FAILURE
------------------------------------------------------------------------

2

On Sat, Mar 9, 2013 at 11:24 PM, Milo van der Linden <milo@anonymised.com> wrote:

Hi all,

I am trying to “maven clean build” geoserver in my new Netbeans 7.3
IDE. The build for the Main Module fails on one test. Is this common
and can anybody tell me what needs to be done to make the failed test
pass? Do I need a running geoserver for instance?

No, that’s not the case, you just need to throw Netbeans away and use
Eclipse instead :-p
Kidding! (well, almost)

Seriously, the problem is there and we had hints during the last few months.
I’m trying to propose a solution to it here (sent the message yesterday):
http://osgeo-org.1560.n6.nabble.com/Test-execution-order-random-or-fixed-td5039357.html

The issue has been lurking around since we did the testing subsystem
overhaul, but it was not easy to see because most active contributors
have a pretty uniform developer environment: *nix (Linux or OSX),
JDK 6 and Eclipse (and so does the official build server).

In the past months I’ve tried to setup a OpenJDK 7 build server on a spare
notebook I have at home, and a Windows build server here:
http://office.geo-solutions.it/jenkins

Both enviroments were building at some point, but eventually they broke
because nobody has to check if the software builds there too.
I know Simone has a working build on Windows, but that’s happening
only on his machine, on the build server it does not…

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

3

Thanks Andrea for the response!

It took me a while (mentally) to remove all openjdk dependencies from
my archlinux development PC and replace them by the (evil) Oracle jdk.
But once I got used to having evil stuff on my development PC, I
decided netbeans would be good too as it fits the whole Oracle "chain"

I upgraded my main pom to junit 4.11 and applied the fixes stated in
https://github.com/aaime/geoserver/commit/0452891ffbbe0d157d54fc5e0ade7dcdbb29c4cf

I am currently doing a clean build and it seems the build is already
processing further, past main.

I will digg into test issues poppin' up and try to fix stuff myself. I
will report my progress once I get a full build without declaring a
fixed build sequence because that would be, in my opinion, the best
alternative.

Thanks again for getting me on track. I love the way geoserver is
structured. I love the deep and solid junit integration. I love the
clean and well documented code! And I hope that I will one day be able
to contribute something usefull to this beautiful project.

Cheers,

Milo

2013/3/10 Andrea Aime <andrea.aime@anonymised.com>:

On Sat, Mar 9, 2013 at 11:24 PM, Milo van der Linden <milo@anonymised.com>
wrote:

Hi all,

I am trying to "maven clean build" geoserver in my new Netbeans 7.3
IDE. The build for the Main Module fails on one test. Is this common
and can anybody tell me what needs to be done to make the failed test
pass? Do I need a running geoserver for instance?

No, that's not the case, you just need to throw Netbeans away and use
Eclipse instead :-p
Kidding! (well, almost)

Seriously, the problem is there and we had hints during the last few months.
I'm trying to propose a solution to it here (sent the message yesterday):
http://osgeo-org.1560.n6.nabble.com/Test-execution-order-random-or-fixed-td5039357.html

The issue has been lurking around since we did the testing subsystem
overhaul, but it was not easy to see because most active contributors
have a pretty uniform developer environment: *nix (Linux or OSX),
JDK 6 and Eclipse (and so does the official build server).

In the past months I've tried to setup a OpenJDK 7 build server on a spare
notebook I have at home, and a Windows build server here:
http://office.geo-solutions.it/jenkins

Both enviroments were building at some point, but eventually they broke
because nobody has to check if the software builds there too.
I know Simone has a working build on Windows, but that's happening
only on his machine, on the build server it does not....

Cheers
Andrea

--

Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

4

On Sun, Mar 10, 2013 at 1:18 PM, Milo van der Linden <milo@anonymised.com> wrote:

Thanks Andrea for the response!

It took me a while (mentally) to remove all openjdk dependencies from
my archlinux development PC and replace them by the (evil) Oracle jdk.
But once I got used to having evil stuff on my development PC, I
decided netbeans would be good too as it fits the whole Oracle “chain”

I upgraded my main pom to junit 4.11 and applied the fixes stated in
https://github.com/aaime/geoserver/commit/0452891ffbbe0d157d54fc5e0ade7dcdbb29c4cf

I am currently doing a clean build and it seems the build is already
processing further, past main.

I will digg into test issues poppin’ up and try to fix stuff myself. I
will report my progress once I get a full build without declaring a
fixed build sequence because that would be, in my opinion, the best
alternative.

Once you upgrade to junit 4.11 you get 90% of the fixed order anyways,
the way it works it guarantees fixed execution order of the test methods.
Dependencies between test classes might be there due to system
variable setups, but that should be a rare occurrence.

Thanks again for getting me on track. I love the way geoserver is
structured. I love the deep and solid junit integration. I love the
clean and well documented code! And I hope that I will one day be able
to contribute something usefull to this beautiful project.

Thanks :slight_smile:

Cheers
Andrea

–

==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it