Hi all,
Recently failures in hudson in the restconfig module are happening due to a failure to resolve an online DTD reference when the code calls GeoServerAbstractTestSupport.getAsDOM(). I notice there is a version of getAsDOM() which takes a boolean, and no DTD look ups will occur.
Now, i could change every call in the restconfig tests which call getAsDOM(...), to call getAsDOM(...,true). But that would be a lot of updates :). I am wondering if we can just change teh behaviour of getAsDOM(...) to call getAsDOM(...,true), rather than getAsDOM(...,false).
Making this change to GeoServerAbstractTestSupport, and running all the tests again causes no failures. But I wanted to run it by you too. If there is a problem I can just update all the restconfig tests.
-Justin
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
Justin Deoliveira ha scritto:
Hi all,
Recently failures in hudson in the restconfig module are happening due to a failure to resolve an online DTD reference when the code calls GeoServerAbstractTestSupport.getAsDOM(). I notice there is a version of getAsDOM() which takes a boolean, and no DTD look ups will occur.
Now, i could change every call in the restconfig tests which call getAsDOM(...), to call getAsDOM(...,true). But that would be a lot of updates :). I am wondering if we can just change teh behaviour of getAsDOM(...) to call getAsDOM(...,true), rather than getAsDOM(...,false).
Making this change to GeoServerAbstractTestSupport, and running all the tests again causes no failures. But I wanted to run it by you too. If there is a problem I can just update all the restconfig tests.
I don't think there will be any problem. I guess in the few cases
where you need dtd validation you'll be simply able to call the get
getAsDom(..., true) explicitly.
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.