Going through the dev guide pull requests, there is commentary that was not resolved before the work was merged.
Checkout out https://github.com/geoserver/geoserver/pull/1135 shows the idea of only supporting pull requests (and taking the language about patches).
I am kind of good with that, the section is awkward to read, and it is very seldom we get patches attached to a jira ( unless the fix is so small they just provide it in a comment).
–
Jody Garnett
On Fri, Jul 10, 2015 at 11:14 PM, Jody Garnett <jody.garnett@anonymised.com>
wrote:
Going through the dev guide pull requests, there is commentary that was
not resolved before the work was merged.Checkout out https://github.com/geoserver/geoserver/pull/1135 shows the
idea of only supporting pull requests (and taking the language about
patches).I am kind of good with that, the section is awkward to read, and it is
very seldom we get patches attached to a jira ( unless the fix is so small
they just provide it in a comment).
+1 of course, as I'm the one that suggested it
Not sure if others are eager to take on patches instead, there are a few I
could point to in Jira if you are interested
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
+1.
While we do not want to discourage contributors, patch handling is just too expensive. If there are any contributors who can only send patches, we can handle those cases as an exception. The guide should direct contributors to submit pull requests, as that is our strong preference.
On 12/07/15 00:59, Andrea Aime wrote:
+1 of course, as I'm the one that suggested it
Not sure if others are eager to take on patches instead, there are a few I
could point to in Jira if you are interested
--
Ben Caradoc-Davies <ben@anonymised.com>
Director
Transient Software Limited <http://transient.nz/>
New Zealand