Hi,
I'm seeing two build failures on trunk, and Hudson sees
the same. Both have to do with GeoserverDataDirectory not
being properly configured when the application context is refreshed
in the two failing tests.
Which reminds me of the issues you had some days ago, Justin...
the build can be fixed by removing the loader lazy init in
GeoServerDataDirectory.init, that is, removing "if(loader == null)",
since apparently the loader in the app context is no more the
one used by the data dir after a refresh (and thus it does not
get properly initialized).
I still haven't committed thought, would like to know your opinion.
With the above change my build works fine. Patch attached.
Cheers
Andrea
(attachments)
datadir.patch (930 Bytes)
Hi Andrea,
I actually had these two tests commented out in my local checkout. But yes, the issue is with the refreshing of the application context. Rather than messing with the GeoServerDataDirectory method how would you feel about disabling these two tests for now, while I look for a better way to achieve the same test?
Andrea Aime wrote:
Hi,
I'm seeing two build failures on trunk, and Hudson sees
the same. Both have to do with GeoserverDataDirectory not
being properly configured when the application context is refreshed
in the two failing tests.
Which reminds me of the issues you had some days ago, Justin...
the build can be fixed by removing the loader lazy init in
GeoServerDataDirectory.init, that is, removing "if(loader == null)",
since apparently the loader in the app context is no more the
one used by the data dir after a refresh (and thus it does not
get properly initialized).
I still haven't committed thought, would like to know your opinion.
With the above change my build works fine. Patch attached.
Cheers
Andrea
!DSPAM:4007,483d852238481030819293!
------------------------------------------------------------------------
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
!DSPAM:4007,483d852238481030819293!
------------------------------------------------------------------------
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
!DSPAM:4007,483d852238481030819293!
--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com
Justin Deoliveira ha scritto:
Hi Andrea,
I actually had these two tests commented out in my local checkout. But yes, the issue is with the refreshing of the application context. Rather than messing with the GeoServerDataDirectory method how would you feel about disabling these two tests for now, while I look for a better way to achieve the same test?
I'm ok with both options. If you do disable them, please create a jira
issue scheduled for 1.7.0 so that we don't forget to re-enable them
before releasing the stable.
Cheers
Andrea