[Geoserver-devel] Time and elevation support for vectors ready

GeoServer GeoServer Developer
1

Hi,
following up the time and elevation GSIP I've cooked up a patch
that will add time and elevation support for vector data:
http://jira.codehaus.org/secure/attachment/55474/GEOS-3754_vector.patch
It's still missing raster support, but that is coming as well.

The patch adds support for time and elevation in the GUI, WMS 1.1 and 1.3,
both for capabilities, GetMap and GetFeatureInfo.
I've attached two examples of time/elevation config in the GUI to this mail.

Is anybody interested in reviewing the patch, or do you just want me
to commit it?

Let me know :slight_smile:

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

(attachments)

Selezione_083.png
Selezione_082.png

2

I’m not familiar enough with the core to offer theoretical review, so all I can offer is that there’s a type in testTimeContinouos’ method name. This looks awesome and I want to play with it, so I vote for commit!

On Wed, Jun 8, 2011 at 8:26 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
following up the time and elevation GSIP I’ve cooked up a patch
that will add time and elevation support for vector data:
http://jira.codehaus.org/secure/attachment/55474/GEOS-3754_vector.patch
It’s still missing raster support, but that is coming as well.

The patch adds support for time and elevation in the GUI, WMS 1.1 and 1.3,
both for capabilities, GetMap and GetFeatureInfo.
I’ve attached two examples of time/elevation config in the GUI to this mail.

Is anybody interested in reviewing the patch, or do you just want me
to commit it?

Let me know :slight_smile:

Cheers
Andrea

–

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

EditLive Enterprise is the world’s most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Shane StClair
Software Engineer
Axiom Consulting & Design
523 W 8th Ave
Suite 104
Anchorage, AK 99501
http://www.axiomalaska.com

3

ahem Sorry, got excited. I will, of course, apply the patch and experiment…

On Wed, Jun 8, 2011 at 10:36 AM, Shane StClair <shane@…2677…> wrote:

I’m not familiar enough with the core to offer theoretical review, so all I can offer is that there’s a type in testTimeContinouos’ method name. This looks awesome and I want to play with it, so I vote for commit!

On Wed, Jun 8, 2011 at 8:26 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
following up the time and elevation GSIP I’ve cooked up a patch
that will add time and elevation support for vector data:
http://jira.codehaus.org/secure/attachment/55474/GEOS-3754_vector.patch
It’s still missing raster support, but that is coming as well.

The patch adds support for time and elevation in the GUI, WMS 1.1 and 1.3,
both for capabilities, GetMap and GetFeatureInfo.
I’ve attached two examples of time/elevation config in the GUI to this mail.

Is anybody interested in reviewing the patch, or do you just want me
to commit it?

Let me know :slight_smile:

Cheers
Andrea

–

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

EditLive Enterprise is the world’s most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev

Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Shane StClair
Software Engineer
Axiom Consulting & Design
523 W 8th Ave
Suite 104
Anchorage, AK 99501
http://www.axiomalaska.com

–
Shane StClair
Software Engineer
Axiom Consulting & Design
523 W 8th Ave
Suite 104
Anchorage, AK 99501
http://www.axiomalaska.com

4

Took a quick look over the patch, great work. Mostly additions, nice and clean. Did find a few minor things though:

  • a few changes to the data directory, some in wfs, a couple in wcs setting max memory settings 0, not sure if that is intended or not* a few of the added files (like DimensionInfo for instance) are missing copyright headers

Also I notice a dependency is added on gt-temporal. All those classes recently got transferred into main and the gt-temporal module is gone as part of the recent temporal filter support proposal in geotools

Great stuff.

On Wed, Jun 8, 2011 at 12:26 PM, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
following up the time and elevation GSIP I’ve cooked up a patch
that will add time and elevation support for vector data:
http://jira.codehaus.org/secure/attachment/55474/GEOS-3754_vector.patch
It’s still missing raster support, but that is coming as well.

The patch adds support for time and elevation in the GUI, WMS 1.1 and 1.3,
both for capabilities, GetMap and GetFeatureInfo.
I’ve attached two examples of time/elevation config in the GUI to this mail.

Is anybody interested in reviewing the patch, or do you just want me
to commit it?

Let me know :slight_smile:

Cheers
Andrea

–

Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

EditLive Enterprise is the world’s most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev

Geoserver-devel mailing list
Geoserver-devel@anonymised.comsts.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

–
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

5

same here Andrea, patch looks neat.

and just for the sake of adding something:
- beware most (c) headers mention 2001-2007 or 2001-2010. We should as
general practice set the current year when creating a new file
- beware of the formatting, tabs are being used instead of spaces in
some places (WMS. getTimeElevationToFilter at least)
- I'm not sure why WMS. getAvailableMapResponses looks up
RenderedImageMapResponse instead of AbstractMapResponse?
- it would be amazing if time attribute property was an expression,
even if for the time being we only support PropertyName. If added in
the future the way it's serialized now would be consistent with (E)CQL
so as you mentioned previously we could just use that.

And I think someone contributed a Filter to CQL filter visitor some
time ago... but I can't find it anywhere

Cheers,
Gabriel

On Wed, Jun 8, 2011 at 10:09 PM, Justin Deoliveira <jdeolive@anonymised.com> wrote:

Took a quick look over the patch, great work. Mostly additions, nice and
clean. Did find a few minor things though:
* a few changes to the data directory, some in wfs, a couple in wcs setting
max memory settings 0, not sure if that is intended or not
* a few of the added files (like DimensionInfo for instance) are missing
copyright headers
Also I notice a dependency is added on gt-temporal. All those classes
recently got transferred into main and the gt-temporal module is gone as
part of the recent temporal filter support proposal in geotools
Great stuff.
On Wed, Jun 8, 2011 at 12:26 PM, Andrea Aime <andrea.aime@anonymised.com>
wrote:

Hi,
following up the time and elevation GSIP I've cooked up a patch
that will add time and elevation support for vector data:
http://jira.codehaus.org/secure/attachment/55474/GEOS-3754_vector.patch
It's still missing raster support, but that is coming as well.

The patch adds support for time and elevation in the GUI, WMS 1.1 and 1.3,
both for capabilities, GetMap and GetFeatureInfo.
I've attached two examples of time/elevation config in the GUI to this
mail.

Is anybody interested in reviewing the patch, or do you just want me
to commit it?

Let me know :slight_smile:

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

6

On Thu, Jun 9, 2011 at 8:12 PM, Gabriel Roldan <groldan@anonymised.com> wrote:

same here Andrea, patch looks neat.

and just for the sake of adding something:
- beware most (c) headers mention 2001-2007 or 2001-2010. We should as
general practice set the current year when creating a new file

Do we need to mass update all headers?

- beware of the formatting, tabs are being used instead of spaces in
some places (WMS. getTimeElevationToFilter at least)

Whoops, sorry, I'll fix that.

- I'm not sure why WMS. getAvailableMapResponses looks up
RenderedImageMapResponse instead of AbstractMapResponse?

No particular reason, just still confused by the new WMS API.
Will fix it.

- it would be amazing if time attribute property was an expression,
even if for the time being we only support PropertyName. If added in
the future the way it's serialized now would be consistent with (E)CQL
so as you mentioned previously we could just use that.

I already answered this one during the proposal discussion, see that
thread for details.

If you have time to write a Filter to ECQL (because that's what we're
using today) and amend the code to use expressions that would be great.
To keep a user friendly GUI we also need a component that allows
to either choose an attribute or build an expression, a simple black text
field would be a regression (we have been asked for a friendly GUI).

I'd also like to see that in action, just don't have the funding to take
the workload that it would involve.
The first that finds time/resources to implement it wins :wink: (hum... actually,
everybody wins in that case).

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

7

On Thu, Jun 9, 2011 at 2:22 PM, Andrea Aime
<andrea.aime@anonymised.com> wrote:

On Thu, Jun 9, 2011 at 8:12 PM, Gabriel Roldan <groldan@anonymised.com> wrote:

same here Andrea, patch looks neat.

and just for the sake of adding something:
- beware most (c) headers mention 2001-2007 or 2001-2010. We should as
general practice set the current year when creating a new file

Do we need to mass update all headers?

I don't know if we need to. It just crossed my mind that if we would
be going OSGeo we'd have more trouble figuring out this kind of things

- beware of the formatting, tabs are being used instead of spaces in
some places (WMS. getTimeElevationToFilter at least)

Whoops, sorry, I'll fix that.

- I'm not sure why WMS. getAvailableMapResponses looks up
RenderedImageMapResponse instead of AbstractMapResponse?

No particular reason, just still confused by the new WMS API.
Will fix it.

- it would be amazing if time attribute property was an expression,
even if for the time being we only support PropertyName. If added in
the future the way it's serialized now would be consistent with (E)CQL
so as you mentioned previously we could just use that.

I already answered this one during the proposal discussion, see that
thread for details.

no need to, I have it in mind. Guess what I just wanted to say is that
in the eventual case that in the future we wanted to use expression it
wouldn't break as long as it's stored as an ECQL expression, as a
pealed attribute name makes for a valid ECQ expression?

any case, great work.
cheers,
Gabriel

If you have time to write a Filter to ECQL (because that's what we're
using today) and amend the code to use expressions that would be great.
To keep a user friendly GUI we also need a component that allows
to either choose an attribute or build an expression, a simple black text
field would be a regression (we have been asked for a friendly GUI).

I'd also like to see that in action, just don't have the funding to take
the workload that it would involve.
The first that finds time/resources to implement it wins :wink: (hum... actually,
everybody wins in that case).

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

8

If you have time to write a Filter to ECQL (because that's what we're
using today) and amend the code to use expressions that would be great.

btw, here's the one I mentioned, though hidden with package visibility
and not a single reference to it?
<http://www.opensourcejavaphp.net/java/geotools/org/geotools/filter/text/cql2/FilterToCQL.java.html&gt;

To keep a user friendly GUI we also need a component that allows
to either choose an attribute or build an expression, a simple black text
field would be a regression (we have been asked for a friendly GUI).

I'd also like to see that in action, just don't have the funding to take
the workload that it would involve.
The first that finds time/resources to implement it wins :wink: (hum... actually,
everybody wins in that case).

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.

9

On Thu, Jun 9, 2011 at 8:29 PM, Gabriel Roldan <groldan@anonymised.com> wrote:

I already answered this one during the proposal discussion, see that
thread for details.

no need to, I have it in mind. Guess what I just wanted to say is that
in the eventual case that in the future we wanted to use expression it
wouldn't break as long as it's stored as an ECQL expression, as a
pealed attribute name makes for a valid ECQ expression?

Aah, I see. The attribute name is stored as a string, so in that same spot
we could store any valid ECQL expression yes.
We'd have to update all the usage points, GUI to configure it,
capabitilies because we compute the list of values on the fly,
GetMap/GetFeature info to build the proper filters.

Cheers
Andrea

--
-------------------------------------------------------
Ing. Andrea Aime
GeoSolutions S.A.S.
Tech lead

Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy

phone: +39 0584 962313
fax: +39 0584 962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.youtube.com/user/GeoSolutionsIT
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-------------------------------------------------------