[Geoserver-devel] Troubles with ows4 architecture and GetLock spec

Hi Justin,
I'm having some trouble with the nice OWS4 architecture
and a detail with the GetLock spec that breaks it.

The GetLock spec in WFS 1.1 says that
"The lock timer should be started once the entire lock request has been processed and the lock response has been completely transmitted to the client." (btw, that's why there's that refresh locks in LockFeature, line 211, wfs2 module in ows4 branch).

Now, in OWS4 the architecture imposes a:
1) parse request
2) perform action
3) send response
sequence, which is problematic in the above case, because we should
reset expiry timers after the response is sent.

What shall we do? Ignore the spec, ask for a spec amendment?
The spec is way too picky in my opinion in this case, the expiry
is to be expressed in minutes and they do care about the second
you start your timers... c'mon...

Cheers
Andrea Aime

Hmm, interesting point. I think that it is a bit silly too, but if we
really want to solve this we can have the lock feature operation not
return an object and just inline the output stream so it can do the
response, then the refresh directly after, more or less like the old way.

However for now I wouldn't worry too much about it. Make a note of it. I
defy them to try and build a cite test that exercices this :slight_smile:

-Justin

Andrea Aime wrote:

Hi Justin,
I'm having some trouble with the nice OWS4 architecture
and a detail with the GetLock spec that breaks it.

The GetLock spec in WFS 1.1 says that
"The lock timer should be started once the entire lock request has been
processed and the lock response has been completely transmitted to the
client." (btw, that's why there's that refresh locks in LockFeature,
line 211, wfs2 module in ows4 branch).

Now, in OWS4 the architecture imposes a:
1) parse request
2) perform action
3) send response
sequence, which is problematic in the above case, because we should
reset expiry timers after the response is sent.

What shall we do? Ignore the spec, ask for a spec amendment?
The spec is way too picky in my opinion in this case, the expiry
is to be expressed in minutes and they do care about the second
you start your timers... c'mon...

Cheers
Andrea Aime

!DSPAM:1004,453e20d3284471804284693!

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com