[Geoserver-devel] Turkish translation files breaking UI

GeoServer GeoServer Developer
1

Hi,
we have had several reports lately on various mediums that the Turkish translation
is breaking the UI due to unbalanced curly braces in the translation file.
I can also find a few reports in Jira:
https://osgeo-org.atlassian.net/browse/GEOS-7915

https://osgeo-org.atlassian.net/browse/GEOS-6927

Now… I did look at the translation and I don’t quite see where the problem is (see GEOS-7915)
but it’s effectively breaking any UI page with a table in it.

If nobody can fix it, shall we remove the translation files?

Cheers
Andrea

···

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

2

It seems a shame to toss out an entire translation.

I have asked the origional reporter to look at https://www.transifex.com/GeoServer/geoserver/

Frank if you are available I would love to see an update for this page documenting how to use transifex.

···

–
Jody Garnett

On 7 February 2017 at 10:53, Andrea Aime <andrea.aime@anonymised.com> wrote:

Hi,
we have had several reports lately on various mediums that the Turkish translation
is breaking the UI due to unbalanced curly braces in the translation file.
I can also find a few reports in Jira:
https://osgeo-org.atlassian.net/browse/GEOS-7915

https://osgeo-org.atlassian.net/browse/GEOS-6927

Now… I did look at the translation and I don’t quite see where the problem is (see GEOS-7915)
but it’s effectively breaking any UI page with a table in it.

If nobody can fix it, shall we remove the translation files?

Cheers
Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Check out the vibrant tech community on one of the world’s most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot

Geoserver-devel mailing list
Geoserver-devel@anonymised.comrge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

3

On Wed, Feb 8, 2017 at 4:41 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

It seems a shame to toss out an entire translation.

I fully agree, but at the same time, having a fully non functional UI is
worse, better have a working
one in english.

So unless this gets solved before the 18th I'd still recommend to drop the
Turkish translation fully,
until a proper fix comes in.

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

4

I really wonder why an other language breaks UI if running in a different Language than Turkish.

In addtion the resources we are talking about are 2-3 years (https://github.com/geoserver/geoserver/blame/678d3b43d88887ae7905bc5a9fc5c0330f6a1c65/src/web/core/src/main/resources/GeoServerApplication_tr.properties#L725) in the codebase and we never had problems like that. I’m wondering about the github viewer, it looks like the ’ char works like a “multi-line” seperator that includes the following properties into the string, maybe its a problem and this char should be escaped

Inline-Bild 1

Another cause of problem could be that the resource isn’t really UTF-8 and once if packaged its gets broken. Maybe the latest changes on the file itself changed file encoding?

If I’ll have some time a going to have a look at it…

···

2017-02-08 8:27 GMT+01:00 Andrea Aime <andrea.aime@anonymised.com…>:

On Wed, Feb 8, 2017 at 4:41 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

It seems a shame to toss out an entire translation.

I fully agree, but at the same time, having a fully non functional UI is worse, better have a working
one in english.

So unless this gets solved before the 18th I’d still recommend to drop the Turkish translation fully,
until a proper fix comes in.

Cheers

Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

5

Hmm, got a bit confused about the output for ‘file GeoServerApplication_tr.properties’:

GeoServerApplication_tr.properties: ISO-8859 English text, with very long lines

Since the root-pom indicates that resosurces are UTF-8 (see https://github.com/geoserver/geoserver/blob/master/src/pom.xml#L1362) I’m wondering why the resources are ISO-8859 here

Wich is find on the other hand, because ISO 8859-11 is default encoding for java it should work with current properties files checked in at github.

Is there a chance behavior of wicked has changed (and since wicket update sprint) for resource handling?

For now it looks like resources are fine…

Another question to understand the problem: Why are the language settings necessary on the server side? IMHO the language displayed within the browser is provided by the browser itself - indpendently what is set on the server. If the browser is configured that way to use Turkish the resources are requested for Turkish and if not found the fallback shows English (read from GeoServerApplication.properties).

Any ideas or feedback about this?

(attachments)

grafik.png

···

2017-02-08 9:39 GMT+01:00 Frank Gasdorf <fgdrf@anonymised.com>:

I really wonder why an other language breaks UI if running in a different Language than Turkish.

In addtion the resources we are talking about are 2-3 years (https://github.com/geoserver/geoserver/blame/678d3b43d88887ae7905bc5a9fc5c0330f6a1c65/src/web/core/src/main/resources/GeoServerApplication_tr.properties#L725) in the codebase and we never had problems like that. I’m wondering about the github viewer, it looks like the ’ char works like a “multi-line” seperator that includes the following properties into the string, maybe its a problem and this char should be escaped

Inline-Bild 1

Another cause of problem could be that the resource isn’t really UTF-8 and once if packaged its gets broken. Maybe the latest changes on the file itself changed file encoding?

If I’ll have some time a going to have a look at it…

–

Frank

2017-02-08 8:27 GMT+01:00 Andrea Aime <andrea.aime@anonymised.com…1268…>:

On Wed, Feb 8, 2017 at 4:41 AM, Jody Garnett <jody.garnett@anonymised.com> wrote:

It seems a shame to toss out an entire translation.

I fully agree, but at the same time, having a fully non functional UI is worse, better have a working
one in english.

So unless this gets solved before the 18th I’d still recommend to drop the Turkish translation fully,
until a proper fix comes in.

Cheers

Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

6

On Thu, Feb 9, 2017 at 9:42 PM, Frank Gasdorf <fgdrf@anonymised.com>
wrote:

Hmm, got a bit confused about the output for 'file GeoServerApplication_tr.
properties':

GeoServerApplication_tr.properties: ISO-8859 English text, with very long
lines

Since the root-pom indicates that resosurces are UTF-8 (see
https://github.com/geoserver/geoserver/blob/master/src/pom.xml#L1362) I'm
wondering why the resources are ISO-8859 here

Wich is find on the other hand, because ISO 8859-11
<http://en.wikipedia.org/wiki/ISO/IEC_8859-1&gt; is default encoding for
java it should work with current properties files checked in at github.

There is no such a thing as a general default encoding for java:
http://stackoverflow.com/questions/1006276/what-is-the-default-encoding-of-the-jvm
On my system it is:

    public static void main(String args) {
        System.out.println("Locale: " + Locale.getDefault());
        System.out.println("File encoding:" +
System.getProperty("file.encoding"));
        System.out.println("Inpustream default encoding: " + new
InputStreamReader(new ByteArrayInputStream(new byte[0])).getEncoding());
    }

Locale: it_IT
File encoding:UTF-8
Inpustream default encoding: UTF8

Is there a chance behavior of wicked has changed (and since wicket update
sprint) for resource handling?

I don't think so.

For now it looks like resources are fine...

Another question to understand the problem: Why are the language settings
necessary on the server side? IMHO the language displayed within the
browser is provided by the browser itself - indpendently what is set on the
server.

Indeed that's how it works, there is no such a thing as a language setting
on the server. It would be nice to have a toggle in the UI, allowing people
to switch language if they
stumble is a poorly made or non functional translation.

If the browser is configured that way to use Turkish the resources are
requested for Turkish and if not found the fallback shows English (read
from GeoServerApplication.properties).

Right, but in this case the resource is found, and then it breaks during
parameter expansion. There is no "fallback to english" for that, by the
time the error happens the translation lookup path is long gone.

So today is release day, I'm going to have a quick look, if I cannot find
any way to locate and fix the issue I'll just remove the Turkish translation

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

7

On Mon, Feb 20, 2017 at 9:14 AM, Andrea Aime <andrea.aime@anonymised.com>
wrote:

Is there a chance behavior of wicked has changed (and since wicket update
sprint) for resource handling?

I don't think so.

So to confirm, https://osgeo-org.atlassian.net/browse/GEOS-6927 has been
opened against 2.6.2, so no Wicket
behavior changes, the translation has just been broken for a long time.

So today is release day, I'm going to have a quick look, if I cannot find
any way to locate and fix the issue I'll just remove the Turkish translation

Turns out I was looking at the wrong string, a different one is used in
case all matches appear in a single page, here is the fix, applied to all
active branches:

https://github.com/geoserver/geoserver/commit/bdb599e52e0dc214233d6cbd8b50110367dbbc7f

I guess it needs to be brought back to Transifex to avoid further
regressions?

I would be good to have some automated validation of these problems, but
I'm not too sure how to do it... maybe a test in the build that
uses regular expressions to locate parameters with unmatched curly braces?
And... in all modules having translations? Volunteers welcomed :slight_smile:

Cheers
Andrea

--

GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.

-------------------------------------------------------

8

Andrea, fantastic! Thanks for the fix. I updated translated String at Transifex : https://www.transifex.com/GeoServer/geoserver/translate/#tr/web_core/7529723?key=showingAllRecords

However, ther was a warning displayed in the Translation-UI, that not all Braces from origin string can be found in the translated String. I guess I should add a hint to https://github.com/fgdrf/geoserver/blob/406b761bf64a4bf345db2402efc9dd4d04ae3cc0/doc/en/developer/source/translation.rst

Cheers

···

2017-02-20 10:05 GMT+01:00 Andrea Aime <andrea.aime@anonymised.com>:

On Mon, Feb 20, 2017 at 9:14 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:

So to confirm, https://osgeo-org.atlassian.net/browse/GEOS-6927 has been opened against 2.6.2, so no Wicket
behavior changes, the translation has just been broken for a long time.

Turns out I was looking at the wrong string, a different one is used in case all matches appear in a single page, here is the fix, applied to all active branches:

https://github.com/geoserver/geoserver/commit/bdb599e52e0dc214233d6cbd8b50110367dbbc7f

I guess it needs to be brought back to Transifex to avoid further regressions?

I would be good to have some automated validation of these problems, but I’m not too sure how to do it… maybe a test in the build that
uses regular expressions to locate parameters with unmatched curly braces? And… in all modules having translations? Volunteers welcomed :slight_smile:

Cheers

Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Is there a chance behavior of wicked has changed (and since wicket update sprint) for resource handling?

I don’t think so.

So today is release day, I’m going to have a quick look, if I cannot find any way to locate and fix the issue I’ll just remove the Turkish translation

9

There is an option to show Warnings for a ressource, e.g. for web_core module : https://www.transifex.com/GeoServer/geoserver/translate/#tr/web_core?warnings=yes

This would help to identify potential breaking translated fragements …

Downside (for a project haveing 42 resource files) : There is no global aggregated view to show this for all resources at one place.

Cheers

···

2017-02-20 11:22 GMT+01:00 Frank Gasdorf <fgdrf@anonymised.com>:

Andrea, fantastic! Thanks for the fix. I updated translated String at Transifex : https://www.transifex.com/GeoServer/geoserver/translate/#tr/web_core/7529723?key=showingAllRecords

However, ther was a warning displayed in the Translation-UI, that not all Braces from origin string can be found in the translated String. I guess I should add a hint to https://github.com/fgdrf/geoserver/blob/406b761bf64a4bf345db2402efc9dd4d04ae3cc0/doc/en/developer/source/translation.rst

Cheers

Frank

2017-02-20 10:05 GMT+01:00 Andrea Aime <andrea.aime@anonymised.com>:

On Mon, Feb 20, 2017 at 9:14 AM, Andrea Aime <andrea.aime@anonymised.com…> wrote:

So to confirm, https://osgeo-org.atlassian.net/browse/GEOS-6927 has been opened against 2.6.2, so no Wicket
behavior changes, the translation has just been broken for a long time.

Turns out I was looking at the wrong string, a different one is used in case all matches appear in a single page, here is the fix, applied to all active branches:

https://github.com/geoserver/geoserver/commit/bdb599e52e0dc214233d6cbd8b50110367dbbc7f

I guess it needs to be brought back to Transifex to avoid further regressions?

I would be good to have some automated validation of these problems, but I’m not too sure how to do it… maybe a test in the build that
uses regular expressions to locate parameters with unmatched curly braces? And… in all modules having translations? Volunteers welcomed :slight_smile:

Cheers

Andrea

–

==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313

fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

AVVERTENZE AI SENSI DEL D.Lgs. 196/2003

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.

Is there a chance behavior of wicked has changed (and since wicket update sprint) for resource handling?

I don’t think so.

So today is release day, I’m going to have a quick look, if I cannot find any way to locate and fix the issue I’ll just remove the Turkish translation