[Geoserver-devel] turned auto formatting off

Hi all,

Due to recent problems cross platform with formatting i have turned auto
formatting off. It can be re enabled by editing one line in the root
pom.xml when we actually lick this problem.

I believe we have the extended character problem solved as long as you
running with a iso-8859-1 locale. But I still cant figure out the
end-of-line thing.

An example is KMLWriterTest.java in the test module. I tried formatting
it in both windows and linux today and still get eol problems. Which is
wierd because i can not see any differences from that file then with
other files in that module.

They all have the same svn properties set and file encoding... so i am
at a loss.

For the meantime i suggest we adopt a strategy of developers formatting
manually when they commit. Or doing a batch format when it comes release
time. Any thoughts?

-Justin

--
Justin Deoliveira
The Open Planning Project
jdeolive@anonymised.com

Justin Deoliveira ha scritto:

Hi all,

Due to recent problems cross platform with formatting i have turned auto
formatting off. It can be re enabled by editing one line in the root
pom.xml when we actually lick this problem.

I believe we have the extended character problem solved as long as you
running with a iso-8859-1 locale. But I still cant figure out the
end-of-line thing.

An example is KMLWriterTest.java in the test module. I tried formatting
it in both windows and linux today and still get eol problems. Which is
wierd because i can not see any differences from that file then with
other files in that module.

They all have the same svn properties set and file encoding... so i am
at a loss.

For the meantime i suggest we adopt a strategy of developers formatting
manually when they commit. Or doing a batch format when it comes release
time. Any thoughts?

Go for the batch format. Formatting every time is good too provided the
formatting does not hide the change, which may happen if you're editing
a file that was previously committed without formatting it.

Cheers
Andrea