[Geoserver-devel] Updates for geoserver-sync on 2.5.x branch

We updated the geoserver-sync module to track some changes since it was initially pulled.

  1. Fixed the module to build with rename of main to gs-main and wfs to gs-wfs
  2. Sort the attributes before adding value to SHA-1 since differences in client and server libraries can lead to different checksums for the same features otherwise
  3. Switched to using standard GML3 output for final phase of sending out of sync features vice a custom format which was not needed.

I submitted a pull request on the 2.5.x branch.

Dale, can yo submit the Geogrorian calendar fixes or shoot the diffs to me and I’ll work a pull request for that too.

Robert Hastings, Lab-SDL: 619-553-7006, Cell: 858-395-4436, Moebius: 858-455-5431x210, Lab-250: 619-553-2263

Robert,

Attached is the patch file for the changes made to GeoServer.

(attachments)

0001-Enabled-sorting-and-add-XMLGregorianCalandar-support.patch (5.34 KB)

···

Thanks,

Dale

(619)302-7637

From: Robert Hastings [mailto:rhastings@…3842…]
Sent: Saturday, March 08, 2014 5:49 PM
To: geoserver-devel@lists.sourceforge.net
Cc: Dale F. McIntosh
Subject: Updates for geoserver-sync on 2.5.x branch

We updated the geoserver-sync module to track some changes since it was initially pulled.

  1. Fixed the module to build with rename of main to gs-main and wfs to gs-wfs

  2. Sort the attributes before adding value to SHA-1 since differences in client and server libraries can lead to different checksums for the same features otherwise

  3. Switched to using standard GML3 output for final phase of sending out of sync features vice a custom format which was not needed.

I submitted a pull request on the 2.5.x branch.

Dale, can yo submit the Geogrorian calendar fixes or shoot the diffs to me and I’ll work a pull request for that too.

Robert Hastings, Lab-SDL: 619-553-7006, Cell: 858-395-4436, Moebius: 858-455-5431x210, Lab-250: 619-553-2263

Hmm, I forgot to link to the pull request:

Robert Hastings, Lab-SDL: 619-553-7006, Cell: 858-395-4436, Moebius: 858-455-5431x210, Lab-250: 619-553-2263


From: “Robert Hastings” rhastings@anonymised.com
To: geoserver-devel@lists.sourceforge.net
Cc: “Dale F. McIntosh” dmcintosh@anonymised.com
Sent: Saturday, March 8, 2014 5:48:55 PM
Subject: Updates for geoserver-sync on 2.5.x branch

We updated the geoserver-sync module to track some changes since it was initially pulled.

  1. Fixed the module to build with rename of main to gs-main and wfs to gs-wfs
  2. Sort the attributes before adding value to SHA-1 since differences in client and server libraries can lead to different checksums for the same features otherwise
  3. Switched to using standard GML3 output for final phase of sending out of sync features vice a custom format which was not needed.

I submitted a pull request on the 2.5.x branch.

Dale, can yo submit the Geogrorian calendar fixes or shoot the diffs to me and I’ll work a pull request for that too.

Robert Hastings, Lab-SDL: 619-553-7006, Cell: 858-395-4436, Moebius: 858-455-5431x210, Lab-250: 619-553-2263

On Tue, Mar 11, 2014 at 1:26 AM, Robert Hastings <rhastings@anonymised.com>wrote:

Hmm, I forgot to link to the pull request:
- https://github.com/geoserver/geoserver/pull/529

Hi Robert,
thanks for the updates, I'll try to have a look, and port over to master
branch, as soon
as I can (which might be next weekend)

Cheers
Andrea

--

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

Andrea, I don’t mind porting over to the master branch myself. I was hoping that getting these changes on the 2.5.x branch would allow them to get into 2.5-RC3 or a final 2.5.

Robert Hastings, Lab-SDL: 619-553-7006, Cell: 858-395-4436, Moebius: 858-455-5431x210, Lab-250: 619-553-2263

···

On Tue, Mar 11, 2014 at 1:26 AM, Robert Hastings <rhastings@anonymised.com> wrote:

Hmm, I forgot to link to the pull request:

Hi Robert,
thanks for the updates, I’ll try to have a look, and port over to master branch, as soon
as I can (which might be next weekend)

Cheers
Andrea

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it


On Tue, Mar 11, 2014 at 6:40 PM, Robert Hastings <rhastings@anonymised.com>wrote:

Andrea, I don't mind porting over to the master branch myself. I was
hoping that getting these changes on the 2.5.x branch would allow them to
get into 2.5-RC3 or a final 2.5.

Oh no, that is not possible anyways, your module is not an official
extension, community modules never get into releases,
they are only available in nightly builds:
http://ares.boundlessgeo.com/geoserver/release/

In order to push a module to extension status you have to make an official
proposal and show it
satisfies a minimum set of requirements, here is an example, the proposal
made to graduate
the importer module:

http://geoserver.org/display/GEOS/GSIP+105+-+Promote+importer+module+to+extension+status

All the requirements need to be matched for a module to graduate. Now,
graduating a module in RC
status is probably not the best thing, but if you can tick all the boxes we
might have it for 2.5.1?

Cheers
Andrea

--

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

On Tue, Mar 11, 2014 at 6:48 PM, Andrea Aime
<andrea.aime@anonymised.com>wrote:

On Tue, Mar 11, 2014 at 6:40 PM, Robert Hastings <rhastings@anonymised.com>wrote:

Andrea, I don't mind porting over to the master branch myself. I was
hoping that getting these changes on the 2.5.x branch would allow them to
get into 2.5-RC3 or a final 2.5.

Oh no, that is not possible anyways, your module is not an official
extension, community modules never get into releases,
they are only available in nightly builds:
http://ares.boundlessgeo.com/geoserver/release/

Sorry, here: http://ares.boundlessgeo.com/geoserver/2.5.x/community-latest/

I see the module is not even built nightly, something that you could modify
in your pull request,
provided you can make sure the module will at least compile (tests are not
run for community
modules anyways)

Cheers
Andrea

--

Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------

I meant, that if someone does a checkout of 2.5-RC3 or what ever the tag will be for 2.5 final that they will have a version of the community module with these changes. I understand there is still some work to do before we can convert over to an extension.

Robert Hastings, Lab-SDL: 619-553-7006, Cell: 858-395-4436, Moebius: 858-455-5431x210, Lab-250: 619-553-2263

···

On Tue, Mar 11, 2014 at 6:40 PM, Robert Hastings <rhastings@anonymised.com> wrote:

Andrea, I don’t mind porting over to the master branch myself. I was hoping that getting these changes on the 2.5.x branch would allow them to get into 2.5-RC3 or a final 2.5.

Oh no, that is not possible anyways, your module is not an official extension, community modules never get into releases,
they are only available in nightly builds:
http://ares.boundlessgeo.com/geoserver/release/

In order to push a module to extension status you have to make an official proposal and show it
satisfies a minimum set of requirements, here is an example, the proposal made to graduate
the importer module:

http://geoserver.org/display/GEOS/GSIP+105±+Promote+importer+module+to+extension+status

All the requirements need to be matched for a module to graduate. Now, graduating a module in RC
status is probably not the best thing, but if you can tick all the boxes we might have it for 2.5.1?

Cheers

Andrea

==
Meet us at GEO Business 2014! in London! Visit http://goo.gl/fES3aK
for more information.

Ing. Andrea Aime

@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it