Wicket 7.2.0 was released 20 Jan 2016. In the interests of staying up-to-date, we should consider upgrading.
In addition, this Wicket release includes various bugfixes, included one which partially fixes https://osgeo-org.atlassian.net/browse/GEOS-7925
We are rather close to the release candidate, but I think it is probably best to upgrade sooner rather than later.
Torben
I would rather upgrade now during beta, and use RC to test. We can discuss in tomorrows meeting.
On 6 March 2017 at 16:23, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Wicket 7.2.0 was released 20 Jan 2016. In the interests of staying up-to-date, we should consider upgrading.
In addition, this Wicket release includes various bugfixes, included one which partially fixes https://osgeo-org.atlassian.net/browse/GEOS-7925
We are rather close to the release candidate, but I think it is probably best to upgrade sooner rather than later.
Torben
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Jody Garnett
On Tue, Mar 7, 2017 at 1:23 AM, Torben Barsballe <
tbarsballe@anonymised.com> wrote:
Wicket 7.2.0 was released 20 Jan 2016. In the interests of staying
up-to-date, we should consider upgrading.
Hi,
no objection, just a question. I see 7.6.0 is out, I read somewhere that
the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at
all?
Cheers
Andrea
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
no objection, just a question. I see 7.6.0 is out, I read somewhere that the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at all?
Hadn’t looked at that, just followed the WICKET-6002 bug report to the first version it was fixed in.If 7.6.0 does indeed work as a drop-in replacement, then upgrading to that seems most sensible.
I will update my PR and run tests…
Torben
On Tue, Mar 7, 2017 at 12:31 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
On Tue, Mar 7, 2017 at 1:23 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Wicket 7.2.0 was released 20 Jan 2016. In the interests of staying up-to-date, we should consider upgrading.
Hi,
no objection, just a question. I see 7.6.0 is out, I read somewhere that the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at all?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
Tried out 7.6.0, and it turns out we do have a regression, affecting JAIPage, CoverageAccessPage, and GlobalSettingsPage:
Expected close tag for ‘’ Possible attempt to embed component(s) ‘<wicket:message key=“submit”>’ in the body of this component which discards its body
MarkupStream: [markup = file:/Users/tbarsballe/repos/GeoServer/geoserver/src/web/core/target/classes/org/geoserver/web/admin/GlobalSettingsPage.html
<wicket:message key=“submit”>submit</wicket:message>, index = 1, current = ‘<wicket:message key=“submit”>’ (line 0, column 0)]
at org.apache.wicket.markup.MarkupStream.throwMarkupException(MarkupStream.java:526)
at org.apache.wicket.Component.replaceComponentTagBody(Component.java:4142)
at org.apache.wicket.markup.html.form.Button.onComponentTagBody(Button.java:222)
at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:70)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2601)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1668)
at org.apache.wicket.Component.internalRender(Component.java:2401)
at org.apache.wicket.Component.render(Component.java:2329)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1526)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1729)
at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1704)
at org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1659)
at org.apache.wicket.markup.html.form.Form.onComponentTagBody(Form.java:1707)
at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:70)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2601)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1668)
at org.apache.wicket.Component.internalRender(Component.java:2401)
at org.apache.wicket.Component.render(Component.java:2329)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1526)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1729)
at org.apache.wicket.Page.onRender(Page.java:879)
at org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:141)
at org.apache.wicket.Component.internalRender(Component.java:2401)
at org.apache.wicket.Component.render(Component.java:2329)
at org.apache.wicket.Page.renderPage(Page.java:1018)
…
This regression was introduced in Wicket 7.5.0.
I can get tests to pass again by changing all instances of “Button submit = new Button(“submit”, new StringResourceModel(“submit”, this, null)) {” to “Button submit = new Button(“submit”) {”
This seems to match what the current implementation of most pages. Looking at the javadocs for StringResourceModel, it seems to be partially responsible for localization. I’ve tested in a different locale (French), and everything does appear to be working fine.
We are using StringResourceModel in quite a few other places, and while none of them seem to cause problems, it plausible that there are issues that are not caught by our test cases.
As an alternative, we can just upgrade to Wicket 7.4.0 for now.
Torben
On Tue, Mar 7, 2017 at 10:08 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
no objection, just a question. I see 7.6.0 is out, I read somewhere that the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at all?Hadn’t looked at that, just followed the WICKET-6002 bug report to the first version it was fixed in.
If 7.6.0 does indeed work as a drop-in replacement, then upgrading to that seems most sensible.I will update my PR and run tests…
Torben
On Tue, Mar 7, 2017 at 12:31 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
On Tue, Mar 7, 2017 at 1:23 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Wicket 7.2.0 was released 20 Jan 2016. In the interests of staying up-to-date, we should consider upgrading.
Hi,
no objection, just a question. I see 7.6.0 is out, I read somewhere that the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at all?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
Thanks Torben; I would like to try upgrading to 7.6.0 now (leaving the RC1 to test with). We can do a special request to test localization in the RC1 anouncement. I also note [i18n] Korean properties files synched from Transifex merged by Frank so we have a second reason to ask for localization testing.
On 7 March 2017 at 14:17, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Tried out 7.6.0, and it turns out we do have a regression, affecting JAIPage, CoverageAccessPage, and GlobalSettingsPage:
Expected close tag for ‘’ Possible attempt to embed component(s) ‘<wicket:message key=“submit”>’ in the body of this component which discards its body
MarkupStream: [markup = file:/Users/tbarsballe/repos/GeoServer/geoserver/src/web/core/target/classes/org/geoserver/web/admin/GlobalSettingsPage.html
<wicket:message key=“submit”>submit</wicket:message>, index = 1, current = ‘<wicket:message key=“submit”>’ (line 0, column 0)]
at org.apache.wicket.markup.MarkupStream.throwMarkupException(MarkupStream.java:526)
at org.apache.wicket.Component.replaceComponentTagBody(Component.java:4142)
at org.apache.wicket.markup.html.form.Button.onComponentTagBody(Button.java:222)
at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:70)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2601)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1668)
at org.apache.wicket.Component.internalRender(Component.java:2401)
at org.apache.wicket.Component.render(Component.java:2329)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1526)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1729)
at org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1704)
at org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1659)
at org.apache.wicket.markup.html.form.Form.onComponentTagBody(Form.java:1707)
at org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:70)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2601)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1668)
at org.apache.wicket.Component.internalRender(Component.java:2401)
at org.apache.wicket.Component.render(Component.java:2329)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1526)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1729)
at org.apache.wicket.Page.onRender(Page.java:879)
at org.apache.wicket.markup.html.WebPage.onRender(WebPage.java:141)
at org.apache.wicket.Component.internalRender(Component.java:2401)
at org.apache.wicket.Component.render(Component.java:2329)
at org.apache.wicket.Page.renderPage(Page.java:1018)
…This regression was introduced in Wicket 7.5.0.
I can get tests to pass again by changing all instances of “Button submit = new Button(“submit”, new StringResourceModel(“submit”, this, null)) {” to “Button submit = new Button(“submit”) {”
This seems to match what the current implementation of most pages. Looking at the javadocs for StringResourceModel, it seems to be partially responsible for localization. I’ve tested in a different locale (French), and everything does appear to be working fine.
We are using StringResourceModel in quite a few other places, and while none of them seem to cause problems, it plausible that there are issues that are not caught by our test cases.
As an alternative, we can just upgrade to Wicket 7.4.0 for now.
Torben
Announcing the Oxford Dictionaries API! The API offers world-renowned
dictionary content that is easy and intuitive to access. Sign up for an
account today to start using our lexical data to power your apps and
projects. Get started today and enter our developer competition.
http://sdm.link/oxford
Geoserver-devel mailing list
Geoserver-devel@anonymised.com.366…sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
–
Jody Garnett
On Tue, Mar 7, 2017 at 10:08 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
no objection, just a question. I see 7.6.0 is out, I read somewhere that the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at all?Hadn’t looked at that, just followed the WICKET-6002 bug report to the first version it was fixed in.
If 7.6.0 does indeed work as a drop-in replacement, then upgrading to that seems most sensible.I will update my PR and run tests…
Torben
On Tue, Mar 7, 2017 at 12:31 AM, Andrea Aime <andrea.aime@anonymised.com> wrote:
On Tue, Mar 7, 2017 at 1:23 AM, Torben Barsballe <tbarsballe@anonymised.com> wrote:
Wicket 7.2.0 was released 20 Jan 2016. In the interests of staying up-to-date, we should consider upgrading.
Hi,
no objection, just a question. I see 7.6.0 is out, I read somewhere that the 7.x series versions
are supposed to be a drop-in replacement. Did you look into this option at all?
Cheers
Andrea
–
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy’s New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.