[Geoserver-devel] Upgrading formatter plugin to the latest version (compatible with Java 8)?

Andrea_Aime4 · December 4, 2021, 6:34pm

Hi all,
I have setup a draft PR for GeoTools showing the results of formatting using
the latest Java 8 compatible version of the Google Java formatter (they eventually
started requiring Java 11 as the minimum, this one is the latest that’s still Java 8 compatible):
https://github.com/geotools/geotools/pull/3697

I like how the streams are formatter in a bit more compact way, don’t mind the different
formatting of long/complex annotations.

What do you think?

If approved, I’ll make sure to apply the formatting in all projects, and all active branches, at the same time, so as to reduce PR backport efforts.

Cheers
Andrea

···

Regards,

Andrea Aime

==
GeoServer Professional Services from the experts!

Visit http://bit.ly/gs-services-us for more information.

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions Group
phone: +39 0584 962313

fax: +39 0584 1660272

mob: +39 333 8128928

https://www.geosolutionsgroup.com/

http://twitter.com/geosolutions_it

Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia.

This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail

jive · December 6, 2021, 10:31pm

Go for it!

···

–
Jody Garnett

Andrea_Aime4 · December 7, 2021, 9:25am

After sending the mail I found the newer version of the plugin emits some pretty annoying logging.
It has been fixed on the latest releases, requiring Java 11, while the series supporting Java 8 seems to be dead by now… options I see:

The logging fix is trivial, I could apply the patch on the 2.9.x branch and just make a custom release for us
Switch to another formatter, “spotless”, that allows to freely choose the version of google-java-format to be used… that would require new tests, and docs updates
I’ll think about it. Any strong preference?