[Geoserver-devel] URL encoding

GeoServer GeoServer Developer
1

Hello folks,

At the moment I am hosting Geoserver at an https:// URL; however, after
deployment, all of the WMS/WFS links are http:// instead of https://. Is
there any way to configure this or is this a bug? Thank you.

v/r,
Efren

2

Hi Efren,

Yes this probably is a bug, I am sure there are places where http:// urls are being hardcoded. Can you be more specific about where this is happening.

-Justin

Efren Serra wrote:

Hello folks,

At the moment I am hosting Geoserver at an https:// URL; however, after
deployment, all of the WMS/WFS links are http:// instead of https://. Is
there any way to configure this or is this a bug? Thank you.

v/r,
Efren

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

3

Justin,

In here:

WFS:
getCapabilities link
TestWfsPost link

WMS:
getCapabilities link

Mapbuilder Demo links

Also, the Demo Request page loads the URL text field as http: instead of the
protocol being used. I take it this is probably done in the JSPs, eh?
Thank you.

v/r,
Efren

-----Original Message-----
From: Justin Deoliveira [mailto:jdeolive@anonymised.com]
Sent: Wednesday, October 26, 2005 3:42 PM
To: efren.serra.ctr@anonymised.com
Cc: Geoserver-Devel
Subject: Re: [Geoserver-devel] URL encoding

Hi Efren,

Yes this probably is a bug, I am sure there are places where http://
urls are being hardcoded. Can you be more specific about where this is
happening.

-Justin

Efren Serra wrote:

Hello folks,

At the moment I am hosting Geoserver at an https:// URL; however, after
deployment, all of the WMS/WFS links are http:// instead of https://. Is
there any way to configure this or is this a bug? Thank you.

v/r,
Efren

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

4

Justin,

Here is the offending method in org.vfny.geoserver.util.Requests class:

    public static String getBaseUrl(HttpServletRequest httpServletRequest) {
/*
* didier (2004/10/03) assumption removed :
* return "http://" + httpServletRequest.getServerName() + ":"
* + httpServletRequest.getServerPort() + "/geoserver/";
*/
        return "http://" + httpServletRequest.getServerName() + ":"
        + httpServletRequest.getServerPort() +
httpServletRequest.getContextPath() +"/";
    }

v/r,
Efren
-----Original Message-----
From: Justin Deoliveira [mailto:jdeolive@anonymised.com]
Sent: Wednesday, October 26, 2005 3:42 PM
To: efren.serra.ctr@anonymised.com
Cc: Geoserver-Devel
Subject: Re: [Geoserver-devel] URL encoding

Hi Efren,

Yes this probably is a bug, I am sure there are places where http://
urls are being hardcoded. Can you be more specific about where this is
happening.

-Justin

Efren Serra wrote:

Hello folks,

At the moment I am hosting Geoserver at an https:// URL; however, after
deployment, all of the WMS/WFS links are http:// instead of https://. Is
there any way to configure this or is this a bug? Thank you.

v/r,
Efren

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

5

Justin,

I think it just be doing return httpServletRequest.getRequestURL() instead.

v/r,
Efren

-----Original Message-----
From: Justin Deoliveira [mailto:jdeolive@anonymised.com]
Sent: Wednesday, October 26, 2005 3:42 PM
To: efren.serra.ctr@anonymised.com
Cc: Geoserver-Devel
Subject: Re: [Geoserver-devel] URL encoding

Hi Efren,

Yes this probably is a bug, I am sure there are places where http://
urls are being hardcoded. Can you be more specific about where this is
happening.

-Justin

Efren Serra wrote:

Hello folks,

At the moment I am hosting Geoserver at an https:// URL; however, after
deployment, all of the WMS/WFS links are http:// instead of https://. Is
there any way to configure this or is this a bug? Thank you.

v/r,
Efren

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

6

Hi Efren,

This is great, thanks a bunch for tracking these down. Would you mind throwing it in Jira so it doesn't get lost. And if you would like, you can assign it to yourself and submit a patch. If not just throw your findings into the comments and someone will track them down.

Thanks,

Justin

Efren Serra wrote:

Justin,

I think it just be doing return httpServletRequest.getRequestURL() instead.

v/r,
Efren

-----Original Message-----
From: Justin Deoliveira [mailto:jdeolive@anonymised.com]
Sent: Wednesday, October 26, 2005 3:42 PM
To: efren.serra.ctr@anonymised.com
Cc: Geoserver-Devel
Subject: Re: [Geoserver-devel] URL encoding

Hi Efren,

Yes this probably is a bug, I am sure there are places where http:// urls are being hardcoded. Can you be more specific about where this is happening.

-Justin

Efren Serra wrote:

Hello folks,

At the moment I am hosting Geoserver at an https:// URL; however, after
deployment, all of the WMS/WFS links are http:// instead of https://. Is
there any way to configure this or is this a bug? Thank you.

v/r,
Efren

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of 2005
Visit http://www.jboss.com/services/certification for more information
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

--
Justin Deoliveira
The Open Planning Project
http://topp.openplans.org

7

This used to be a config option, there are some downsides as I recall with guessing based on the request (only occurs with proxies, and the more advanced application containers...)

Jody

8

Jody,

HttpServletRequest extends HttpServlet which provides the getScheme() public
method (e.g., http, https, ftp, etc.); I don't think there is guessing
involved. However, I could be wrong. I think substituting the hardcoded
"http://" with getScheme() + "://" is more appropriate.

v/r,
Efren

-----Original Message-----
From: Jody Garnett [mailto:jgarnett@anonymised.com]
Sent: Wednesday, October 26, 2005 4:47 PM
To: Justin Deoliveira
Cc: efren.serra.ctr@anonymised.com; Geoserver-Devel
Subject: Re: [Geoserver-devel] URL encoding

This used to be a config option, there are some downsides as I recall
with guessing based on the request (only occurs with proxies, and the
more advanced application containers...)

Jody

9

I think you're right, it makes a ton of sense that httpservlet would
provide a method to figure such a thing out, indeed I would be
surprised if there wasn't. There are of course some more complex
issues with other things as Jody points out, but I think this fix will
get things a decent bit better. Go ahead and jira it and submit this
as a patch, and you'll be on your way to geoserver commit rights :wink:

best regards,

Chris

Quoting Efren Serra <efren.serra.ctr@anonymised.com>:

Jody,

HttpServletRequest extends HttpServlet which provides the getScheme()
public
method (e.g., http, https, ftp, etc.); I don't think there is
guessing
involved. However, I could be wrong. I think substituting the
hardcoded
"http://" with getScheme() + "://" is more appropriate.

v/r,
Efren

-----Original Message-----
From: Jody Garnett [mailto:jgarnett@anonymised.com]
Sent: Wednesday, October 26, 2005 4:47 PM
To: Justin Deoliveira
Cc: efren.serra.ctr@anonymised.com; Geoserver-Devel
Subject: Re: [Geoserver-devel] URL encoding

This used to be a config option, there are some downsides as I recall
with guessing based on the request (only occurs with proxies, and the
more advanced application containers...)

Jody

-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.
Get Certified Today * Register for a JBoss Training Course
Free Certification Exam for All Training Attendees Through End of
2005
Visit http://www.jboss.com/services/certification for more
information
_______________________________________________
Geoserver-devel mailing list
Geoserver-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

----------------------------------------------------------
This mail sent through IMP: https://webmail.limegroup.com/